From: Christoph Hellwig <hch@lst.de>
To: Kari Argillander <kari.argillander@gmail.com>
Cc: Konstantin Komarov <almaz.alexandrovich@paragon-software.com>,
ntfs3@lists.linux.dev, Christoph Hellwig <hch@lst.de>,
linux-kernel@vger.kernel.org, Joe Perches <joe@perches.com>
Subject: Re: [PATCH v3 0/3] fs/ntfs3: Use kernel alloc wrappers and fix warnings
Date: Wed, 18 Aug 2021 07:23:40 +0200 [thread overview]
Message-ID: <20210818052340.GA9053@lst.de> (raw)
In-Reply-To: <20210818010649.412912-1-kari.argillander@gmail.com>
On Wed, Aug 18, 2021 at 04:06:46AM +0300, Kari Argillander wrote:
> In ntfs3 driver there is allocation made like this ntfs_malloc().
> Patch 2/3 will converter these to kernel ones like kmalloc(). After I
> did this then checkpatch raise warnings about array allocations so I
> fix these in patch 3/3.
>
> I also notice when I made patch that there is broken utf8 char so I
> wanted first fix that because it raised some warning in my editor and
> did not want to "break" patch 2/3. So patch 1/3 address that. I did
> try to apply this and it seem to work without issues.
So this mostly looks sensible, but I still haven't actually seen
the codebase this applies to posted anywhere as far as I can tell.
prev parent reply other threads:[~2021-08-18 5:23 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-18 1:06 [PATCH v3 0/3] fs/ntfs3: Use kernel alloc wrappers and fix warnings Kari Argillander
2021-08-18 1:06 ` [PATCH v3 1/3] fs/ntfs3: Fix one none utf8 char in source file Kari Argillander
2021-08-18 5:33 ` Christoph Hellwig
2021-08-18 8:56 ` Kari Argillander
2021-08-18 1:06 ` [PATCH v3 2/3] fs/ntfs3: Do not use driver own alloc wrappers Kari Argillander
2021-08-24 8:04 ` Christoph Hellwig
2021-08-18 1:06 ` [PATCH v3 3/3] fs/ntfs3: Use kcalloc/kmalloc_array over kzalloc/kmalloc Kari Argillander
2021-08-24 8:04 ` Christoph Hellwig
2021-08-18 5:23 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210818052340.GA9053@lst.de \
--to=hch@lst.de \
--cc=almaz.alexandrovich@paragon-software.com \
--cc=joe@perches.com \
--cc=kari.argillander@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ntfs3@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.