From: Pavel Machek <pavel@ucw.cz>
To: "Michal Vokáč" <michal.vokac@ysoft.com>
Cc: Shawn Guo <shawnguo@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Fabio Estevam <festevam@gmail.com>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
NXP Linux Team <linux-imx@nxp.com>,
Jacek Anaszewski <jacek.anaszewski@gmail.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org, linux-leds@vger.kernel.org
Subject: Re: [PATCH 1/2] ARM: dts: imx6dl-yapp4: Fix lp5562 LED driver probe
Date: Wed, 18 Aug 2021 09:08:50 +0200 [thread overview]
Message-ID: <20210818070850.GG22282@amd> (raw)
In-Reply-To: <20210818070209.1540451-1-michal.vokac@ysoft.com>
[-- Attachment #1: Type: text/plain, Size: 964 bytes --]
On Wed 2021-08-18 09:02:08, Michal Vokáč wrote:
> Since the LED multicolor framework support was added in commit
> 92a81562e695 ("leds: lp55xx: Add multicolor framework support to lp55xx")
> LEDs on this platform stopped working.
>
> Author of the framework attempted to accommodate this DT to the
> framework in commit b86d3d21cd4c ("ARM: dts: imx6dl-yapp4: Add reg property
> to the lp5562 channel node") but that is not sufficient. A color property
> is now required even if the multicolor framework is not used, otherwise
> the driver probe fails:
>
> lp5562: probe of 1-0030 failed with error -22
>
> Add the color property to fix this.
>
> Fixes: 92a81562e695 ("leds: lp55xx: Add multicolor framework support to lp55xx")
> Cc: <stable@vger.kernel.org>
> Cc: linux-leds@vger.kernel.org
> Signed-off-by: Michal Vokáč <michal.vokac@ysoft.com>
Acked-by: Pavel Machek <pavel@ucw.cz>
--
http://www.livejournal.com/~pavelmachek
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
next prev parent reply other threads:[~2021-08-18 7:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-18 7:02 [PATCH 1/2] ARM: dts: imx6dl-yapp4: Fix lp5562 LED driver probe Michal Vokáč
2021-08-18 7:02 ` [PATCH 2/2] ARM: dts: imx6dl-yapp4: Remove the unused white LED channel Michal Vokáč
2021-08-18 7:09 ` Pavel Machek
2021-09-13 13:03 ` Fabio Estevam
2021-08-18 7:08 ` Pavel Machek [this message]
2021-09-13 11:20 ` [PATCH 1/2] ARM: dts: imx6dl-yapp4: Fix lp5562 LED driver probe Michal Vokáč
2021-09-13 13:03 ` Fabio Estevam
2021-09-22 3:10 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210818070850.GG22282@amd \
--to=pavel@ucw.cz \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=jacek.anaszewski@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=michal.vokac@ysoft.com \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.