From: Anatolij Gustschin <agust@denx.de>
To: Tom Rini <trini@konsulko.com>
Cc: u-boot@lists.denx.de, Samuel Egli <samuel.egli@siemens.com>,
Heiko Schocher <hs@denx.de>
Subject: Re: [PATCH 05/13] siemens: Move CONFIG_SYS_I2C_EEPROM_ADDR usage out of CONFIG namespace
Date: Wed, 18 Aug 2021 11:02:28 +0200 [thread overview]
Message-ID: <20210818110228.74958771@crub> (raw)
In-Reply-To: <20210817220009.22721-6-trini@konsulko.com>
On Tue, 17 Aug 2021 17:59:40 -0400
Tom Rini trini@konsulko.com wrote:
> The instances of CONFIG_SYS_I2C_EEPROM_ADDR on these platforms doesn't
> match up with the rest of the EERPOM related defines in U-Boot. Move
> these out of the CONFIG namespace rather than make complex Kconfig
> logic.
>
> Cc: Samuel Egli <samuel.egli@siemens.com>
> Cc: Anatolij Gustschin <agust@denx.de>
> Cc: Heiko Schocher <hs@denx.de>
> Signed-off-by: Tom Rini <trini@konsulko.com>
Reviewed-by: Anatolij Gustschin <agust@denx.de>
But probably some more cleanup in other board config headers needed,
see comment below.
...
> diff --git a/include/configs/draco.h b/include/configs/draco.h
> index 396eb7ded500..7c1f071d99ec 100644
> --- a/include/configs/draco.h
> +++ b/include/configs/draco.h
> @@ -32,10 +32,6 @@
> /* I2C Configuration */
> #define CONFIG_SYS_I2C_SPEED 100000
>
> -#define CONFIG_SYS_I2C_EEPROM_ADDR 0x50
> -#define EEPROM_ADDR_DDR3 0x90
> -#define EEPROM_ADDR_CHIP 0x120
these defines are also in
include/configs/etamin.h
include/configs/rastaban.h
include/configs/thuban.h
--
Anatolij
next prev parent reply other threads:[~2021-08-18 9:02 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-17 21:59 [PATCH 00/13] Migrate some I2C symbols to Kconfig Tom Rini
2021-08-17 21:59 ` [PATCH 01/13] kp_imx53: Switch to using a local namespace for ID EEPROM Tom Rini
2021-08-18 8:03 ` Lukasz Majewski
2021-08-30 20:58 ` Tom Rini
2021-08-17 21:59 ` [PATCH 02/13] davinci: Drop CONFIG_MAC_ADDR_IN_EEPROM Tom Rini
2021-08-17 21:59 ` [PATCH 03/13] arm: shc: Change CONFIG_SYS_I2C_EEPROM_ADDR to EEPROM_ADDR Tom Rini
2021-08-18 3:46 ` Heiko Schocher
2021-08-17 21:59 ` [PATCH 04/13] keymile: Use CONFIG_SYS_IVM_EEPROM_ADR Tom Rini
2021-08-19 8:05 ` Aleksandar Gerasimovski
2021-08-17 21:59 ` [PATCH 05/13] siemens: Move CONFIG_SYS_I2C_EEPROM_ADDR usage out of CONFIG namespace Tom Rini
2021-08-18 3:47 ` Heiko Schocher
2021-08-18 9:02 ` Anatolij Gustschin [this message]
2021-08-18 13:38 ` Tom Rini
2021-08-17 21:59 ` [PATCH 06/13] Convert CONFIG_ID_EEPROM to Kconfig Tom Rini
2021-08-17 21:59 ` [PATCH 07/13] i2c: S3C24X0: Finish Kconfig migration Tom Rini
2021-08-25 5:38 ` Minkyu Kang
2021-08-28 5:14 ` Jaehoon Chung
2021-08-17 21:59 ` [PATCH 08/13] cl-som-imx7: Enable CMD_EEPROM Tom Rini
2021-08-17 21:59 ` [PATCH 09/13] eeprom: Drop CONFIG_ENV_EEPROM_IS_ON_I2C usage Tom Rini
2021-08-17 21:59 ` [PATCH 10/13] Convert CONFIG_SYS_I2C_EEPROM_ADDR et al to Kconfig Tom Rini
2021-08-17 21:59 ` [PATCH 11/13] Convert CONFIG_SYS_I2C_SOFT " Tom Rini
2021-08-18 4:35 ` Samuel Holland
2021-08-18 13:37 ` Tom Rini
2021-08-17 21:59 ` [PATCH 12/13] Convert CONFIG_SYS_I2C_MVTWSI " Tom Rini
2021-08-17 21:59 ` [PATCH 13/13] i2c: Remove unused additional legacy soft i2c bus support Tom Rini
2021-08-19 3:12 ` [PATCH 00/16] Further I2C Kconfig migrations Tom Rini
2021-08-19 3:12 ` [PATCH 01/16] Convert CONFIG_SYS_I2C_LEGACY to Kconfig and add CONFIG_[ST]PL_SYS_I2C_LEGACY Tom Rini
2021-08-30 20:59 ` Tom Rini
2021-08-19 3:12 ` [PATCH 02/16] Convert CONFIG_SYS_I2C_EARLY_INIT to Kconfig Tom Rini
2021-08-19 3:12 ` [PATCH 03/16] i2c: designware: Remove unused non-DM functionality Tom Rini
2021-08-19 3:12 ` [PATCH 04/16] am335x: Drop non-DM_I2C code Tom Rini
2021-08-19 3:12 ` [PATCH 05/16] am43xx: " Tom Rini
2021-08-19 11:24 ` Lokesh Vutla
2021-08-19 3:12 ` [PATCH 06/16] ti: i2c: Convert CONFIG_SYS_OMAP24_I2C to CONFIG_SYS_I2C namespace Tom Rini
2021-08-19 3:12 ` [PATCH 07/16] i2c: Remove non-DM code from ihs_i2c.c Tom Rini
2021-08-19 3:12 ` [PATCH 08/16] cmd/i2c.c: Remove unused legacy code Tom Rini
2021-08-19 3:12 ` [PATCH 09/16] Convert CONFIG_SYS_I2C_SPEED et al to Kconfig Tom Rini
2021-08-19 3:12 ` [PATCH 10/16] Convert CONFIG_SYS_I2C_MXC " Tom Rini
2021-08-19 3:12 ` [PATCH 11/16] rcar: i2c: Migrate SYS_I2C_SH " Tom Rini
2021-08-19 3:12 ` [PATCH 12/16] i2c: fsl_i2c: Migrate " Tom Rini
2021-08-19 3:12 ` [PATCH 13/16] tegra: Cleanup I2C support Tom Rini
2021-08-19 3:12 ` [PATCH 14/16] Convert CONFIG_I2C_SET_DEFAULT_BUS_NUM et al to Kconfig Tom Rini
2021-08-19 3:12 ` [PATCH 15/16] README: Remove some old i2c related text Tom Rini
2021-08-25 5:38 ` Minkyu Kang
2021-08-19 3:12 ` [PATCH 16/16] varisys: Remove dead code Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210818110228.74958771@crub \
--to=agust@denx.de \
--cc=hs@denx.de \
--cc=samuel.egli@siemens.com \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.