From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E5727C4320E for ; Wed, 18 Aug 2021 17:04:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D04BA6102A for ; Wed, 18 Aug 2021 17:04:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233110AbhHRREr (ORCPT ); Wed, 18 Aug 2021 13:04:47 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:39121 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231270AbhHRREr (ORCPT ); Wed, 18 Aug 2021 13:04:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1629306252; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=HEJP7HIWBn8mMt7k4XmJIok4RhmUZ7RY4/8EvTqTX6U=; b=BwR9kPemq4yWNXmzRQCXKscW45dKRglyzAF4gWmRSn4vTjdwEFdP1+gBP47ccGr20r1+zk SkF0Fn2ETeTC7Pk7E8awXpsHuTcJfmUWMh8XK7gzWbz2Y/uA5x5guCDbi+Llw2KdFaixoW O+hr/pkxUViEaXaj2QF56mdNKgVmaHk= Received: from mail-pj1-f69.google.com (mail-pj1-f69.google.com [209.85.216.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-184-2xiF52F3PiiAQdYeLt4X7g-1; Wed, 18 Aug 2021 13:04:10 -0400 X-MC-Unique: 2xiF52F3PiiAQdYeLt4X7g-1 Received: by mail-pj1-f69.google.com with SMTP id j14-20020a17090a318e00b001796382f0caso1510549pjb.5 for ; Wed, 18 Aug 2021 10:04:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :in-reply-to; bh=HEJP7HIWBn8mMt7k4XmJIok4RhmUZ7RY4/8EvTqTX6U=; b=kORlR/sqLIn7n8+5NIVZy1cLFRv/vON46nbNnP+x1ZFujVBsal75t2K9+tn8xYq8pI eK99PhwBDdwPo1QNJ8U5N7CQZtgza7Bl9hyM227+kxM0Gws7XShJdSEnYYnANPYW4Vz0 AwyBNyaSnIOH0Ymd2N2/JdcR4EAhZnVXpin0R+E/iPybHWlwukY6Z6lBYQ6NJLlNpTAE jFZxdW4XjwF9MEdzF/bofTHs2sUvgJFesKtrpivYbjutcFdxmUjVHAtW9oqymA+sqHg3 L+GVaXF4g2L01B2Nl/U31yJqCIZNcEI9yV68GnGWggfKLkAZS0Ic4emDgmIs3Iek2g0F PStA== X-Gm-Message-State: AOAM532GifgwFPp7CBvbJvHOPnMPYFlGXJkpNAuiMCp4/nDXeM2uyPAl 69knoBh0/GG2g4j7rkk5rfam1Lq5XXMtDlsa5Lp0qacvWc9pQvbwh0n3uGimfXcMCnbpd15qSaP Ib/MLurt17od/XAthlw== X-Received: by 2002:a63:f154:: with SMTP id o20mr9767020pgk.172.1629306249640; Wed, 18 Aug 2021 10:04:09 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyiV0B+pxkwgeEv7B1cWz1zMVlwV1ICw0gS5kmdxk3Ssr7n8n+fPJcpBbOHmbzPD5tf1R4m2Q== X-Received: by 2002:a63:f154:: with SMTP id o20mr9767001pgk.172.1629306249410; Wed, 18 Aug 2021 10:04:09 -0700 (PDT) Received: from fedora ([209.132.188.80]) by smtp.gmail.com with ESMTPSA id j35sm323274pgm.55.2021.08.18.10.04.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Aug 2021 10:04:09 -0700 (PDT) Date: Thu, 19 Aug 2021 01:16:47 +0800 From: Zorro Lang To: Jan Kara Cc: Boyang Xue , fstests@vger.kernel.org, linux-ext4@vger.kernel.org Subject: Re: [PATCH] ext4: regression test for "tune2fs -l" after ext4 shutdown Message-ID: <20210818171647.pllyrawwdl7cppsl@fedora> Mail-Followup-To: Jan Kara , Boyang Xue , fstests@vger.kernel.org, linux-ext4@vger.kernel.org References: <20210818084126.4167799-1-bxue@redhat.com> <20210818114517.kqvfzu2vd45vuhze@fedora> <20210818142601.GF28119@quack2.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210818142601.GF28119@quack2.suse.cz> Precedence: bulk List-ID: X-Mailing-List: fstests@vger.kernel.org On Wed, Aug 18, 2021 at 04:26:01PM +0200, Jan Kara wrote: > On Wed 18-08-21 21:20:44, Boyang Xue wrote: > > > > + > > > > +# real QA test starts here > > > > +_supported_fs ext4 > > > > > > I'm wondering if this case can be a generic case, there's nothing > > > ext4 specified operations, except this line: > > > > > > "$TUNE2FS_PROG -l $SCRATCH_DEV" > > > > > > Hmm... if we can change this line to something likes _get_fs_super(), > > > it might help to make this test to be a generic test. > > > > I think this bug is heavily related to "tune2fs", ext4 only. So I > > guess an ext4 only test is enough? > > FWIW I agree with Boyang here. For this test to make sense for any other > filesystem other the filesystem would need to read fs metadata through > buffer cache in _get_fs_super(). Furthermore it is somewhat ext2/3/4 > specific (due to historical reasons) that reading superblock from the > buffer cache of a mounted filesystem is expected to result in something > sensible. Usually this is plain unsupported use... Thanks for this explanation:) I didn't ask for extending this test to be a generic test, just checking others ideas:) Due to although tune2fs is special, but the test steps are common: 1) mkfs 2) mount 3) write io 4) shutdown fs 5) umount && mount 6) read sb from a mounted fs (make sure using tune2fs for ext4) Anyway, keep this test as ext4 only is fine for me :) Thanks, Zorro > > Honza > -- > Jan Kara > SUSE Labs, CR >