From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: Illia Bitkov <illia.bitkov@mind.be>
Cc: Angelo Compagnucci <angelo.compagnucci@gmail.com>,
buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/mono: force internal libatomic-ops for some arm variants
Date: Thu, 19 Aug 2021 00:05:11 +0200 [thread overview]
Message-ID: <20210819000511.401a2bc1@windsurf> (raw)
In-Reply-To: <20210818190345.2081421-1-illia.bitkov@mind.be>
Hello Illia,
On Wed, 18 Aug 2021 21:03:45 +0200
Illia Bitkov <illia.bitkov@mind.be> wrote:
> Fixes:
> http://autobuild.buildroot.net/results/18b017dd5b9c1d8d6c91303ea4f1fdd3e1b086e0/
> http://autobuild.buildroot.net/results/1d262e9ad5bf8bf437bc3f2a709d84acf854d298/
> Signed-off-by: Illia Bitkov <illia.bitkov@mind.be>
Thanks a lot, but this needs more explanation. Why is libatomic_ops not
working for those platforms ?
> ---
> package/mono/Config.in | 2 +-
> package/mono/mono.mk | 10 ++++++++--
> 2 files changed, 9 insertions(+), 3 deletions(-)
>
> diff --git a/package/mono/Config.in b/package/mono/Config.in
> index 44b8cf8581..3f26bd4092 100644
> --- a/package/mono/Config.in
> +++ b/package/mono/Config.in
> @@ -16,7 +16,7 @@ config BR2_PACKAGE_MONO
> depends on BR2_INSTALL_LIBSTDCPP
> depends on BR2_TOOLCHAIN_HAS_THREADS
> depends on !BR2_STATIC_LIBS
> - select BR2_PACKAGE_LIBATOMIC_OPS
> + select BR2_PACKAGE_LIBATOMIC_OPS if !BR2_xscale && !BR2_arm926t
> help
> An open source, cross-platform, implementation of C#
> and the CLR that is binary compatible with Microsoft.NET.
> diff --git a/package/mono/mono.mk b/package/mono/mono.mk
> index 27f7886224..e697ed7ea2 100644
> --- a/package/mono/mono.mk
> +++ b/package/mono/mono.mk
> @@ -43,8 +43,14 @@ endif
>
> MONO_DEPENDENCIES += \
> host-mono \
> - $(if $(BR2_PACKAGE_LIBUNWIND),libunwind) \
> - libatomic_ops
> + $(if $(BR2_PACKAGE_LIBUNWIND),libunwind)
> +
> +ifeq ($(BR2_xscale)$(BR2_arm926t),nn)
This is wrong, options never have the value "n"
> +MONO_DEPENDENCIES += libatomic_ops
> +else
> +#force use of internal libatomic-ops
> +MONO_CONF_OPTS += --with-libatomic-ops=no
> +endif
Thanks,
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
next prev parent reply other threads:[~2021-08-18 22:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-18 19:03 [Buildroot] [PATCH 1/1] package/mono: force internal libatomic-ops for some arm variants Illia Bitkov
2021-08-18 22:05 ` Thomas Petazzoni [this message]
[not found] ` <CA+vtFZP41G3kTPaCoQbPvqAMsy3nKvev0E6C1PokyeWGE=0mvg@mail.gmail.com>
2021-08-19 12:12 ` Illia Bitkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210819000511.401a2bc1@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=angelo.compagnucci@gmail.com \
--cc=buildroot@buildroot.org \
--cc=illia.bitkov@mind.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.