Re: [PATCH v11 11/12] vduse: Introduce VDUSE - vDPA Device in Userspace

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 3382 bytes --]

Hi Xie,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on vhost/linux-next]
[also build test ERROR on linus/master next-20210818]
[cannot apply to iommu/next lwn/docs-next v5.14-rc6]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Xie-Yongji/Introduce-VDUSE-vDPA-Device-in-Userspace/20210818-201209
base:   https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git linux-next
config: i386-allyesconfig (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
        # https://github.com/0day-ci/linux/commit/0b6102bc9db2d526393eaf9e5b8412940445a34b
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Xie-Yongji/Introduce-VDUSE-vDPA-Device-in-Userspace/20210818-201209
        git checkout 0b6102bc9db2d526393eaf9e5b8412940445a34b
        # save the attached .config to linux build tree
        make W=1 ARCH=i386 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

>> drivers/vdpa/vdpa_user/vduse_dev.c:698:21: error: initialization of 'u16 (*)(struct vdpa_device *)' {aka 'short unsigned int (*)(struct vdpa_device *)'} from incompatible pointer type 'u16 (*)(struct vdpa_device *, u16)' {aka 'short unsigned int (*)(struct vdpa_device *, short unsigned int)'} [-Werror=incompatible-pointer-types]
     698 |  .get_vq_num_max  = vduse_vdpa_get_vq_num_max,
         |                     ^~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/vdpa/vdpa_user/vduse_dev.c:698:21: note: (near initialization for 'vduse_vdpa_config_ops.get_vq_num_max')
   cc1: some warnings being treated as errors


vim +698 drivers/vdpa/vdpa_user/vduse_dev.c

   684	
   685	static const struct vdpa_config_ops vduse_vdpa_config_ops = {
   686		.set_vq_address		= vduse_vdpa_set_vq_address,
   687		.kick_vq		= vduse_vdpa_kick_vq,
   688		.set_vq_cb		= vduse_vdpa_set_vq_cb,
   689		.set_vq_num             = vduse_vdpa_set_vq_num,
   690		.set_vq_ready		= vduse_vdpa_set_vq_ready,
   691		.get_vq_ready		= vduse_vdpa_get_vq_ready,
   692		.set_vq_state		= vduse_vdpa_set_vq_state,
   693		.get_vq_state		= vduse_vdpa_get_vq_state,
   694		.get_vq_align		= vduse_vdpa_get_vq_align,
   695		.get_features		= vduse_vdpa_get_features,
   696		.set_features		= vduse_vdpa_set_features,
   697		.set_config_cb		= vduse_vdpa_set_config_cb,
 > 698		.get_vq_num_max		= vduse_vdpa_get_vq_num_max,
   699		.get_device_id		= vduse_vdpa_get_device_id,
   700		.get_vendor_id		= vduse_vdpa_get_vendor_id,
   701		.get_status		= vduse_vdpa_get_status,
   702		.set_status		= vduse_vdpa_set_status,
   703		.get_config_size	= vduse_vdpa_get_config_size,
   704		.get_config		= vduse_vdpa_get_config,
   705		.set_config		= vduse_vdpa_set_config,
   706		.get_generation		= vduse_vdpa_get_generation,
   707		.reset			= vduse_vdpa_reset,
   708		.set_map		= vduse_vdpa_set_map,
   709		.free			= vduse_vdpa_free,
   710	};
   711	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 65146 bytes --]