From: Jason Gunthorpe <jgg@nvidia.com>
To: Wenpeng Liang <liangwenpeng@huawei.com>
Cc: dledford@redhat.com, linux-rdma@vger.kernel.org,
linuxarm@huawei.com, leon@kernel.org,
Xi Wang <wangxi11@huawei.com>
Subject: Re: [PATCH v4 for-next 08/12] RDMA/hns: Add method to query WQE buffer's address
Date: Thu, 19 Aug 2021 20:58:08 -0300 [thread overview]
Message-ID: <20210819235808.GA399558@nvidia.com> (raw)
In-Reply-To: <1627525163-1683-9-git-send-email-liangwenpeng@huawei.com>
On Thu, Jul 29, 2021 at 10:19:19AM +0800, Wenpeng Liang wrote:
> DECLARE_UVERBS_NAMED_OBJECT(HNS_IB_OBJECT_DCA_MEM,
> UVERBS_TYPE_ALLOC_IDR(dca_cleanup),
> &UVERBS_METHOD(HNS_IB_METHOD_DCA_MEM_REG),
> &UVERBS_METHOD(HNS_IB_METHOD_DCA_MEM_DEREG),
> &UVERBS_METHOD(HNS_IB_METHOD_DCA_MEM_SHRINK),
> &UVERBS_METHOD(HNS_IB_METHOD_DCA_MEM_ATTACH),
> - &UVERBS_METHOD(HNS_IB_METHOD_DCA_MEM_DETACH));
> + &UVERBS_METHOD(HNS_IB_METHOD_DCA_MEM_DETACH),
> + &UVERBS_METHOD(HNS_IB_METHOD_DCA_MEM_QUERY));
These lists should be kept sorted in each patch
> +struct hns_dca_query_resp {
> + u64 mem_key;
> + u32 mem_ofs;
> + u32 page_count;
> +};
This is strange, why in a public header, why have the query_dca_mem
function at all? Just inline it and remove the struct entirely.
Jason
next prev parent reply other threads:[~2021-08-19 23:58 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-29 2:19 [PATCH v4 for-next 00/12] RDMA/hns: Add support for Dynamic Context Attachment Wenpeng Liang
2021-07-29 2:19 ` [PATCH v4 for-next 01/12] RDMA/hns: Introduce DCA for RC QP Wenpeng Liang
2021-08-19 23:54 ` Jason Gunthorpe
2021-08-21 9:37 ` Wenpeng Liang
2021-07-29 2:19 ` [PATCH v4 for-next 02/12] RDMA/hns: Add method for shrinking DCA memory pool Wenpeng Liang
2021-07-29 2:19 ` [PATCH v4 for-next 03/12] RDMA/hns: Configure DCA mode for the userspace QP Wenpeng Liang
2021-07-29 2:19 ` [PATCH v4 for-next 04/12] RDMA/hns: Refactor QP modify flow Wenpeng Liang
2021-07-29 2:19 ` [PATCH v4 for-next 05/12] RDMA/hns: Add method for attaching WQE buffer Wenpeng Liang
2021-07-29 2:19 ` [PATCH v4 for-next 06/12] RDMA/hns: Setup the configuration of WQE addressing to QPC Wenpeng Liang
2021-07-29 2:19 ` [PATCH v4 for-next 07/12] RDMA/hns: Add method to detach WQE buffer Wenpeng Liang
2021-07-29 2:19 ` [PATCH v4 for-next 08/12] RDMA/hns: Add method to query WQE buffer's address Wenpeng Liang
2021-08-19 23:58 ` Jason Gunthorpe [this message]
2021-08-21 9:39 ` Wenpeng Liang
2021-07-29 2:19 ` [PATCH v4 for-next 09/12] RDMA/hns: Add a shared memory to sync DCA status Wenpeng Liang
2021-08-19 23:43 ` Jason Gunthorpe
2021-08-21 9:42 ` Wenpeng Liang
2021-07-29 2:19 ` [PATCH v4 for-next 10/12] RDMA/hns: Sync DCA status by the shared memory Wenpeng Liang
2021-07-29 2:19 ` [PATCH v4 for-next 11/12] RDMA/nldev: Add detailed CTX information support Wenpeng Liang
2021-07-29 2:19 ` [PATCH v4 for-next 12/12] RDMA/hns: Dump detailed driver-specific UCTX Wenpeng Liang
2021-08-12 12:42 ` [PATCH v4 for-next 00/12] RDMA/hns: Add support for Dynamic Context Attachment Wenpeng Liang
2021-08-21 9:34 ` Wenpeng Liang
2021-08-22 22:25 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210819235808.GA399558@nvidia.com \
--to=jgg@nvidia.com \
--cc=dledford@redhat.com \
--cc=leon@kernel.org \
--cc=liangwenpeng@huawei.com \
--cc=linux-rdma@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=wangxi11@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.