From: Oleksandr Andrushchenko <andr2000@gmail.com>
To: andrew.cooper3@citrix.com, george.dunlap@citrix.com,
iwj@xenproject.org, jbeulich@suse.com, julien@xen.org,
sstabellini@kernel.org, wl@xen.org,
xen-devel@lists.xenproject.org
Cc: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
Subject: [PATCH] ns16550: Properly gate Exar PCIe UART cards support
Date: Fri, 20 Aug 2021 14:54:22 +0300 [thread overview]
Message-ID: <20210820115422.2185145-1-andr2000@gmail.com> (raw)
From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
This fixes Arm build which doesn't have ns16550 PCI support.
ns16550.c:313:5: error: implicit declaration of function 'enable_exar_enhanced_bits' [-Werror=implicit-function-declaration]
313 | enable_exar_enhanced_bits(uart);
| ^~~~~~~~~~~~~~~~~~~~~~~~~
Fixes: 5ffd37db2ff6 ("ns16550: add Exar PCIe UART cards support")
Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
---
xen/drivers/char/ns16550.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/xen/drivers/char/ns16550.c b/xen/drivers/char/ns16550.c
index b777c8711ee0..e2c24082c368 100644
--- a/xen/drivers/char/ns16550.c
+++ b/xen/drivers/char/ns16550.c
@@ -308,7 +308,7 @@ static void ns16550_setup_preirq(struct ns16550 *uart)
/* Handle the DesignWare 8250 'busy-detect' quirk. */
handle_dw_usr_busy_quirk(uart);
-#ifdef CONFIG_HAS_PCI
+#ifdef NS16550_PCI
/* Enable Exar "Enhanced function bits" */
enable_exar_enhanced_bits(uart);
#endif
--
2.25.1
next reply other threads:[~2021-08-20 11:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-20 11:54 Oleksandr Andrushchenko [this message]
2021-08-20 12:07 ` [PATCH] ns16550: Properly gate Exar PCIe UART cards support Jan Beulich
2021-08-20 12:18 ` Oleksandr Andrushchenko
2021-08-20 14:20 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210820115422.2185145-1-andr2000@gmail.com \
--to=andr2000@gmail.com \
--cc=andrew.cooper3@citrix.com \
--cc=george.dunlap@citrix.com \
--cc=iwj@xenproject.org \
--cc=jbeulich@suse.com \
--cc=julien@xen.org \
--cc=oleksandr_andrushchenko@epam.com \
--cc=sstabellini@kernel.org \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.