From: kernel test robot <lkp@intel.com>
To: kbuild@lists.01.org
Subject: drivers/gpu/drm/ingenic/ingenic-drm-drv.c:157 ingenic_drm_update_pixclk() warn: inconsistent returns '&priv->clk_mutex'.
Date: Fri, 20 Aug 2021 18:50:04 +0800 [thread overview]
Message-ID: <202108201800.suuIIj5p-lkp@intel.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 2376 bytes --]
CC: kbuild-all(a)lists.01.org
CC: linux-kernel(a)vger.kernel.org
TO: Paul Cercueil <paul@crapouillou.net>
CC: Sam Ravnborg <sam@ravnborg.org>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: d992fe5318d8d7af9510b879439a3c7f283da442
commit: 33700f6f7d9f6b4e1e6df933ef7fd388889c662c drm/ingenic: Reset pixclock rate when parent clock rate changes
date: 11 months ago
:::::: branch date: 12 hours ago
:::::: commit date: 11 months ago
config: arm64-randconfig-m031-20210820 (attached as .config)
compiler: aarch64-linux-gcc (GCC) 11.2.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
smatch warnings:
drivers/gpu/drm/ingenic/ingenic-drm-drv.c:157 ingenic_drm_update_pixclk() warn: inconsistent returns '&priv->clk_mutex'.
vim +157 drivers/gpu/drm/ingenic/ingenic-drm-drv.c
33700f6f7d9f6b Paul Cercueil 2020-09-26 142
33700f6f7d9f6b Paul Cercueil 2020-09-26 143 static int ingenic_drm_update_pixclk(struct notifier_block *nb,
33700f6f7d9f6b Paul Cercueil 2020-09-26 144 unsigned long action,
33700f6f7d9f6b Paul Cercueil 2020-09-26 145 void *data)
33700f6f7d9f6b Paul Cercueil 2020-09-26 146 {
33700f6f7d9f6b Paul Cercueil 2020-09-26 147 struct ingenic_drm *priv = drm_nb_get_priv(nb);
33700f6f7d9f6b Paul Cercueil 2020-09-26 148
33700f6f7d9f6b Paul Cercueil 2020-09-26 149 switch (action) {
33700f6f7d9f6b Paul Cercueil 2020-09-26 150 case PRE_RATE_CHANGE:
33700f6f7d9f6b Paul Cercueil 2020-09-26 151 mutex_lock(&priv->clk_mutex);
33700f6f7d9f6b Paul Cercueil 2020-09-26 152 priv->update_clk_rate = true;
33700f6f7d9f6b Paul Cercueil 2020-09-26 153 drm_crtc_wait_one_vblank(&priv->crtc);
33700f6f7d9f6b Paul Cercueil 2020-09-26 154 return NOTIFY_OK;
33700f6f7d9f6b Paul Cercueil 2020-09-26 155 default:
33700f6f7d9f6b Paul Cercueil 2020-09-26 156 mutex_unlock(&priv->clk_mutex);
33700f6f7d9f6b Paul Cercueil 2020-09-26 @157 return NOTIFY_OK;
33700f6f7d9f6b Paul Cercueil 2020-09-26 158 }
33700f6f7d9f6b Paul Cercueil 2020-09-26 159 }
33700f6f7d9f6b Paul Cercueil 2020-09-26 160
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 31396 bytes --]
next reply other threads:[~2021-08-20 10:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-20 10:50 kernel test robot [this message]
-- strict thread matches above, loose matches on Subject: below --
2021-09-12 16:53 drivers/gpu/drm/ingenic/ingenic-drm-drv.c:157 ingenic_drm_update_pixclk() warn: inconsistent returns '&priv->clk_mutex' kernel test robot
2021-02-27 11:46 kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202108201800.suuIIj5p-lkp@intel.com \
--to=lkp@intel.com \
--cc=kbuild@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.