All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Cc: Marek Belisko <marek.belisko@open-nandra.com>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/polkit: install polkit.loc to HOST_DIR
Date: Fri, 20 Aug 2021 23:04:05 +0200	[thread overview]
Message-ID: <20210820210405.GU27036@scaer> (raw)
In-Reply-To: <20210820201313.953976-1-fontaine.fabrice@gmail.com>

Fabrice, All,

On 2021-08-20 22:13 +0200, Fabrice Fontaine spake thusly:
> Fix added by commit c20d31baf471daeeec50d62cb8baa79bac06fa51 is
> incomplete as polkit.loc must also be added to
> $(HOST_DIR)/share/gettext/its
> 
> Fixes:
>  - http://autobuild.buildroot.org/results/170e4802b7b4e8e7dafa95ade549e8fd05e43bfd
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
>  package/polkit/polkit.mk | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/package/polkit/polkit.mk b/package/polkit/polkit.mk
> index 23adb534d0..0c12a88601 100644
> --- a/package/polkit/polkit.mk
> +++ b/package/polkit/polkit.mk
> @@ -41,11 +41,13 @@ else
>  POLKIT_CONF_OPTS += --with-authfw=shadow
>  endif
>  
> -# polkit.its is needed for gvfs and must be installed in $(HOST_DIR)
> +# polkit.{its,loc} are needed for gvfs and must be installed in $(HOST_DIR)
>  # and not $(STAGING_DIR)
>  define POLKIT_INSTALL_ITS
>  	$(INSTALL) -D -m 644 $(@D)/data/polkit.its \
>  		$(HOST_DIR)/share/gettext/its
> +	$(INSTALL) -D -m 644 $(@D)/data/polkit.loc \
> +		$(HOST_DIR)/share/gettext/its

The destination for "$(INSTALL) -D" must be a filename, not just the
directory, so I've fixed that for both the existing .its, and for the
.loc added by this patch.

Applied to master, thanks.

Regards,
Yann E. MORIN.

>  endef
>  POLKIT_POST_INSTALL_TARGET_HOOKS += POLKIT_INSTALL_ITS
>  
> -- 
> 2.32.0
> 
> _______________________________________________
> buildroot mailing list
> buildroot@busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

      reply	other threads:[~2021-08-20 21:04 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-20 20:13 [Buildroot] [PATCH 1/1] package/polkit: install polkit.loc to HOST_DIR Fabrice Fontaine
2021-08-20 21:04 ` Yann E. MORIN [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210820210405.GU27036@scaer \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@buildroot.org \
    --cc=fontaine.fabrice@gmail.com \
    --cc=marek.belisko@open-nandra.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.