Re: [PATCH 1/4] habanalabs: add "in device creation" status

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 2583 bytes --]

Hi Oded,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on char-misc/char-misc-testing]
[also build test WARNING on linux/master linus/master v5.14-rc6 next-20210820]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Oded-Gabbay/habanalabs-add-in-device-creation-status/20210820-230930
base:   https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git 1bd35e77ac2aadc1c22ca7335d4157eeae4a2fb8
config: sparc-randconfig-r014-20210816 (attached as .config)
compiler: sparc-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/c88e36085a6e21fde7e1ebcea36144a7d6df8d95
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Oded-Gabbay/habanalabs-add-in-device-creation-status/20210820-230930
        git checkout c88e36085a6e21fde7e1ebcea36144a7d6df8d95
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross ARCH=sparc 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

   drivers/misc/habanalabs/common/sysfs.c: In function 'status_show':
>> drivers/misc/habanalabs/common/sysfs.c:290:9: warning: 'strncpy' specified bound 32 equals destination size [-Wstringop-truncation]
     290 |         strncpy(str, hdev->status[hl_device_status(hdev)], HL_STR_MAX);
         |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~


vim +/strncpy +290 drivers/misc/habanalabs/common/sysfs.c

   283	
   284	static ssize_t status_show(struct device *dev, struct device_attribute *attr,
   285					char *buf)
   286	{
   287		struct hl_device *hdev = dev_get_drvdata(dev);
   288		char str[HL_STR_MAX];
   289	
 > 290		strncpy(str, hdev->status[hl_device_status(hdev)], HL_STR_MAX);
   291	
   292		/* use uppercase for backward compatibility */
   293		str[0] = 'A' + (str[0] - 'a');
   294	
   295		return sprintf(buf, "%s\n", str);
   296	}
   297	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 32998 bytes --]