Re: [PATCH V5 1/2] gpio: Add virtio-gpio driver

[Michael S. Tsirkin <mst@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 2253 bytes --]

On Wed, Aug 11, 2021 at 09:24:56AM +0530, Viresh Kumar wrote:
> On 11-08-21, 05:01, kernel test robot wrote:
> > Hi Viresh,
> > 
> > I love your patch! Yet something to improve:
> > 
> > [auto build test ERROR on soc/for-next]
> > [also build test ERROR on vhost/linux-next linus/master v5.14-rc5 next-20210810]
> > [If your patch is applied to the wrong git tree, kindly drop us a note.
> > And when submitting patch, we suggest to use '--base' as documented in
> > https://git-scm.com/docs/git-format-patch]
> > 
> > url:    https://github.com/0day-ci/linux/commits/Viresh-Kumar/gpio-Add-virtio-based-driver/20210810-182659
> > base:   https://git.kernel.org/pub/scm/linux/kernel/git/soc/soc.git for-next
> > config: riscv-randconfig-r042-20210810 (attached as .config)
> > compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 614c7d03877fd99c2de47429b15be3f00306a3bd)
> > reproduce (this is a W=1 build):
> >         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> >         chmod +x ~/bin/make.cross
> >         # https://github.com/0day-ci/linux/commit/4fe66a15717a74f8f876f70595f050b4dffda7ae
> >         git remote add linux-review https://github.com/0day-ci/linux
> >         git fetch --no-tags linux-review Viresh-Kumar/gpio-Add-virtio-based-driver/20210810-182659
> >         git checkout 4fe66a15717a74f8f876f70595f050b4dffda7ae
> >         # save the attached .config to linux build tree
> >         mkdir build_dir
> >         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross O=build_dir ARCH=riscv SHELL=/bin/bash drivers/gpio/
> > 
> > If you fix the issue, kindly add following tag as appropriate
> > Reported-by: kernel test robot <lkp@intel.com>
> > 
> > All errors (new ones prefixed by >>):
> > 
> > >> drivers/gpio/gpio-virtio.c:356:4: error: use of undeclared identifier 'VIRTIO_ID_GPIO'
> >            { VIRTIO_ID_GPIO, VIRTIO_DEV_ANY_ID },
> >              ^
> >    1 error generated.
> 
> I forgot to mention a dependency :(
> 
> https://lore.kernel.org/lkml/61b27e3bc61fb0c9f067001e95cfafc5d37d414a.1627362340.git.viresh.kumar(a)linaro.org/

Maybe just include it here for completeness.

> -- 
> viresh