From: Kalle Valo <kvalo@codeaurora.org>
To: Martin Fuzzey <martin.fuzzey@flowbird.group>
Cc: linux-wireless@vger.kernel.org,
Amitkumar Karwar <amitkarwar@gmail.com>,
Siva Rebbagondla <siva8118@gmail.com>,
Jakub Kicinski <kuba@kernel.org>,
Prameela Rani Garnepudi <prameela.j04cs@gmail.com>,
linux-kernel@vger.kernel.org,
Martin Fuzzey <martin.fuzzey@flowbird.group>
Subject: Re: [PATCH 1/3] rsi: fix occasional initialisation failure with BT coex
Date: Sat, 21 Aug 2021 17:26:17 +0000 (UTC) [thread overview]
Message-ID: <20210821172617.06659C43616@smtp.codeaurora.org> (raw)
In-Reply-To: <1628245403-2517-2-git-send-email-martin.fuzzey@flowbird.group>
Martin Fuzzey <martin.fuzzey@flowbird.group> wrote:
> When BT coexistence is enabled (eg oper mode 13, which is the default)
> the initialisation on startup sometimes silently fails.
>
> In a normal initialisation we see
> usb 1-1.3: Product: Wireless USB Network Module
> usb 1-1.3: Manufacturer: Redpine Signals, Inc.
> usb 1-1.3: SerialNumber: 000000000001
> rsi_91x: rsi_probe: Initialized os intf ops
> rsi_91x: rsi_load_9116_firmware: Loading chunk 0
> rsi_91x: rsi_load_9116_firmware: Loading chunk 1
> rsi_91x: rsi_load_9116_firmware: Loading chunk 2
> rsi_91x: Max Stations Allowed = 1
>
> But sometimes the last log is missing and the wlan net device is
> not created.
>
> Running a userspace loop that resets the hardware via a GPIO shows the
> problem occurring ~5/100 resets.
>
> The problem does not occur in oper mode 1 (wifi only).
>
> Adding logs shows that the initialisation state machine requests a MAC
> reset via rsi_send_reset_mac() but the firmware does not reply, leading
> to the initialisation sequence being incomplete.
>
> Fix this by delaying attaching the BT adapter until the wifi
> initialisation has completed.
>
> With this applied I have done > 300 reset loops with no errors.
>
> Fixes: 716b840c7641 ("rsi: handle BT traffic in driver")
> Signed-off-by: Martin Fuzzey <martin.fuzzey@flowbird.group>
> CC: stable@vger.kernel.org
Failed to apply, please rebase on top of wireless-drivers-next.
error: sha1 information is lacking or useless (drivers/net/wireless/rsi/rsi_91x_mgmt.c).
error: could not build fake ancestor
hint: Use 'git am --show-current-patch' to see the failed patch
Applying: rsi: fix occasional initialisation failure with BT coex
Patch failed at 0001 rsi: fix occasional initialisation failure with BT coex
3 patches set to Changes Requested.
12423167 [1/3] rsi: fix occasional initialisation failure with BT coex
12423171 [2/3] rsi: fix key enabled check causing unwanted encryption for vap_id > 0
12423173 [3/3] rsi: fix rate mask set leading to P2P failure
--
https://patchwork.kernel.org/project/linux-wireless/patch/1628245403-2517-2-git-send-email-martin.fuzzey@flowbird.group/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2021-08-21 17:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-06 10:23 [PATCH 0/3] rsi: fix startup and P2P mode Martin Fuzzey
2021-08-06 10:23 ` [PATCH 1/3] rsi: fix occasional initialisation failure with BT coex Martin Fuzzey
2021-08-21 17:26 ` Kalle Valo [this message]
2021-08-06 10:23 ` [PATCH 2/3] rsi: fix key enabled check causing unwanted encryption for vap_id > 0 Martin Fuzzey
2021-08-06 10:23 ` [PATCH 3/3] rsi: fix rate mask set leading to P2P failure Martin Fuzzey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210821172617.06659C43616@smtp.codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=amitkarwar@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=martin.fuzzey@flowbird.group \
--cc=prameela.j04cs@gmail.com \
--cc=siva8118@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.