From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D1759C4338F for ; Mon, 23 Aug 2021 08:18:55 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4F6ED61214 for ; Mon, 23 Aug 2021 08:18:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 4F6ED61214 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=QBXxuTmqQvKIjSRasdTKCMgmHLYVtktsTw/f1HsvRgw=; b=PKnFY/T+29QBL5 7Gds1ck3BCCgpc9HVfwzUgZ2ekuHocEgqANErbMgnVUnUTZRt83/LZYxbSmLXC7z53r0M8N9ghyGa a+fgIt2rxTXJHrOMxUixv4NYIaB3uNC6CrNJjnq6hZygJNMFwKGDpEWhBfCocdpPQS1fIceUYjyTt 5GSg4iNJ9BHZCf/7EF4hSbd1/yhlTRuUxgbZ4Zva06cXrYYkU2hr+oAeyFoWJxa4jqZWsioFeOpei dmbTGzx2GCl3W9IGDIHZdK7o9GptfejdQtlA2ezYyKTmdnD8dHAPUgT6gIVeTV0cofdMnS0fZB7A5 QrPZTRHqOgqavkNZImbA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mI59r-00FtJn-DA; Mon, 23 Aug 2021 08:18:15 +0000 Received: from relay8-d.mail.gandi.net ([217.70.183.201]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mI59l-00FtIW-Lz for linux-mtd@lists.infradead.org; Mon, 23 Aug 2021 08:18:14 +0000 Received: (Authenticated sender: miquel.raynal@bootlin.com) by relay8-d.mail.gandi.net (Postfix) with ESMTPSA id 24E091BF206; Mon, 23 Aug 2021 08:18:04 +0000 (UTC) Date: Mon, 23 Aug 2021 10:18:02 +0200 From: Miquel Raynal To: Sean Nyekjaer Cc: s.hauer@pengutronix.de, richard@nod.at, linux-pm@vger.kernel.org, han.xu@nxp.com, linux-mtd@lists.infradead.org Subject: Re: [BUG RESEND] unsuspend failure under load Message-ID: <20210823101802.27823313@xps13> In-Reply-To: <20210706093541.f4kjxqrkft7fqbcx@skn-laptop> References: <20210705065833.2ezlhaspkkju4bh7@skn-laptop> <20210706093541.f4kjxqrkft7fqbcx@skn-laptop> Organization: Bootlin X-Mailer: Claws Mail 3.17.7 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210823_011810_042106_D34BF248 X-CRM114-Status: GOOD ( 38.28 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org SGVsbG8sCgpJIHRoaW5rIHdlIHNob3VsZCBpbnZvbHZlIFJpY2hhcmQgYXMgd2VsbCBpbiB0aGUg ZGlzY3Vzc2lvbi4KClNlYW4gTnlla2phZXIgPHNlYW5AZ2Vhbml4LmNvbT4gd3JvdGUgb24gVHVl LCA2IEp1bCAyMDIxIDExOjM1OjQxICswMjAwOgoKPiBPbiBNb24sIEp1bCAwNSwgMjAyMSBhdCAw ODo1ODozOEFNICswMjAwLCBTZWFuIE55ZWtqYWVyIHdyb3RlOgo+ID4gSGkgTWlxdWVsIGFuZCBT YXNjaGEsICAKPiArIFJpY2hhcmQgKyBsaW51eC1wbQo+ID4gCj4gPiBXZSBhcmUgaGF2aW5nIHNv bWUgdHJvdWJsZSB3aGVuIG91ciBpLk1YNiB1bnN1c3BlbmRzIHdoaWxlIHdyaXRlcyB0bwo+ID4g dWJpZnMgaXMgaW4gcHJvZ2Vzcy4gSW4gdGhlIGxvZyBpdCBsb29rcyBsaWtlIGl0IHN5bmNpbmcg dGhlIGZpbGVzeXN0ZW0KPiA+IGJlZm9yZSBzdXNwZW5kLgo+ID4gCj4gPiBUaGUgU29DIGEgaS5N WDZ1bC91bGwsIHRoZSBpc3N1ZSBpcyAobHVja3kgZm9yIHVzKSBxdWl0ZSBlYXN5IHRvIHJlcHJv ZHVjZS4KPiA+IFRoZSByZXByb2R1Y2Ugc2NyaXB0OiBbMF0KPiA+IEtlcm5lbCBsb2cgd2hlbiBp dCBoYXBwZW5zOiBbMV0KPiA+IAo+ID4gSSBoYXZlIGJpc2VjdGVkIHRoZSBidWcgdG86IGVmMzQ3 YzBjZmQ2MSAoIm10ZDogcmF3bmFuZDogZ3BtaTogSW1wbGVtZW50IGV4ZWNfb3AiKQo+ID4gCj4g PiBBbnkgaWRlYSB0byB3aGVyZSBJIHNob3VsZCBzdGFydCBsb29raW5nPyBvciB0byB3aGF0IGhh cHBlbnM/Cj4gPiAKPiA+IEVzYmVuIGhhdmUgcG9zdGVkIHRvIHBhdGNoZXMgdGhhdCByZWxhdGVz IHRvIHN1c3BlbmQvdW5zdXNwZW5kIGJ1dCBpdAo+ID4gZG9lc24ndCBzZWVtIHRvIHJlbGVhdGVk IHRvIHRoaXMgaXNzdWUuCj4gPiA1YmM2YmI2MDNiNGQgKCJtdGQ6IHJhd25hbmQ6IGdwbWk6IEZp eCBzdXNwZW5kL3Jlc3VtZSBwcm9ibGVtIikKPiA+IGQ3MDQ4NjY2OGNkZiAoIm10ZDogcmF3bmFu ZDogZ3BtaTogUmVzdG9yZSBuZmMgdGltaW5nIHNldHVwIGFmdGVyIHN1c3BlbmQvcmVzdW1lIikK PiA+IAo+ID4gL1NlYW4gIAo+IAo+IG5hbmRfcmVzdW1lKCkgaXMgY2FsbGVkIHNvbWUgdGltZSBh ZnRlciB1YmlfaW9fd3JpdGUgdHJpZXMgdG8gd3JpdGUuIFRoYXRzIHdoeQo+IG10ZF93cml0ZSgp IGlzIHJldHVybmluZyAtRUJVU1kuCgpKdXN0IHRvIGJlIHN1cmU6Ci0gcGxhdGZvcm0gcmVzdW1l cwotIHlvdXIgYXBwIHN0YXJ0ZWQgYSB3cml0ZSBiZWZvcmUgYmVpbmcgc3VzcGVuZGVkCi0gdGhl IHdyaXRlIGdldHMgcmVmdXNlZCBiZWNhdXNlIHRoZSBzdXNwZW5kZWQgc3RhdGUgaGFzIG5vdCBi ZWVuCiAgY2xlYXJlZCB5ZXQKQW0gSSB1bmRlcnN0YW5kaW5nIHRoaXMgaXNzdWUgY29ycmVjdGx5 PwoKQnV0IEkgd291bGQgZXhwZWN0ICJGaWxlc3lzdGVtcyBzeW5jIiB0byBhY3R1YWxseSBsZXQg dGhlIGxvd2VyIGxheWVycwp0aGUgdGltZSB0byBmbHVzaCB0aGUgZGF0YSB0byB0aGUgc3RvcmFn ZSBkZXZpY2VzLCBzdXNwZW5kaW5nIHdpdGhvdXQKd2FpdGluZyBmb3IgdGhpcyB0byBoYXBwZW4g bG9va3Mgc3RyYW5nZSB0byBtZS4KClNhc2NoYSwgUmljaGFyZCwgd2hhdCdzIHlvdXIgaW5wdXQ/ Cgo+IEkgaGF2ZSB0cmllZCBwYXRjaCBbM10sIGFuZCBpdCBzZWVtcyB0byBmaXggaXQuCj4gSSB0 aGluayBpdCB3b3VsZCBiZSBva2F5IHRvIGFkZCB0aGUgcmV0cnkgb3B0aW9uLCBidXQgdGhlIG1k ZWxheSBpcyBub3QKPiBvYnZpb3VzbHkgYSBub2dvLgo+IAo+IEFueSBpZGVhIHRvIGhvdyB3ZSBj b3VsZCB3YWl0IGhlcmUgZm9yIHRoZSBuYW5kX3Jlc3VtZSgpIHRvIGJlIGNhbGxlZD8KPiAKPiBA bGludXgtcG06Cj4gSSBoYXZlIG5vdGljZWQgIkZpbHN5c3RlbXMgc3luYyIgaGFwcGVucyBiZWZv cmUgIkZyZWV6aW5nIHVzZXIgc3BhY2UKPiBwcm9jZXNzZXMiLgo+IElmIEkgYXBwbHkgcGF0Y2gg WzRdICh3aXRob3V0IFszXSksIGl0IHdvdWxkIGFsc28gZml4IG91ciBpc3N1ZS4gQnV0IEkKPiBk b24ndCBoYXZlIGVuIGluc2lnaHQgaW4gdG8gd2hhdCBpbXBhY3QgdGhlIGNoYW5nZSBtaWdodCBo YXZlLgo+IAo+IC9TZWFuCj4gCj4gPiAKPiA+IFswXQo+ID4gIyEvYmluL3NoCj4gPiBkZCBpZj0v ZGV2L3VyYW5kb20gb2Y9L3RtcC90ZXN0NTBNIGJzPTFNIGNvdW50PTUwCj4gPiBjcCAvdG1wL3Rl c3Q1ME0gL2RhdGEvICYKPiA+IGVjaG8gbWVtID4gL3N5cy9wb3dlci9zdGF0ZQo+ID4gCj4gPiBb MV0KPiA+IHJvb3RAaXdnMjYtdjI6L2RhdGEvcm9vdCMgLi91YmljcmFzaC5zaAo+ID4gNTArMCBy ZWNvcmRzIGluCj4gPiA1MCswIHJlY29yZHMgb3V0Cj4gPiBQTTogc3VzcGVuZCBlbnRyeSAoZGVl cCkKPiA+IEZpbGVzeXN0ZW1zIHN5bmM6IDMzLjY0MiBzZWNvbmRzCj4gPiBGcmVlemluZyB1c2Vy IHNwYWNlIHByb2Nlc3NlcyAuLi4gKGVsYXBzZWQgMC4wMDQgc2Vjb25kcykgZG9uZS4KPiA+IE9P TSBraWxsZXIgZGlzYWJsZWQuCj4gPiBGcmVlemluZyByZW1haW5pbmcgZnJlZXphYmxlIHRhc2tz IC4uLiAoZWxhcHNlZCAwLjAwMyBzZWNvbmRzKSBkb25lLgo+ID4gcHJpbnRrOiBTdXNwZW5kaW5n IGNvbnNvbGUocykgKHVzZSBub19jb25zb2xlX3N1c3BlbmQgdG8gZGVidWcpCj4gPiA8U1VTUEVO RC9XQUtFPgo+ID4gUE06IHN1c3BlbmQgZGV2aWNlcyB0b29rIDAuMDQwIHNlY29uZHMKPiA+IERp c2FibGluZyBub24tYm9vdCBDUFVzIC4uLgo+ID4gdWJpMCBlcnJvcjogdWJpX2lvX3dyaXRlOiBl cnJvciAtMTYgd2hpbGUgd3JpdGluZyA0MDk2IGJ5dGVzIHRvIFBFQiA1NDQ6NTMyNDgsIHdyaXR0 ZW4gMCBieXRlcwo+ID4gQ1BVOiAwIFBJRDogNjkgQ29tbToga3dvcmtlci91MjoyIE5vdCB0YWlu dGVkIDUuMTMuMCAjMwo+ID4gSGFyZHdhcmUgbmFtZTogRnJlZXNjYWxlIGkuTVg2IFVsdHJhbGl0 ZSAoRGV2aWNlIFRyZWUpCj4gPiBXb3JrcXVldWU6IHdyaXRlYmFjayB3Yl93b3JrZm4gKGZsdXNo LXViaWZzXzBfOCkKPiA+IFs8YzAxMGQ5YjA+XSAodW53aW5kX2JhY2t0cmFjZSkgZnJvbSBbPGMw MTBhMjhjPl0gKHNob3dfc3RhY2srMHgxMC8weDE0KQo+ID4gWzxjMDEwYTI4Yz5dIChzaG93X3N0 YWNrKSBmcm9tIFs8YzA5NzA3OTg+XSAoZHVtcF9zdGFjaysweGMwLzB4ZGMpCj4gPiBbPGMwOTcw Nzk4Pl0gKGR1bXBfc3RhY2spIGZyb20gWzxjMDVkZmUxMD5dICh1YmlfaW9fd3JpdGUrMHg1MTAv MHg2YjApCj4gPiBbPGMwNWRmZTEwPl0gKHViaV9pb193cml0ZSkgZnJvbSBbPGMwNWRjZDkwPl0g KHViaV9lYmFfd3JpdGVfbGViKzB4Mzg4LzB4OTEwKQo+ID4gWzxjMDVkY2Q5MD5dICh1YmlfZWJh X3dyaXRlX2xlYikgZnJvbSBbPGMwNWRhZjM0Pl0gKHViaV9sZWJfd3JpdGUrMHhkMC8weGU4KQo+ ID4gWzxjMDVkYWYzND5dICh1YmlfbGViX3dyaXRlKSBmcm9tIFs8YzAzY2ZlYjQ+XSAodWJpZnNf bGViX3dyaXRlKzB4NjgvMHgxMDQpICAKPiAKPiBbIC4uLiBdCj4gCj4gPiBVQklGUyBlcnJvciAo dWJpMDo4IHBpZCAxNTcpOiBtYWtlX3Jlc2VydmF0aW9uOiBjYW5ub3QgcmVzZXJ2ZSA0MTQ0IGJ5 dGVzIGluIGpoZWFkIDIsIGVycm9yIC0zMAo+ID4gVUJJRlMgZXJyb3IgKHViaTA6OCBwaWQgMTU3 KTogZG9fd3JpdGVwYWdlOiBjYW5ub3Qgd3JpdGUgcGFnZSAxMDk2MiBvZiBpbm9kZSA4MjEsIGVy cm9yIC0zMAo+ID4gVUJJRlMgZXJyb3IgKHViaTA6OCBwaWQgMTU3KTogbWFrZV9yZXNlcnZhdGlv bjogY2Fubm90IHJlc2VydmUgNDE0NCBieXRlcyBpbiBqaGVhZCAyLCBlcnJvciAtMzAKPiA+IFVC SUZTIGVycm9yICh1YmkwOjggcGlkIDE1Nyk6IGRvX3dyaXRlcGFnZTogY2Fubm90IHdyaXRlIHBh Z2UgMTA5NjMgb2YgaW5vZGUgODIxLCBlcnJvciAtMzAKPiA+IFVCSUZTIGVycm9yICh1YmkwOjgg cGlkIDE1Nyk6IG1ha2VfcmVzZXJ2YXRpb246IGNhbm5vdCByZXNlcnZlIDY5NiBieXRlcyBpbiBq aGVhZCAyLCBlcnJvciAtMzAKPiA+IFVCSUZTIGVycm9yICh1YmkwOjggcGlkIDE1Nyk6IGRvX3dy aXRlcGFnZTogY2Fubm90IHdyaXRlIHBhZ2UgMCBvZiBpbm9kZSA4MTksIGVycm9yIC0zMAo+ID4g VUJJRlMgZXJyb3IgKHViaTA6OCBwaWQgMTU3KTogbWFrZV9yZXNlcnZhdGlvbjogY2Fubm90IHJl c2VydmUgNDE0NCBieXRlcyBpbiBqaGVhZCAyLCBlcnJvciAtMzAgIAo+IAo+IFszXToKPiBkaWZm IC0tZ2l0IGEvZHJpdmVycy9tdGQvdWJpL2lvLmMgYi9kcml2ZXJzL210ZC91YmkvaW8uYwo+IGlu ZGV4IDE0ZDg5MGIwMGQyYy4uYjI0YzU3MWZhMDIyIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvbXRk L3ViaS9pby5jCj4gKysrIGIvZHJpdmVycy9tdGQvdWJpL2lvLmMKPiBAQCAtMjY4LDggKzI2OSwx OCBAQCBpbnQgdWJpX2lvX3dyaXRlKHN0cnVjdCB1YmlfZGV2aWNlICp1YmksIGNvbnN0IHZvaWQg KmJ1ZiwgaW50IHBudW0sIGludCBvZmZzZXQsCj4gIAl9Cj4gCj4gIAlhZGRyID0gKGxvZmZfdClw bnVtICogdWJpLT5wZWJfc2l6ZSArIG9mZnNldDsKPiArcmV0cnk6Cj4gIAllcnIgPSBtdGRfd3Jp dGUodWJpLT5tdGQsIGFkZHIsIGxlbiwgJndyaXR0ZW4sIGJ1Zik7Cj4gIAlpZiAoZXJyKSB7Cj4g KwkJaWYgKHJldHJpZXMrKyA8IFVCSV9JT19SRVRSSUVTKSB7Cj4gKwkJCXViaV93YXJuKHViaSwg ImVycm9yICVkIHdoaWxlIHdyaXRpbmcgJWQgYnl0ZXMgdG8gUEVCICVkOiVkLCB3cml0dGVuICV6 ZCBieXRlcyIsCj4gKwkJCQkgZXJyLCBsZW4sIHBudW0sIG9mZnNldCwgd3JpdHRlbik7Cj4gKwkJ CW1kZWxheSgyNSk7IHlpZWxkKCk7Cj4gKwkJCWdvdG8gcmV0cnk7Cj4gKwkJfQo+ICsKPiAgCQl1 YmlfZXJyKHViaSwgImVycm9yICVkIHdoaWxlIHdyaXRpbmcgJWQgYnl0ZXMgdG8gUEVCICVkOiVk LCB3cml0dGVuICV6ZCBieXRlcyIsCj4gIAkJCWVyciwgbGVuLCBwbnVtLCBvZmZzZXQsIHdyaXR0 ZW4pOwo+ICAJCWR1bXBfc3RhY2soKTsKPiAKPiBbNF06Cj4gZGlmZiAtLWdpdCBhL2tlcm5lbC9w b3dlci9zdXNwZW5kLmMgYi9rZXJuZWwvcG93ZXIvc3VzcGVuZC5jCj4gaW5kZXggMzIzOTFhY2M4 MDZiLi42MWEyMTNhZDVhMTMgMTAwNjQ0Cj4gLS0tIGEva2VybmVsL3Bvd2VyL3N1c3BlbmQuYwo+ ICsrKyBiL2tlcm5lbC9wb3dlci9zdXNwZW5kLmMKPiBAQCAtNTYzLDE4ICs1NjMsMTggQEAgc3Rh dGljIGludCBlbnRlcl9zdGF0ZShzdXNwZW5kX3N0YXRlX3Qgc3RhdGUpCj4gIAlpZiAoc3RhdGUg PT0gUE1fU1VTUEVORF9UT19JRExFKQo+ICAJCXMyaWRsZV9iZWdpbigpOwo+ICAKPiAtCWlmIChz eW5jX29uX3N1c3BlbmRfZW5hYmxlZCkgewo+IC0JCXRyYWNlX3N1c3BlbmRfcmVzdW1lKFRQUygi c3luY19maWxlc3lzdGVtcyIpLCAwLCB0cnVlKTsKPiAtCQlrc3lzX3N5bmNfaGVscGVyKCk7Cj4g LQkJdHJhY2Vfc3VzcGVuZF9yZXN1bWUoVFBTKCJzeW5jX2ZpbGVzeXN0ZW1zIiksIDAsIGZhbHNl KTsKPiAtCX0KPiAtCj4gIAlwbV9wcl9kYmcoIlByZXBhcmluZyBzeXN0ZW0gZm9yIHNsZWVwICgl cylcbiIsIG1lbV9zbGVlcF9sYWJlbHNbc3RhdGVdKTsKPiAgCXBtX3N1c3BlbmRfY2xlYXJfZmxh Z3MoKTsKPiAgCWVycm9yID0gc3VzcGVuZF9wcmVwYXJlKHN0YXRlKTsKPiAgCWlmIChlcnJvcikK PiAgCQlnb3RvIFVubG9jazsKPiAgCj4gKwlpZiAoc3luY19vbl9zdXNwZW5kX2VuYWJsZWQpIHsK PiArCQl0cmFjZV9zdXNwZW5kX3Jlc3VtZShUUFMoInN5bmNfZmlsZXN5c3RlbXMiKSwgMCwgdHJ1 ZSk7Cj4gKwkJa3N5c19zeW5jX2hlbHBlcigpOwo+ICsJCXRyYWNlX3N1c3BlbmRfcmVzdW1lKFRQ Uygic3luY19maWxlc3lzdGVtcyIpLCAwLCBmYWxzZSk7Cj4gKwl9Cj4gKwo+ICAJaWYgKHN1c3Bl bmRfdGVzdChURVNUX0ZSRUVaRVIpKQo+ICAJCWdvdG8gRmluaXNoOwo+ICAKClRoYW5rcywKTWlx dcOobAoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fCkxpbnV4IE1URCBkaXNjdXNzaW9uIG1haWxpbmcgbGlzdApodHRwOi8vbGlzdHMuaW5mcmFk ZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LW10ZC8K From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 26A16C4338F for ; Mon, 23 Aug 2021 08:18:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 033A96136A for ; Mon, 23 Aug 2021 08:18:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235442AbhHWISu convert rfc822-to-8bit (ORCPT ); Mon, 23 Aug 2021 04:18:50 -0400 Received: from relay8-d.mail.gandi.net ([217.70.183.201]:39113 "EHLO relay8-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235436AbhHWISt (ORCPT ); Mon, 23 Aug 2021 04:18:49 -0400 Received: (Authenticated sender: miquel.raynal@bootlin.com) by relay8-d.mail.gandi.net (Postfix) with ESMTPSA id 24E091BF206; Mon, 23 Aug 2021 08:18:04 +0000 (UTC) Date: Mon, 23 Aug 2021 10:18:02 +0200 From: Miquel Raynal To: Sean Nyekjaer Cc: s.hauer@pengutronix.de, richard@nod.at, linux-pm@vger.kernel.org, han.xu@nxp.com, linux-mtd@lists.infradead.org Subject: Re: [BUG RESEND] unsuspend failure under load Message-ID: <20210823101802.27823313@xps13> In-Reply-To: <20210706093541.f4kjxqrkft7fqbcx@skn-laptop> References: <20210705065833.2ezlhaspkkju4bh7@skn-laptop> <20210706093541.f4kjxqrkft7fqbcx@skn-laptop> Organization: Bootlin X-Mailer: Claws Mail 3.17.7 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org Hello, I think we should involve Richard as well in the discussion. Sean Nyekjaer wrote on Tue, 6 Jul 2021 11:35:41 +0200: > On Mon, Jul 05, 2021 at 08:58:38AM +0200, Sean Nyekjaer wrote: > > Hi Miquel and Sascha, > + Richard + linux-pm > > > > We are having some trouble when our i.MX6 unsuspends while writes to > > ubifs is in progess. In the log it looks like it syncing the filesystem > > before suspend. > > > > The SoC a i.MX6ul/ull, the issue is (lucky for us) quite easy to reproduce. > > The reproduce script: [0] > > Kernel log when it happens: [1] > > > > I have bisected the bug to: ef347c0cfd61 ("mtd: rawnand: gpmi: Implement exec_op") > > > > Any idea to where I should start looking? or to what happens? > > > > Esben have posted to patches that relates to suspend/unsuspend but it > > doesn't seem to releated to this issue. > > 5bc6bb603b4d ("mtd: rawnand: gpmi: Fix suspend/resume problem") > > d70486668cdf ("mtd: rawnand: gpmi: Restore nfc timing setup after suspend/resume") > > > > /Sean > > nand_resume() is called some time after ubi_io_write tries to write. Thats why > mtd_write() is returning -EBUSY. Just to be sure: - platform resumes - your app started a write before being suspended - the write gets refused because the suspended state has not been cleared yet Am I understanding this issue correctly? But I would expect "Filesystems sync" to actually let the lower layers the time to flush the data to the storage devices, suspending without waiting for this to happen looks strange to me. Sascha, Richard, what's your input? > I have tried patch [3], and it seems to fix it. > I think it would be okay to add the retry option, but the mdelay is not > obviously a nogo. > > Any idea to how we could wait here for the nand_resume() to be called? > > @linux-pm: > I have noticed "Filsystems sync" happens before "Freezing user space > processes". > If I apply patch [4] (without [3]), it would also fix our issue. But I > don't have en insight in to what impact the change might have. > > /Sean > > > > > [0] > > #!/bin/sh > > dd if=/dev/urandom of=/tmp/test50M bs=1M count=50 > > cp /tmp/test50M /data/ & > > echo mem > /sys/power/state > > > > [1] > > root@iwg26-v2:/data/root# ./ubicrash.sh > > 50+0 records in > > 50+0 records out > > PM: suspend entry (deep) > > Filesystems sync: 33.642 seconds > > Freezing user space processes ... (elapsed 0.004 seconds) done. > > OOM killer disabled. > > Freezing remaining freezable tasks ... (elapsed 0.003 seconds) done. > > printk: Suspending console(s) (use no_console_suspend to debug) > > > > PM: suspend devices took 0.040 seconds > > Disabling non-boot CPUs ... > > ubi0 error: ubi_io_write: error -16 while writing 4096 bytes to PEB 544:53248, written 0 bytes > > CPU: 0 PID: 69 Comm: kworker/u2:2 Not tainted 5.13.0 #3 > > Hardware name: Freescale i.MX6 Ultralite (Device Tree) > > Workqueue: writeback wb_workfn (flush-ubifs_0_8) > > [] (unwind_backtrace) from [] (show_stack+0x10/0x14) > > [] (show_stack) from [] (dump_stack+0xc0/0xdc) > > [] (dump_stack) from [] (ubi_io_write+0x510/0x6b0) > > [] (ubi_io_write) from [] (ubi_eba_write_leb+0x388/0x910) > > [] (ubi_eba_write_leb) from [] (ubi_leb_write+0xd0/0xe8) > > [] (ubi_leb_write) from [] (ubifs_leb_write+0x68/0x104) > > [ ... ] > > > UBIFS error (ubi0:8 pid 157): make_reservation: cannot reserve 4144 bytes in jhead 2, error -30 > > UBIFS error (ubi0:8 pid 157): do_writepage: cannot write page 10962 of inode 821, error -30 > > UBIFS error (ubi0:8 pid 157): make_reservation: cannot reserve 4144 bytes in jhead 2, error -30 > > UBIFS error (ubi0:8 pid 157): do_writepage: cannot write page 10963 of inode 821, error -30 > > UBIFS error (ubi0:8 pid 157): make_reservation: cannot reserve 696 bytes in jhead 2, error -30 > > UBIFS error (ubi0:8 pid 157): do_writepage: cannot write page 0 of inode 819, error -30 > > UBIFS error (ubi0:8 pid 157): make_reservation: cannot reserve 4144 bytes in jhead 2, error -30 > > [3]: > diff --git a/drivers/mtd/ubi/io.c b/drivers/mtd/ubi/io.c > index 14d890b00d2c..b24c571fa022 100644 > --- a/drivers/mtd/ubi/io.c > +++ b/drivers/mtd/ubi/io.c > @@ -268,8 +269,18 @@ int ubi_io_write(struct ubi_device *ubi, const void *buf, int pnum, int offset, > } > > addr = (loff_t)pnum * ubi->peb_size + offset; > +retry: > err = mtd_write(ubi->mtd, addr, len, &written, buf); > if (err) { > + if (retries++ < UBI_IO_RETRIES) { > + ubi_warn(ubi, "error %d while writing %d bytes to PEB %d:%d, written %zd bytes", > + err, len, pnum, offset, written); > + mdelay(25); yield(); > + goto retry; > + } > + > ubi_err(ubi, "error %d while writing %d bytes to PEB %d:%d, written %zd bytes", > err, len, pnum, offset, written); > dump_stack(); > > [4]: > diff --git a/kernel/power/suspend.c b/kernel/power/suspend.c > index 32391acc806b..61a213ad5a13 100644 > --- a/kernel/power/suspend.c > +++ b/kernel/power/suspend.c > @@ -563,18 +563,18 @@ static int enter_state(suspend_state_t state) > if (state == PM_SUSPEND_TO_IDLE) > s2idle_begin(); > > - if (sync_on_suspend_enabled) { > - trace_suspend_resume(TPS("sync_filesystems"), 0, true); > - ksys_sync_helper(); > - trace_suspend_resume(TPS("sync_filesystems"), 0, false); > - } > - > pm_pr_dbg("Preparing system for sleep (%s)\n", mem_sleep_labels[state]); > pm_suspend_clear_flags(); > error = suspend_prepare(state); > if (error) > goto Unlock; > > + if (sync_on_suspend_enabled) { > + trace_suspend_resume(TPS("sync_filesystems"), 0, true); > + ksys_sync_helper(); > + trace_suspend_resume(TPS("sync_filesystems"), 0, false); > + } > + > if (suspend_test(TEST_FREEZER)) > goto Finish; > Thanks, Miquèl