All of lore.kernel.org
 help / color / mirror / Atom feed
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Marion et Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
	linux-mtd@lists.infradead.org
Subject: Re: [PATCH] mtd: rawnand: cafe: Fix a resource leak in the error handling path of 'cafe_nand_probe()'
Date: Mon, 23 Aug 2021 10:59:04 +0200	[thread overview]
Message-ID: <20210823105904.3d01c688@xps13> (raw)
In-Reply-To: <332872880.718.1629708519896.JavaMail.www@wwinf1d09>

Hi Christophe,

+ML

Marion et Christophe JAILLET <christophe.jaillet@wanadoo.fr> wrote on
Mon, 23 Aug 2021 10:48:39 +0200 (CEST):

> Hi,
> 
> just noticed a typo in my patch : s/our/out/ in the label 
> 
> Can you fix it before it leaves your tree?

Yep, done!

> 
> CJ
> 
>  
> 
>  
> 
> > Message du 23/08/21 10:35
> > De : "Miquel Raynal" 
> > A : "Christophe JAILLET" , miquel.raynal@bootlin.com, richard@nod.at, vigneshr@ti.com, boris.brezillon@collabora.com, lee.jones@linaro.org, segher@kernel.crashing.org, dwmw2@infradead.org
> > Copie à : linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
> > Objet : Re: [PATCH] mtd: rawnand: cafe: Fix a resource leak in the error handling path of 'cafe_nand_probe()'
> > 
> > On Sat, 2021-08-21 at 07:58:45 UTC, Christophe JAILLET wrote:  
> > > A successful 'init_rs_non_canonical()' call should be balanced by a
> > > corresponding 'free_rs()' call in the error handling path of the probe, as
> > > already done in the remove function.
> > > 
> > > Update the error handling path accordingly.
> > > 
> > > Fixes: 8c61b7a7f4d4 ("[MTD] [NAND] Use rslib for CAFÉ ECC")
> > > Signed-off-by: Christophe JAILLET   
> > 
> > Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git nand/next, thanks.
> > 
> > Miquel
> >  

Thanks,
Miquèl

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

      parent reply	other threads:[~2021-08-23  9:00 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-21  7:58 [PATCH] mtd: rawnand: cafe: Fix a resource leak in the error handling path of 'cafe_nand_probe()' Christophe JAILLET
2021-08-21  7:58 ` Christophe JAILLET
2021-08-23  8:35 ` Miquel Raynal
2021-08-23  8:35   ` Miquel Raynal
     [not found]   ` <332872880.718.1629708519896.JavaMail.www@wwinf1d09>
2021-08-23  8:59     ` Miquel Raynal [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210823105904.3d01c688@xps13 \
    --to=miquel.raynal@bootlin.com \
    --cc=christophe.jaillet@wanadoo.fr \
    --cc=linux-mtd@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.