From: Andre Przywara <andre.przywara@arm.com>
To: Michal Simek <michal.simek@xilinx.com>
Cc: u-boot@lists.denx.de, git@xilinx.com,
"Bin Meng" <bmeng.cn@gmail.com>,
"Chee Hong Ang" <chee.hong.ang@intel.com>,
"Marek Behún" <marek.behun@nic.cz>,
"Pali Rohár" <pali@kernel.org>, "Simon Glass" <sjg@chromium.org>
Subject: Re: [PATCH 07/10] Makefile: Align fit-dtb.blob and u-boot.itb by 64bits
Date: Mon, 23 Aug 2021 12:19:48 +0100 [thread overview]
Message-ID: <20210823121948.1530e6e8@slackpad.fritz.box> (raw)
In-Reply-To: <07e38a4009054fba63f6e46f393ad33efb495f4b.1629704273.git.michal.simek@xilinx.com>
On Mon, 23 Aug 2021 09:37:54 +0200
Michal Simek <michal.simek@xilinx.com> wrote:
> Enabling MULTI_DTB_FIT and DTB_RESELECT can end up with multi DTBs in FIT
> image placed and aligned only by 32bits (4bytes). Based on device tree
> specification:
> "Specifically, the memory reservation block shall be aligned to an 8-byte boundary
> and the structure block to a 4-byte boundary."
> is 64bit (8bytes) alignment required. That's why make sure that
> fit-dtb.blob and u-boot.itb as our primary target images for Xilinx ZynqMP
> are all 64bit aligned.
Indeed, thanks for fixing this!
>
> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
Reviewed-by: Andre Przywara <andre.przywara@arm.com>
Cheers,
Andre
> ---
>
> Changes in v2:
> - Update subject and commit message
> - Enable 64bit alignment for all - reported by Andre
>
> Makefile | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/Makefile b/Makefile
> index 269e353a28ad..0de909123cf9 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -1169,6 +1169,8 @@ MKIMAGEFLAGS_fit-dtb.blob = -f auto -A $(ARCH) -T firmware -C none -O u-boot \
> -a 0 -e 0 -E \
> $(patsubst %,-b arch/$(ARCH)/dts/%.dtb,$(subst ",,$(CONFIG_OF_LIST))) -d /dev/null
>
> +MKIMAGEFLAGS_fit-dtb.blob += -B 0x8
> +
> ifneq ($(EXT_DTB),)
> u-boot-fit-dtb.bin: u-boot-nodtb.bin $(EXT_DTB)
> $(call if_changed,cat)
> @@ -1431,6 +1433,7 @@ MKIMAGEFLAGS_u-boot.itb =
> else
> MKIMAGEFLAGS_u-boot.itb = -E
> endif
> +MKIMAGEFLAGS_u-boot.itb += -B 0x8
>
> ifdef U_BOOT_ITS
> u-boot.itb: u-boot-nodtb.bin \
next prev parent reply other threads:[~2021-08-23 11:20 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-23 7:37 [PATCH 00/10] xilinx: Add support for DTB reselection Michal Simek
2021-08-23 7:37 ` [PATCH 01/10] xilinx: fru: Replace spaces with \0 in detected name Michal Simek
2021-08-23 7:37 ` [PATCH 02/10] xilinx: Use variable for passing board_name Michal Simek
2021-08-23 7:37 ` [PATCH 03/10] xilinx: common: Change board_info[] handling Michal Simek
2021-08-23 7:37 ` [PATCH 04/10] xilinx: common: Free allocated structure Michal Simek
2021-08-23 7:37 ` [PATCH 05/10] xilinx: Add support for generic board detection Michal Simek
2021-08-23 7:37 ` [PATCH 06/10] xilinx: zynqmp: Check that DT is 64bit aligned Michal Simek
2021-08-23 7:37 ` [PATCH 07/10] Makefile: Align fit-dtb.blob and u-boot.itb by 64bits Michal Simek
2021-08-23 11:19 ` Andre Przywara [this message]
2021-08-23 7:37 ` [PATCH 08/10] arm64: dts: Make sure that all DTBs are 64bit aligned Michal Simek
2021-08-23 7:37 ` [PATCH 09/10] xilinx: zynqmp: Generate different u-boot.itb for MULTI_DTB_FIT Michal Simek
2021-08-23 7:37 ` [PATCH 10/10] xilinx: common: Enabling generic function for DT reselection Michal Simek
2021-08-27 8:09 ` [PATCH 00/10] xilinx: Add support for DTB reselection Michal Simek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210823121948.1530e6e8@slackpad.fritz.box \
--to=andre.przywara@arm.com \
--cc=bmeng.cn@gmail.com \
--cc=chee.hong.ang@intel.com \
--cc=git@xilinx.com \
--cc=marek.behun@nic.cz \
--cc=michal.simek@xilinx.com \
--cc=pali@kernel.org \
--cc=sjg@chromium.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.