From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3971AC4338F for ; Mon, 23 Aug 2021 15:25:16 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E4E0861262 for ; Mon, 23 Aug 2021 15:25:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org E4E0861262 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ON0xIOlP+UR7YWN0919ruCWStB6qJVacf+jktjEN4pg=; b=HcMOLR+CAXLSgx jD1mf5EoulOH2jYQMyRKey3YLeiZcpBsZsRAsptsLMX3tu4A59gdCsEiiQL/UAi71D4E50OCw+4/8 rsC4c7u3omSX6xccUqGi/qj8Ql1bibpjbYz0Tjbu4euD6UnJlaYQUJZKgFaImTEskwVAAA4akFOxH +5/tQNJSwkG4TZsm0rxsNNCiLWPy4A99r57sy90Z6PHJbEEYBjtIOCyr0zj86yWwMh3Qm9o90HRE8 JCworBz/Dw2aerbUTxeDhrK4Ue7qbwClWVeJrZqjIaAQ8984O+imHYxYmdYrb26krp35emhhnDzIu Xp99BonHLoZNMXfgLV5A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mIBoG-00HQtO-8c; Mon, 23 Aug 2021 15:24:24 +0000 Received: from relay3-d.mail.gandi.net ([217.70.183.195]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mIBoA-00HQrz-5u for linux-mtd@lists.infradead.org; Mon, 23 Aug 2021 15:24:22 +0000 Received: (Authenticated sender: miquel.raynal@bootlin.com) by relay3-d.mail.gandi.net (Postfix) with ESMTPSA id 4D2206000C; Mon, 23 Aug 2021 15:24:14 +0000 (UTC) Date: Mon, 23 Aug 2021 17:24:13 +0200 From: Miquel Raynal To: Kestrel seventyfour Cc: Richard Weinberger , Vignesh Raghavendra , linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] mtd: rawnand: xway: No hardcoded ECC engine, use device tree setting Message-ID: <20210823172413.0bc4ab3a@xps13> In-Reply-To: References: <20210808072643.GA5084@ubuntu> <20210816093126.442f74a1@xps13> <20210819100334.6af2d86e@xps13> Organization: Bootlin X-Mailer: Claws Mail 3.17.7 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210823_082418_538697_F5274971 X-CRM114-Status: GOOD ( 48.65 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org SGkgS2VzdHJlbCwKCktlc3RyZWwgc2V2ZW50eWZvdXIgPGtlc3RyZWxzZXZlbnR5Zm91ckBnbWFp bC5jb20+IHdyb3RlIG9uIE1vbiwgMjMgQXVnCjIwMjEgMTM6MTk6NDMgKzAyMDA6Cgo+IEhpIE1p cXXDqGwsCj4gCj4gQW0gRG8uLCAxOS4gQXVnLiAyMDIxIHVtIDEwOjAzIFVociBzY2hyaWViIE1p cXVlbCBSYXluYWwKPiA8bWlxdWVsLnJheW5hbEBib290bGluLmNvbT46Cj4gPgo+ID4gSGVsbG8s Cj4gPgo+ID4gS2VzdHJlbCBzZXZlbnR5Zm91ciA8a2VzdHJlbHNldmVudHlmb3VyQGdtYWlsLmNv bT4gd3JvdGUgb24gVGh1LCAxOSBBdWcKPiA+IDIwMjEgMDk6MjE6NDIgKzAyMDA6Cj4gPiAgCj4g PiA+IEhpIE1pcXXDqGwKPiA+ID4KPiA+ID4gQW0gTW8uLCAxNi4gQXVnLiAyMDIxIHVtIDA5OjMx IFVociBzY2hyaWViIE1pcXVlbCBSYXluYWwKPiA+ID4gPG1pcXVlbC5yYXluYWxAYm9vdGxpbi5j b20+OiAgCj4gPiA+ID4KPiA+ID4gPiBIaSBEYW5pZWwsCj4gPiA+ID4KPiA+ID4gPiBEYW5pZWwg S2VzdHJlbCA8a2VzdHJlbHNldmVudHlmb3VyQGdtYWlsLmNvbT4gd3JvdGUgb24gU3VuLCA4IEF1 ZyAyMDIxCj4gPiA+ID4gMDk6MjY6NDMgKzAyMDA6Cj4gPiA+ID4gIAo+ID4gPiA+ID4gU29tZSBk ZXZpY2VzIHVzZSBNaWNyb24gTkFORCBjaGlwcywgd2hpY2ggdXNlIG9uLWRpZSBFQ0MuIFRoZSBo YXJkY29kZWQKPiA+ID4gPiA+IHNldHRpbmcgb2YgTkFORF9FQ0NfRU5HSU5FX1RZUEVfU09GVCBt YWtlcyB0aGVtIHVudXNhYmxlLCBiZWNhdXNlIHRoZQo+ID4gPiA+ID4gc29mdHdhcmUgRUNDIG9u IHRvcCBvZiB0aGUgaGFyZHdhcmUgRUNDIHByb2R1Y2VzIGVycm9ycyBmb3IgZXZlcnkgcmVhZAo+ ID4gPiA+ID4gYW5kIHdyaXRlIGFjY2Vzcywgbm90IHRvIG1lbnRpb24gdGhhdCBib290aW5nIGRv ZXMgbm90IHdvcmssIGJlY2F1c2UKPiA+ID4gPiA+IHRoZSBib290IGxvYWRlciB1c2VzIHRoZSBj b3JyZWN0IEVDQyB3aGVuIHRyeWluZyB0byBsb2FkIHRoZSBrZXJuZWwKPiA+ID4gPiA+IGFuZCBz dG9wcyBsb2FkaW5nIG9uIHNldmVyZSBFQ0MgZXJyb3JzLgo+ID4gPiA+ID4gVGhpcyBwYXRjaCBy ZXF1aXJlcyB0aGUgZGV2aWNlcyB0aGF0IGN1cnJlbnRseSB3b3JrIHdpdGggdGhlIGhhcmQgY29k ZWQKPiA+ID4gPiA+IHNldHRpbmcgdG8gc2V0IHRoZSBuYW5kLWVjYy1tb2RlIHByb3BlcnR5IHRv IHNvZnQgaW4gdGhlaXIgZGV2aWNlCj4gPiA+ID4gPiB0cmVlLgo+ID4gPiA+ID4gIAo+ID4gPiA+ Cj4gPiA+ID4gUGxlYXNlIGFkZCBhIEZpeGVzOiBhbmQgQ2M6IHN0YWJsZSB0YWdzLCB5b3Ugd2ls bCBhbHNvIG5lZWQgdG8gc2VuZCB0bwo+ID4gPiA+IHN0YWJsZUB2Z2VyLmtlcm5lbC5vcmcgYSBk aWZmZXJlbnQgdmVyc2lvbiBvZiB0aGUgcGF0Y2ggZm9yIHRoZSBrZXJuZWwKPiA+ID4gPiA1LjQg SUlVQy4KPiA+ID4gPiAgCj4gPiA+ID4gPiBTaWduZWQtb2ZmLWJ5OiBEYW5pZWwgS2VzdHJlbCA8 a2VzdHJlbHNldmVudHlmb3VyQGdtYWlsLmNvbT4KPiA+ID4gPiA+IFRlc3RlZC1ieTogQWxla3Nh bmRlciBKYW4gQmFqa293c2tpIDxvbGVrMkB3cC5wbD4gIyB0ZXN0ZWQgb24gQlQgSG9tZSBIdWIg NUEKPiA+ID4gPiA+IC0tLQo+ID4gPiA+ID4gIGRyaXZlcnMvbXRkL25hbmQvcmF3L3h3YXlfbmFu ZC5jIHwgMiAtLQo+ID4gPiA+ID4gIDEgZmlsZSBjaGFuZ2VkLCAyIGRlbGV0aW9ucygtKQo+ID4g PiA+ID4KPiA+ID4gPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL210ZC9uYW5kL3Jhdy94d2F5X25h bmQuYyBiL2RyaXZlcnMvbXRkL25hbmQvcmF3L3h3YXlfbmFuZC5jCj4gPiA+ID4gPiBpbmRleCAy Njc1MTk3NmU1MDIuLjBhNGIwYWE3ZGQ0YyAxMDA2NDQKPiA+ID4gPiA+IC0tLSBhL2RyaXZlcnMv bXRkL25hbmQvcmF3L3h3YXlfbmFuZC5jCj4gPiA+ID4gPiArKysgYi9kcml2ZXJzL210ZC9uYW5k L3Jhdy94d2F5X25hbmQuYwo+ID4gPiA+ID4gQEAgLTE0OCw4ICsxNDgsNiBAQCBzdGF0aWMgdm9p ZCB4d2F5X3dyaXRlX2J1ZihzdHJ1Y3QgbmFuZF9jaGlwICpjaGlwLCBjb25zdCB1X2NoYXIgKmJ1 ZiwgaW50IGxlbikKPiA+ID4gPiA+Cj4gPiA+ID4gPiAgc3RhdGljIGludCB4d2F5X2F0dGFjaF9j aGlwKHN0cnVjdCBuYW5kX2NoaXAgKmNoaXApCj4gPiA+ID4gPiAgewo+ID4gPiA+ID4gLSAgICAg Y2hpcC0+ZWNjLmVuZ2luZV90eXBlID0gTkFORF9FQ0NfRU5HSU5FX1RZUEVfU09GVDsKPiA+ID4g PiA+IC0KPiA+ID4gPiA+ICAgICAgIGlmIChjaGlwLT5lY2MuYWxnbyA9PSBOQU5EX0VDQ19BTEdP X1VOS05PV04pCj4gPiA+ID4gPiAgICAgICAgICAgICAgIGNoaXAtPmVjYy5hbGdvID0gTkFORF9F Q0NfQUxHT19IQU1NSU5HOyAgCj4gPiA+ID4KPiA+ID4gPiBZb3UgYWxzbyBuZWVkIHRvIG9ubHkg c2V0IHRoZSBIYW1taW5nIGFsZ29yaXRobSB3aGVuIGVuZ2luZV90eXBlIGlzCj4gPiA+ID4gVFlQ RV9TT0ZULgo+ID4gPiA+Cj4gPiA+ID4gVGhhbmtzLAo+ID4gPiA+IE1pcXXDqGwgIAo+ID4gPgo+ ID4gPiBJIGFtIHJlYWxseSBzdHJ1Z2dsaW5nIHdpdGggd2hhdCB0byBkby4gRm9yIG9uZSBvZiB0 aGUgYWZmZWN0ZWQKPiA+ID4gZGV2aWNlcywgdGhleSBjcmVhdGVkIHR3byBkZXZpY2UKPiA+ID4g dHJlZXMsIG9uZSBmb3IgTWljcm9uIGFuZCBvbmUgZm9yIGFsbCBvdGhlcnMuIFdoaWNoIG9idmlv dXNseSBoYWQgbm8KPiA+ID4gZWZmZWN0IGR1ZSB0byB0aGUKPiA+ID4gaGFyZGNvZGVkIHNldHRp bmdzLCB3aGljaCBsZWQgbWUgdG8gUGF0Y2ggMiBhbmQgSSB0aG91Z2h0LCBzbyBiZSBpdC4KPiA+ ID4gQnV0IHRoZSBwcm9jZXNzIHRvIGZpZ3VyZQo+ID4gPiBvdXQgaWYgb25lcyBkZXZpY2UgaGFz IE1pY3JvbiBDaGlwcyBpcyBlc3NlbnRpYWxseSBmbGFzaGluZyBhbiBpbWFnZQo+ID4gPiBhbmQg aWYgaXQgZG9lcyBub3Qgd29yaywKPiA+ID4gdXNlIHRoZSBzdG9jayBPRU0gcmVjb3ZlcnkgYW5k IHRyeSB0aGUgb3RoZXIgaW1hZ2UuCj4gPiA+IEhvd2V2ZXIsIHNpbmNlIE1pY3JvbiBpcyB0aGUg b25seSBjaGlwIHRoYXQgaXMgdHJlYXRlZCBkaWZmZXJlbnRseSwgSSB3b25kZXIKPiA+ID4gaWYg eW91ciBmaXJzdCBwcm9wb3NhbCwgZXZlbiB0aG91Z2ggaXQgaXMgaGFja3ksIGlzIHRoZSBiZXR0 ZXIKPiA+ID4gYXBwcm9hY2ggdG8gc29sdmUgdGhlIGlzc3VlCj4gPiA+IGZvciB0aGUgTWljcm9u IGRldmljZXMgbm90IGJvb3RpbmcgYW5kIHRocm93aW5nIEVDQyBlcnJvcnMuIFdoYXQgZG8geW91 IHRoaW5rPwo+ID4gPiBGb2xsb3cgdXAgZmlyc3QgcGF0Y2ggb3IgdGhpcyBvbmU/ICAKPiA+Cj4g PiBJIGFtIG5vdCBzdXJlIHdlIHVuZGVyc3Rvb2QgZWFjaCBvdGhlciwgeW91ciBwYXRjaCBpcyBm aW5lLCBidXQgeW91Cj4gPiBuZWVkIHRvIGRvIHNvbWV0aGluZyBsaWtlOgo+ID4KPiA+IHN0YXRp YyBpbnQgeHdheV9hdHRhY2hfY2hpcChzdHJ1Y3QgbmFuZF9jaGlwICpjaGlwKQo+ID4gewo+ID4g ICAgIGlmIChjaGlwLT5lY2MuZW5naW5lX3R5cGUgPSBOQU5EX0VDQ19FTkdJTkVfVFlQRV9TT0ZU ICYmCj4gPiAgICAgICAgIGNoaXAtPmVjYy5hbGdvID09IE5BTkRfRUNDX0FMR09fVU5LTk9XTikK PiA+ICAgICAgICAgIGNoaXAtPmVjYy5hbGdvID0gTkFORF9FQ0NfQUxHT19IQU1NSU5HOwo+ID4K PiA+IEluIHRoZSBEVCB5b3Ugc2hvdWxkIG5vdCBmb3JjZSBhbnkgRUNDIGVuZ2luZSAoZHJvcCB0 aGUgbmFuZC1lY2MteHh4Cj4gPiBwcm9wZXJ0aWVzKSBhbmQgbGV0IHRoZSBjb3JlIGhhbmRsZSBp dC4gSXQgd2lsbCBwcm9iYWJseSBjaG9vc2UgdGhlCj4gPiBtb3N0IHN1aXRhYmxlIGVuZ2luZXMg Zm9yIHlvdS4KPiA+Cj4gPiBUaGFua3MsCj4gPiBNaXF1w6hsICAKPiAKPiB0aGFuayB5b3UgZm9y IHlvdXIgcmVzcG9uc2UuCj4gSWYgSSByZW1vdmUgdGhlIG5hbmQtZWNjLXh4eCBwcm9wZXJ0aWVz IGluIHRoZSBkZXZpY2UgdHJlZSwgdGhlIGRldmljZSB3aXRoCj4gdGhlIFRvc2hpYmEgTkFORCBj aGlwIGlzIHdvcmtpbmcuIEhvd2V2ZXIsIHRoZSBkZXZpY2Ugd2l0aCB0aGUgTWljcm9uCj4gTkFO RCBmYWlscyB3aXRoIE5PIEVDQyBmdW5jdGlvbnMgc3VwcGxpZWQ7IGhhcmR3YXJlIEVDQyBub3Qg cG9zc2libGUsCj4gc2VlbXMgdG8gYmUgYXQgbGluZSA1MzY3IG9yIGVxdWl2YWxlbnQuCj4gaHR0 cHM6Ly9lbGl4aXIuYm9vdGxpbi5jb20vbGludXgvbGF0ZXN0L3NvdXJjZS9kcml2ZXJzL210ZC9u YW5kL3Jhdy9uYW5kX2Jhc2UuYyNMNTM2Nwo+IAo+IEl0IGxvb2tzIGxpa2UgdGhlIG1pY3JvbiBu YW5kIGRyaXZlciBzdXBwb3J0cyBvbiBkaWUgb25seSBpZiBpdHMKPiBzcGVjaWZpZWQgaW50IHRo ZQo+IERldmljZSB0cmVlOgo+IGh0dHBzOi8vZWxpeGlyLmJvb3RsaW4uY29tL2xpbnV4L2xhdGVz dC9zb3VyY2UvZHJpdmVycy9tdGQvbmFuZC9yYXcvbmFuZF9taWNyb24uYyNMNTExCj4gVGhlIE1p Y3JvbiBOQU5EIGRyaXZlciBwcm9iYWJseSBuZWVkcyB0byBzZXQgdGhlIEVDQyB0eXBlIHRvIE9O IERJRSBpZiB0aGUKPiB2YXJpYWJsZSBvbmRpZSBjb250YWlucyB0aGUgc3VwcG9ydGVkIGF0dHJp YnV0ZT8hCgpZb3UncmUgcmlnaHQgYnV0IEkgZG9uJ3Qgc2VlIGFueSBlYXN5IHVwc3RyZWFtLWFi bGUgc29sdXRpb24gaGVyZS4KQ2hhbmdpbmcgdGhlIGJlaGF2aW9yIGluIHRoZSBYd2F5IGRyaXZl ciB3b3VsZCBjZXJ0YWlubHkgYnJlYWsgdXNlcnMsCmNoYW5naW5nIHRoZSBiZWhhdmlvciBpbiB0 aGUgTWljcm9uIGRyaXZlciB3b3VsZCBjZXJ0YWlubHkgYnJlYWsgZXZlbgptb3JlIHVzZXJzLiBU aGUgcm9vdCBjYXVzZSBiZWluZyBhbiBhYnNlbmNlIG9mIHByb3BlciBkZXNjcmlwdGlvbiAodGhl CmludGVncmF0aW9uIGNoYW5nZWQpLiBIb25lc3RseSBJIGZlZWwgc3R1Y2ssIG1heWJlIHlvdSBj YW4gdHJ5IHRvCnJlZ2lzdGVyIHlvdXIgZGV2aWNlLCBpZiBpdCBmYWlscywgY2hhbmdlIHRoZSBp bnRlZ3JhdGlvbiBpbiB0aGUgZHJpdmVyCih0byBhbiBvbmRpZSBlY2MgZW5naW5lKSB0aGVuIHJl dHJ5PwoKVGhhbmtzLApNaXF1w6hsCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX18KTGludXggTVREIGRpc2N1c3Npb24gbWFpbGluZyBsaXN0Cmh0 dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtbXRkLwo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D0174C4338F for ; Mon, 23 Aug 2021 15:24:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AC7E961284 for ; Mon, 23 Aug 2021 15:24:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231262AbhHWPZC convert rfc822-to-8bit (ORCPT ); Mon, 23 Aug 2021 11:25:02 -0400 Received: from relay3-d.mail.gandi.net ([217.70.183.195]:35105 "EHLO relay3-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229518AbhHWPZA (ORCPT ); Mon, 23 Aug 2021 11:25:00 -0400 Received: (Authenticated sender: miquel.raynal@bootlin.com) by relay3-d.mail.gandi.net (Postfix) with ESMTPSA id 4D2206000C; Mon, 23 Aug 2021 15:24:14 +0000 (UTC) Date: Mon, 23 Aug 2021 17:24:13 +0200 From: Miquel Raynal To: Kestrel seventyfour Cc: Richard Weinberger , Vignesh Raghavendra , linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] mtd: rawnand: xway: No hardcoded ECC engine, use device tree setting Message-ID: <20210823172413.0bc4ab3a@xps13> In-Reply-To: References: <20210808072643.GA5084@ubuntu> <20210816093126.442f74a1@xps13> <20210819100334.6af2d86e@xps13> Organization: Bootlin X-Mailer: Claws Mail 3.17.7 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Kestrel, Kestrel seventyfour wrote on Mon, 23 Aug 2021 13:19:43 +0200: > Hi Miquèl, > > Am Do., 19. Aug. 2021 um 10:03 Uhr schrieb Miquel Raynal > : > > > > Hello, > > > > Kestrel seventyfour wrote on Thu, 19 Aug > > 2021 09:21:42 +0200: > > > > > Hi Miquèl > > > > > > Am Mo., 16. Aug. 2021 um 09:31 Uhr schrieb Miquel Raynal > > > : > > > > > > > > Hi Daniel, > > > > > > > > Daniel Kestrel wrote on Sun, 8 Aug 2021 > > > > 09:26:43 +0200: > > > > > > > > > Some devices use Micron NAND chips, which use on-die ECC. The hardcoded > > > > > setting of NAND_ECC_ENGINE_TYPE_SOFT makes them unusable, because the > > > > > software ECC on top of the hardware ECC produces errors for every read > > > > > and write access, not to mention that booting does not work, because > > > > > the boot loader uses the correct ECC when trying to load the kernel > > > > > and stops loading on severe ECC errors. > > > > > This patch requires the devices that currently work with the hard coded > > > > > setting to set the nand-ecc-mode property to soft in their device > > > > > tree. > > > > > > > > > > > > > Please add a Fixes: and Cc: stable tags, you will also need to send to > > > > stable@vger.kernel.org a different version of the patch for the kernel > > > > 5.4 IIUC. > > > > > > > > > Signed-off-by: Daniel Kestrel > > > > > Tested-by: Aleksander Jan Bajkowski # tested on BT Home Hub 5A > > > > > --- > > > > > drivers/mtd/nand/raw/xway_nand.c | 2 -- > > > > > 1 file changed, 2 deletions(-) > > > > > > > > > > diff --git a/drivers/mtd/nand/raw/xway_nand.c b/drivers/mtd/nand/raw/xway_nand.c > > > > > index 26751976e502..0a4b0aa7dd4c 100644 > > > > > --- a/drivers/mtd/nand/raw/xway_nand.c > > > > > +++ b/drivers/mtd/nand/raw/xway_nand.c > > > > > @@ -148,8 +148,6 @@ static void xway_write_buf(struct nand_chip *chip, const u_char *buf, int len) > > > > > > > > > > static int xway_attach_chip(struct nand_chip *chip) > > > > > { > > > > > - chip->ecc.engine_type = NAND_ECC_ENGINE_TYPE_SOFT; > > > > > - > > > > > if (chip->ecc.algo == NAND_ECC_ALGO_UNKNOWN) > > > > > chip->ecc.algo = NAND_ECC_ALGO_HAMMING; > > > > > > > > You also need to only set the Hamming algorithm when engine_type is > > > > TYPE_SOFT. > > > > > > > > Thanks, > > > > Miquèl > > > > > > I am really struggling with what to do. For one of the affected > > > devices, they created two device > > > trees, one for Micron and one for all others. Which obviously had no > > > effect due to the > > > hardcoded settings, which led me to Patch 2 and I thought, so be it. > > > But the process to figure > > > out if ones device has Micron Chips is essentially flashing an image > > > and if it does not work, > > > use the stock OEM recovery and try the other image. > > > However, since Micron is the only chip that is treated differently, I wonder > > > if your first proposal, even though it is hacky, is the better > > > approach to solve the issue > > > for the Micron devices not booting and throwing ECC errors. What do you think? > > > Follow up first patch or this one? > > > > I am not sure we understood each other, your patch is fine, but you > > need to do something like: > > > > static int xway_attach_chip(struct nand_chip *chip) > > { > > if (chip->ecc.engine_type = NAND_ECC_ENGINE_TYPE_SOFT && > > chip->ecc.algo == NAND_ECC_ALGO_UNKNOWN) > > chip->ecc.algo = NAND_ECC_ALGO_HAMMING; > > > > In the DT you should not force any ECC engine (drop the nand-ecc-xxx > > properties) and let the core handle it. It will probably choose the > > most suitable engines for you. > > > > Thanks, > > Miquèl > > thank you for your response. > If I remove the nand-ecc-xxx properties in the device tree, the device with > the Toshiba NAND chip is working. However, the device with the Micron > NAND fails with NO ECC functions supplied; hardware ECC not possible, > seems to be at line 5367 or equivalent. > https://elixir.bootlin.com/linux/latest/source/drivers/mtd/nand/raw/nand_base.c#L5367 > > It looks like the micron nand driver supports on die only if its > specified int the > Device tree: > https://elixir.bootlin.com/linux/latest/source/drivers/mtd/nand/raw/nand_micron.c#L511 > The Micron NAND driver probably needs to set the ECC type to ON DIE if the > variable ondie contains the supported attribute?! You're right but I don't see any easy upstream-able solution here. Changing the behavior in the Xway driver would certainly break users, changing the behavior in the Micron driver would certainly break even more users. The root cause being an absence of proper description (the integration changed). Honestly I feel stuck, maybe you can try to register your device, if it fails, change the integration in the driver (to an ondie ecc engine) then retry? Thanks, Miquèl