From: <yang.yang29@zte.com.cn>
To: <gregkh@linuxfoundation.org>, <salah.triki@gmail.com>
Cc: <linux-kernel@vger.kernel.org>, <xu.xin16@zte.com.cn>,
<yang.yang29@zte.com.cn>
Subject: [PATCH] dio: add missing iounmap() after ioremap()
Date: Mon, 23 Aug 2021 20:45:47 +0800 (CST) [thread overview]
Message-ID: <202108232045471583580@zte.com.cn> (raw)
From: xu xin <xu.xin16@zte.com.cn>
If kzalloc() fails, the 'va' needs to be unmapped before returning -ENOMEM.
Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: xu xin <xu.xin16@zte.com.cn>
---
drivers/dio/dio.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletions(-)
diff --git a/drivers/dio/dio.c b/drivers/dio/dio.c
index 4c06c93..7d19250 100644
--- a/drivers/dio/dio.c
+++ b/drivers/dio/dio.c
@@ -218,9 +218,11 @@ static int __init dio_init(void)
/* Found a board, allocate it an entry in the list */
dev = kzalloc(sizeof(struct dio_dev), GFP_KERNEL);
- if (!dev)
+ if (!dev) {
+ if (scode >= DIOII_SCBASE)
+ iounmap(va);
return -ENOMEM;
+ }
dev->bus = &dio_bus;
dev->dev.parent = &dio_bus.dev;
dev->dev.bus = &dio_bus_type;
--
2.15.2
next reply other threads:[~2021-08-23 12:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-23 12:45 yang.yang29 [this message]
2021-08-27 8:59 ` [PATCH] dio: add missing iounmap() after ioremap() Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202108232045471583580@zte.com.cn \
--to=yang.yang29@zte.com.cn \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=salah.triki@gmail.com \
--cc=xu.xin16@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.