From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 525AAC4338F for ; Tue, 24 Aug 2021 10:28:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3AFAB6124B for ; Tue, 24 Aug 2021 10:28:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236305AbhHXK3b (ORCPT ); Tue, 24 Aug 2021 06:29:31 -0400 Received: from mail.netfilter.org ([217.70.188.207]:43066 "EHLO mail.netfilter.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236287AbhHXK3a (ORCPT ); Tue, 24 Aug 2021 06:29:30 -0400 Received: from netfilter.org (unknown [78.30.35.141]) by mail.netfilter.org (Postfix) with ESMTPSA id F397D600C7; Tue, 24 Aug 2021 12:27:51 +0200 (CEST) Date: Tue, 24 Aug 2021 12:28:40 +0200 From: Pablo Neira Ayuso To: Duncan Roe Cc: netfilter-devel@vger.kernel.org Subject: Re: [PATCH libnetfilter_queue v4 3/4] build: doc: VPATH builds work again Message-ID: <20210824102840.GA30322@salvia> References: <20210822041442.8394-1-duncan_roe@optusnet.com.au> <20210822041442.8394-3-duncan_roe@optusnet.com.au> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20210822041442.8394-3-duncan_roe@optusnet.com.au> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org On Sun, Aug 22, 2021 at 02:14:41PM +1000, Duncan Roe wrote: > Also get make distcleancheck to pass (only applies to VPATH builds). Not sure I follow. What commit broke this? Why does this need a separated patch? > Signed-off-by: Duncan Roe > --- > doxygen/Makefile.am | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/doxygen/Makefile.am b/doxygen/Makefile.am > index 37ed7aa..e788843 100644 > --- a/doxygen/Makefile.am > +++ b/doxygen/Makefile.am > @@ -9,7 +9,7 @@ doxyfile.stamp: $(doc_srcs) Makefile.am > # If so, sibling src directory will be empty: > # move it out of the way and symlink the real one while we run doxygen. > [ -f ../src/Makefile.in ] || \ > -{ set -x; cd ..; mv src src.distcheck; ln -s $(top_srcdir)/src; } > +{ set -x; cd ..; mv src src.distcheck; ln -s $(abs_top_srcdir)/src; } > > cd ..; doxygen doxygen.cfg >/dev/null > > @@ -228,7 +228,7 @@ CLEANFILES = doxyfile.stamp > > all-local: doxyfile.stamp > clean-local: > - rm -rf $(top_srcdir)/doxygen/man $(top_srcdir)/doxygen/html > + rm -rf man html > install-data-local: > if BUILD_MAN > mkdir -p $(DESTDIR)$(mandir)/man3 > -- > 2.17.5 >