From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2C3EFC4338F for ; Tue, 24 Aug 2021 10:35:08 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F3FD161262 for ; Tue, 24 Aug 2021 10:35:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org F3FD161262 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Ng4+IQvwgzHLbqMOEuBiaYHg+jQTAB8DzufaUvvnKTE=; b=2XnwH3k/moG+9S V+ZXFd9EcKZjYsYVl55154NW7E6hxFhf8L8eFGGB4Z/gZVT2CTl9+/l1NwlWqvU7LjIW3aPUBRag1 mgg9njAiWdE+Ei5AWZaNeLcvHs4726t3eqT2ntN4nydU2XyPVYIOyE6wtawTPrUGSBxMgQkvq8dbh Wl/bF903moLctntNiwVDz5yBD/RPOxhwvHcf6vv7nYf/Yt5qsZf/87aLOWEt+9XkJ7FEEQn+ymEzl 98J+lcMA4nEqMAARmJeIK59Ogl0e3wRSURZM6i861BTMHHhaGfiFDhdH63wIUepd5Qy3x7As4+lta Vw2DhB4FWV3DFgbtRjvQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mITjC-002Xhk-6h; Tue, 24 Aug 2021 10:32:22 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mITj8-002Xgg-F1 for linux-arm-kernel@lists.infradead.org; Tue, 24 Aug 2021 10:32:19 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 0159E61265; Tue, 24 Aug 2021 10:32:16 +0000 (UTC) Date: Tue, 24 Aug 2021 11:32:14 +0100 From: Catalin Marinas To: Mark Brown Cc: Will Deacon , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] arm64/sve: Better handle failure to allocate SVE register storage Message-ID: <20210824103213.GA623@arm.com> References: <20210817171330.25847-1-broonie@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210817171330.25847-1-broonie@kernel.org> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210824_033218_565384_152302E9 X-CRM114-Status: GOOD ( 13.06 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Aug 17, 2021 at 06:13:30PM +0100, Mark Brown wrote: > diff --git a/arch/arm64/kernel/fpsimd.c b/arch/arm64/kernel/fpsimd.c > index eb8d972ad3d2..5a294f20e9de 100644 > --- a/arch/arm64/kernel/fpsimd.c > +++ b/arch/arm64/kernel/fpsimd.c > @@ -520,12 +520,6 @@ void sve_alloc(struct task_struct *task) > /* This is a small allocation (maximum ~8KB) and Should Not Fail. */ > task->thread.sve_state = > kzalloc(sve_state_size(task), GFP_KERNEL); > - > - /* > - * If future SVE revisions can have larger vectors though, > - * this may cease to be true: > - */ > - BUG_ON(!task->thread.sve_state); > } I think we should keep a WARN_ON_ONCE here in case one wonders why the app was suddenly killed. -- Catalin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel