All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Zijlstra <peterz@infradead.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Dave Jones <davej@codemonkey.org.uk>,
	Linux Kernel <linux-kernel@vger.kernel.org>,
	Johannes Weiner <hannes@cmpxchg.org>
Subject: Re: 5.14-rc breaks iotop swap io monitoring.
Date: Tue, 24 Aug 2021 19:35:27 +0200	[thread overview]
Message-ID: <20210824173527.GA17784@worktop.programming.kicks-ass.net> (raw)
In-Reply-To: <CAHk-=wiRe=JBK85HG7xtXH1XbOWcO1KYW8csuWfLuFoHKTqF0w@mail.gmail.com>

On Tue, Aug 24, 2021 at 09:34:02AM -0700, Linus Torvalds wrote:

> Even if you enable it at run-time, processes that have been started
> before it was enabled won't actually have the 'tsk->delays'
> allocation. So I'm not sure how effective the run-time thing is.

Right; we *could* fix that by looping through the tasklist; grabbing a
task ref, doing the alloc and restarting until we've iterated the whole
tasklist and not found a task without a delays thing.

Didn't think it would be worth it, but can be done..

  reply	other threads:[~2021-08-24 17:58 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-24  3:16 5.14-rc breaks iotop swap io monitoring Dave Jones
2021-08-24  3:18 ` Dave Jones
2021-08-24  8:31 ` Peter Zijlstra
2021-08-24 15:19   ` Dave Jones
2021-08-24 16:34     ` Linus Torvalds
2021-08-24 17:35       ` Peter Zijlstra [this message]
2021-08-24 21:33       ` Dave Jones
2021-08-24 23:26         ` Linus Torvalds
2021-08-25  0:29           ` Dave Jones
2021-08-25  7:36           ` Peter Zijlstra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210824173527.GA17784@worktop.programming.kicks-ass.net \
    --to=peterz@infradead.org \
    --cc=davej@codemonkey.org.uk \
    --cc=hannes@cmpxchg.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.