From: Jason Gunthorpe <jgg@nvidia.com>
To: Alex Williamson <alex.williamson@redhat.com>
Cc: Tony Krowiak <akrowiak@linux.ibm.com>,
Christian Borntraeger <borntraeger@de.ibm.com>,
Harald Freudenberger <freude@linux.ibm.com>,
Vasily Gorbik <gor@linux.ibm.com>,
Heiko Carstens <hca@linux.ibm.com>,
Jason Herne <jjherne@linux.ibm.com>,
linux-s390@vger.kernel.org, Halil Pasic <pasic@linux.ibm.com>,
Cornelia Huck <cohuck@redhat.com>, Christoph Hellwig <hch@lst.de>,
kvm@vger.kernel.org
Subject: Re: [PATCH v4] vfio/ap_ops: Convert to use vfio_register_group_dev()
Date: Tue, 24 Aug 2021 21:42:26 -0300 [thread overview]
Message-ID: <20210825004226.GC1721383@nvidia.com> (raw)
In-Reply-To: <20210824143001.37d01a77.alex.williamson@redhat.com>
On Tue, Aug 24, 2021 at 02:30:01PM -0600, Alex Williamson wrote:
> On Mon, 23 Aug 2021 11:42:04 -0300
> Jason Gunthorpe <jgg@nvidia.com> wrote:
>
> > This is straightforward conversion, the ap_matrix_mdev is actually serving
> > as the vfio_device and we can replace all the mdev_get_drvdata()'s with a
> > simple container_of() or a dev_get_drvdata() for sysfs paths.
> >
> > Cc: Alex Williamson <alex.williamson@redhat.com>
> > Cc: Cornelia Huck <cohuck@redhat.com>
> > Cc: kvm@vger.kernel.org
> > Cc: Christoph Hellwig <hch@lst.de>
> > Reviewed-by: Tony Krowiak <akrowiak@linux.ibm.com>
> > Reviewed-by: Christoph Hellwig <hch@lst.de>
> > Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>
> > drivers/s390/crypto/vfio_ap_ops.c | 155 +++++++++++++++-----------
> > drivers/s390/crypto/vfio_ap_private.h | 2 +
> > 2 files changed, 91 insertions(+), 66 deletions(-)
>
> Jason & Tony,
>
> Would one of you please rebase on the other's series? The merge
> conflict between this and 20210823212047.1476436-1-akrowiak@linux.ibm.com
> is more than I'd like to bury into a merge commit and I can't test beyond
> a cross compile. Thanks,
Tony, as you have the Hw to test it is probably best if you do it, all
I can do is the same as Alex.
Thanks,
Jason
next prev parent reply other threads:[~2021-08-25 0:42 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-23 14:42 [PATCH v4] vfio/ap_ops: Convert to use vfio_register_group_dev() Jason Gunthorpe
2021-08-23 20:57 ` Tony Krowiak
2021-08-24 12:08 ` Jason Gunthorpe
2021-08-24 20:30 ` Alex Williamson
2021-08-25 0:42 ` Jason Gunthorpe [this message]
2021-08-25 20:13 ` Alex Williamson
2021-08-25 22:21 ` Jason Gunthorpe
2021-08-26 22:20 ` Alex Williamson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210825004226.GC1721383@nvidia.com \
--to=jgg@nvidia.com \
--cc=akrowiak@linux.ibm.com \
--cc=alex.williamson@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=cohuck@redhat.com \
--cc=freude@linux.ibm.com \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=hch@lst.de \
--cc=jjherne@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=pasic@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.