From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.7 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 82CDFC4338F for ; Wed, 25 Aug 2021 03:56:21 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4ECB260EFE for ; Wed, 25 Aug 2021 03:56:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 4ECB260EFE Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=IJyYd0Kc2GmChsF10kHcC0iv69OTjMmTKPUE6pkWl1g=; b=zqEgF+o37tHUOu +Bznb1FOuN8G9ft33FyhlNO5/c7QCBYgZIymqeuaWKjMJZ6OsY4gEqHSm8WacFrr9GKF170DVNB1b w5JutlMkRKsOt5mm1e078TC0En9gNGRhljvVkLNoQpR92UQZ8+Da8eM5afzYludwHhaCFH7L9xvYE tu8YGELTkw0JGVZhLjGQNEU26P9I8/Co2jaEjAQgL+8wlqRyx3ci3hah9LJVxPbcHUpGCLGzEWEi+ Y9franJbs2ow3L+gyJEOcjG5BkpyITEVhuckFUiDjlVX3vSyk1jy2pl4NAuuSV+CZFI0/v05n0qFW +P6ziZy2tOZYEceDoOig==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mIk1J-005Pco-O6; Wed, 25 Aug 2021 03:56:09 +0000 Received: from mail-pl1-x62c.google.com ([2607:f8b0:4864:20::62c]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mIk16-005PbS-DM; Wed, 25 Aug 2021 03:55:57 +0000 Received: by mail-pl1-x62c.google.com with SMTP id e15so13525338plh.8; Tue, 24 Aug 2021 20:55:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-disposition:content-transfer-encoding; bh=rIAtfGj5qvVENV9WWVZMFVGBJuT4wuu3+yhzjBnrODs=; b=FFLev3F07ILuAs83PdrenjINmyoPq0n77COtk2VIQDbIdEIeXPxZuh6I0B7OU+4Tt1 /E2LjvMMHnXZrAtRJc68INgHwY+om8QEUIereki+erzJLc59mmv0+1E4hb+pliTjsmta ndeTK1oMki5pOWNxKSvJzaJsxln2TScgQ5SamfpiNJoXpv3KMxIBerlRqClBYSqdCooB U8lLIVYl7tisFR0hGB6gNqVn0ZCbM4B+L/PJxhQg/O5q8o6fwNJUUyiw2WLrhxzP8wc0 2Cpx0nIq0CB10pBWCp0R5uPg16kAk9b44mmjvPweTdxHy3yQnIEoIZKrKj6BApCD6lhS O8ow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-disposition :content-transfer-encoding; bh=rIAtfGj5qvVENV9WWVZMFVGBJuT4wuu3+yhzjBnrODs=; b=AMB1to/7hxC1+2jkuIZgnJyooOvNPtcc+a2Go9KKTu4ZrcsOaOdaadvjoBT+ErATa0 xyytVTlKw93tmUbVz2TIeE9LKjci4XylGrUBtT2wffRmlB4V32aedYtXiMcRLiFv2iwr jsZi92YMUqV3VmCfKy1rTMk9ksqskrHDtoDd0jgOUQW2qUDF3oZKEu03UZ6OkxXS4N2s 7B71xMjCcP11QWFcVAirzxMnek97piaF67mWt2JNltCuGtckJqc08ZSQ1jIhkjbKoK8p k0aMhzaRVB0DK/MgQt0lmZOCpymlnFp4A5lGTCmPqf6spWQJjZnX22VRt4WOVR7JVhZF 0laA== X-Gm-Message-State: AOAM531rHyo2wHqVYB64LD/fUy1Bo6fCfTwNDL+E5heeyFN0h0QzWv3T ePaZjFKuNycCHEd3bzCRusk= X-Google-Smtp-Source: ABdhPJzGY1gLl625kG0Emo3PW5/KunYn2jQ8ZmvIFLtams9OGpbD31KTB44Cic0fv4r3bexeCiy9bA== X-Received: by 2002:a17:90b:4a82:: with SMTP id lp2mr8271118pjb.103.1629863755885; Tue, 24 Aug 2021 20:55:55 -0700 (PDT) Received: from haswell-ubuntu20.lan ([138.197.212.246]) by smtp.gmail.com with ESMTPSA id a4sm21298248pfk.0.2021.08.24.20.55.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Aug 2021 20:55:55 -0700 (PDT) From: DENG Qingfang To: Vladimir Oltean Cc: Sean Wang , Landen Chao , Andrew Lunn , Vivien Didelot , Florian Fainelli , "David S. Miller" , Jakub Kicinski , Matthias Brugger , Philipp Zabel , Russell King , "open list:MEDIATEK SWITCH DRIVER" , "moderated list:ARM/Mediatek SoC support" , "moderated list:ARM/Mediatek SoC support" , open list Subject: Re: [PATCH net-next] net: dsa: mt7530: manually set up VLAN ID 0 Date: Wed, 25 Aug 2021 11:55:45 +0800 Message-Id: <20210825035545.1836274-1-dqfext@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210824173714.cgpt2addxyjzlbyy@skbuf> References: <20210824165253.1691315-1-dqfext@gmail.com> <20210824165742.xvkb3ke7boryfoj4@skbuf> <20210824173237.1691654-1-dqfext@gmail.com> <20210824173714.cgpt2addxyjzlbyy@skbuf> MIME-Version: 1.0 Content-Disposition: inline X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210824_205556_510172_15E3DFCD X-CRM114-Status: GOOD ( 15.68 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Tue, Aug 24, 2021 at 08:37:14PM +0300, Vladimir Oltean wrote: > On Wed, Aug 25, 2021 at 01:32:37AM +0800, DENG Qingfang wrote: > > Okay. So the Fixes tag should be 6087175b7991, which initially adds the > > software fallback support for mt7530. > > Ok. Did the old code not need VLAN 0 for VLAN-unaware ports, or are you > saying that since the VLAN table lookup was bypassed completely in the > old code, 'no VLAN 0' was an inconsequential error? > > I think it's the latter. Just wanted to make sure. So that means, either > this Fixes: tag or the other, the patch still belongs to net-next. From > my side you shouldn't need to resend. You're right. The old code does not use VLAN table lookup for VLAN-unaware ports, and the current code set VLAN-unaware ports to fallback mode so missing VLAN 0 will only make them fallback to SVL. > > Reviewed-by: Vladimir Oltean _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.7 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0F2E8C4338F for ; Wed, 25 Aug 2021 03:58:09 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BAA286128A for ; Wed, 25 Aug 2021 03:58:08 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org BAA286128A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=quMi65NOjQlJAUQ0zkqtfBQtTrisDWVwZzdu+ldLiLY=; b=xIEr9uKg8jy6pj c1Dci95Dl8mnIVIDpwLFoK2+Uc03t5ML6rMYWhK8nQ7RNNVYN8lSkQsBKZjqVykjLpeAEA/7ehOQK maABXxi3DCRj9FF6Qc40OlO6BieYhzU+g8Xhef5+i2pQ6WLFU3hbYXJ0mrx63qH78fxITPdktvsGo E8cMzNrcgYTpySonkXkc/B5RP1ERUFyUzQccXV+M6kltGeOLAHzb68J1dlGsB1SsBZvjIklroMKNV 0E26sKT52v9MUQoCP6fy5wFSmDy6CrFUmI3Y2IAcgwh0Xv6pHiz2tMP70CpgeHjsZt2qDkA27B2At sxIcGGM60Kmmr8iShoFQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mIk1A-005Pbv-6f; Wed, 25 Aug 2021 03:56:00 +0000 Received: from mail-pl1-x62c.google.com ([2607:f8b0:4864:20::62c]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mIk16-005PbS-DM; Wed, 25 Aug 2021 03:55:57 +0000 Received: by mail-pl1-x62c.google.com with SMTP id e15so13525338plh.8; Tue, 24 Aug 2021 20:55:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-disposition:content-transfer-encoding; bh=rIAtfGj5qvVENV9WWVZMFVGBJuT4wuu3+yhzjBnrODs=; b=FFLev3F07ILuAs83PdrenjINmyoPq0n77COtk2VIQDbIdEIeXPxZuh6I0B7OU+4Tt1 /E2LjvMMHnXZrAtRJc68INgHwY+om8QEUIereki+erzJLc59mmv0+1E4hb+pliTjsmta ndeTK1oMki5pOWNxKSvJzaJsxln2TScgQ5SamfpiNJoXpv3KMxIBerlRqClBYSqdCooB U8lLIVYl7tisFR0hGB6gNqVn0ZCbM4B+L/PJxhQg/O5q8o6fwNJUUyiw2WLrhxzP8wc0 2Cpx0nIq0CB10pBWCp0R5uPg16kAk9b44mmjvPweTdxHy3yQnIEoIZKrKj6BApCD6lhS O8ow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-disposition :content-transfer-encoding; bh=rIAtfGj5qvVENV9WWVZMFVGBJuT4wuu3+yhzjBnrODs=; b=AMB1to/7hxC1+2jkuIZgnJyooOvNPtcc+a2Go9KKTu4ZrcsOaOdaadvjoBT+ErATa0 xyytVTlKw93tmUbVz2TIeE9LKjci4XylGrUBtT2wffRmlB4V32aedYtXiMcRLiFv2iwr jsZi92YMUqV3VmCfKy1rTMk9ksqskrHDtoDd0jgOUQW2qUDF3oZKEu03UZ6OkxXS4N2s 7B71xMjCcP11QWFcVAirzxMnek97piaF67mWt2JNltCuGtckJqc08ZSQ1jIhkjbKoK8p k0aMhzaRVB0DK/MgQt0lmZOCpymlnFp4A5lGTCmPqf6spWQJjZnX22VRt4WOVR7JVhZF 0laA== X-Gm-Message-State: AOAM531rHyo2wHqVYB64LD/fUy1Bo6fCfTwNDL+E5heeyFN0h0QzWv3T ePaZjFKuNycCHEd3bzCRusk= X-Google-Smtp-Source: ABdhPJzGY1gLl625kG0Emo3PW5/KunYn2jQ8ZmvIFLtams9OGpbD31KTB44Cic0fv4r3bexeCiy9bA== X-Received: by 2002:a17:90b:4a82:: with SMTP id lp2mr8271118pjb.103.1629863755885; Tue, 24 Aug 2021 20:55:55 -0700 (PDT) Received: from haswell-ubuntu20.lan ([138.197.212.246]) by smtp.gmail.com with ESMTPSA id a4sm21298248pfk.0.2021.08.24.20.55.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Aug 2021 20:55:55 -0700 (PDT) From: DENG Qingfang To: Vladimir Oltean Cc: Sean Wang , Landen Chao , Andrew Lunn , Vivien Didelot , Florian Fainelli , "David S. Miller" , Jakub Kicinski , Matthias Brugger , Philipp Zabel , Russell King , "open list:MEDIATEK SWITCH DRIVER" , "moderated list:ARM/Mediatek SoC support" , "moderated list:ARM/Mediatek SoC support" , open list Subject: Re: [PATCH net-next] net: dsa: mt7530: manually set up VLAN ID 0 Date: Wed, 25 Aug 2021 11:55:45 +0800 Message-Id: <20210825035545.1836274-1-dqfext@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210824173714.cgpt2addxyjzlbyy@skbuf> References: <20210824165253.1691315-1-dqfext@gmail.com> <20210824165742.xvkb3ke7boryfoj4@skbuf> <20210824173237.1691654-1-dqfext@gmail.com> <20210824173714.cgpt2addxyjzlbyy@skbuf> MIME-Version: 1.0 Content-Disposition: inline X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210824_205556_510172_15E3DFCD X-CRM114-Status: GOOD ( 15.68 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Aug 24, 2021 at 08:37:14PM +0300, Vladimir Oltean wrote: > On Wed, Aug 25, 2021 at 01:32:37AM +0800, DENG Qingfang wrote: > > Okay. So the Fixes tag should be 6087175b7991, which initially adds the > > software fallback support for mt7530. > > Ok. Did the old code not need VLAN 0 for VLAN-unaware ports, or are you > saying that since the VLAN table lookup was bypassed completely in the > old code, 'no VLAN 0' was an inconsequential error? > > I think it's the latter. Just wanted to make sure. So that means, either > this Fixes: tag or the other, the patch still belongs to net-next. From > my side you shouldn't need to resend. You're right. The old code does not use VLAN table lookup for VLAN-unaware ports, and the current code set VLAN-unaware ports to fallback mode so missing VLAN 0 will only make them fallback to SVL. > > Reviewed-by: Vladimir Oltean _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BEE7FC4320A for ; Wed, 25 Aug 2021 03:56:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A4307611C9 for ; Wed, 25 Aug 2021 03:56:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238147AbhHYD4y (ORCPT ); Tue, 24 Aug 2021 23:56:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35914 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235816AbhHYD4l (ORCPT ); Tue, 24 Aug 2021 23:56:41 -0400 Received: from mail-pj1-x102d.google.com (mail-pj1-x102d.google.com [IPv6:2607:f8b0:4864:20::102d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 526D5C061757; Tue, 24 Aug 2021 20:55:56 -0700 (PDT) Received: by mail-pj1-x102d.google.com with SMTP id fz10so4259564pjb.0; Tue, 24 Aug 2021 20:55:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-disposition:content-transfer-encoding; bh=rIAtfGj5qvVENV9WWVZMFVGBJuT4wuu3+yhzjBnrODs=; b=FFLev3F07ILuAs83PdrenjINmyoPq0n77COtk2VIQDbIdEIeXPxZuh6I0B7OU+4Tt1 /E2LjvMMHnXZrAtRJc68INgHwY+om8QEUIereki+erzJLc59mmv0+1E4hb+pliTjsmta ndeTK1oMki5pOWNxKSvJzaJsxln2TScgQ5SamfpiNJoXpv3KMxIBerlRqClBYSqdCooB U8lLIVYl7tisFR0hGB6gNqVn0ZCbM4B+L/PJxhQg/O5q8o6fwNJUUyiw2WLrhxzP8wc0 2Cpx0nIq0CB10pBWCp0R5uPg16kAk9b44mmjvPweTdxHy3yQnIEoIZKrKj6BApCD6lhS O8ow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-disposition :content-transfer-encoding; bh=rIAtfGj5qvVENV9WWVZMFVGBJuT4wuu3+yhzjBnrODs=; b=SLThGdUJpMb5UI5c0/7Pl7lsnOPQetayGyiseigS+6jSs7I2sfsmamBV+1mvhdj9VK dYlPDrdxzxs2w8jzE/M8T5hA/jSLN30Pa3EuaFYJhI60G6FYqKUWfDmVM2tp4Zix6gI3 wPXRQLtbdgXJFght3GI5c7EHjbKPbHIAcurD5+2dFJMvhdWwb7y8XE7GHcY33GzXP38G CfA8a2x4jIu1a47zvObLiiOLoUwqdJEQKvH/RraEovpDwcuJfOzXFy44ck3IkCjPC/PY HJ0m8oklP5riOJ7Wvd3dlW79rB/Dd97TtWPxR2XaTf3w+rvIkLG4sqrvmOaWUkjx8vIh 8MaA== X-Gm-Message-State: AOAM5332q9Jtq+5AcfUd9ToGiUmoBzAXJi7QFqpZi/j08M3h3ODGUFIm jZ04/cQ/dJaKEp2bA7+p9kM= X-Google-Smtp-Source: ABdhPJzGY1gLl625kG0Emo3PW5/KunYn2jQ8ZmvIFLtams9OGpbD31KTB44Cic0fv4r3bexeCiy9bA== X-Received: by 2002:a17:90b:4a82:: with SMTP id lp2mr8271118pjb.103.1629863755885; Tue, 24 Aug 2021 20:55:55 -0700 (PDT) Received: from haswell-ubuntu20.lan ([138.197.212.246]) by smtp.gmail.com with ESMTPSA id a4sm21298248pfk.0.2021.08.24.20.55.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Aug 2021 20:55:55 -0700 (PDT) From: DENG Qingfang To: Vladimir Oltean Cc: Sean Wang , Landen Chao , Andrew Lunn , Vivien Didelot , Florian Fainelli , "David S. Miller" , Jakub Kicinski , Matthias Brugger , Philipp Zabel , Russell King , "open list:MEDIATEK SWITCH DRIVER" , "moderated list:ARM/Mediatek SoC support" , "moderated list:ARM/Mediatek SoC support" , open list Subject: Re: [PATCH net-next] net: dsa: mt7530: manually set up VLAN ID 0 Date: Wed, 25 Aug 2021 11:55:45 +0800 Message-Id: <20210825035545.1836274-1-dqfext@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210824173714.cgpt2addxyjzlbyy@skbuf> References: <20210824165253.1691315-1-dqfext@gmail.com> <20210824165742.xvkb3ke7boryfoj4@skbuf> <20210824173237.1691654-1-dqfext@gmail.com> <20210824173714.cgpt2addxyjzlbyy@skbuf> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 24, 2021 at 08:37:14PM +0300, Vladimir Oltean wrote: > On Wed, Aug 25, 2021 at 01:32:37AM +0800, DENG Qingfang wrote: > > Okay. So the Fixes tag should be 6087175b7991, which initially adds the > > software fallback support for mt7530. > > Ok. Did the old code not need VLAN 0 for VLAN-unaware ports, or are you > saying that since the VLAN table lookup was bypassed completely in the > old code, 'no VLAN 0' was an inconsequential error? > > I think it's the latter. Just wanted to make sure. So that means, either > this Fixes: tag or the other, the patch still belongs to net-next. From > my side you shouldn't need to resend. You're right. The old code does not use VLAN table lookup for VLAN-unaware ports, and the current code set VLAN-unaware ports to fallback mode so missing VLAN 0 will only make them fallback to SVL. > > Reviewed-by: Vladimir Oltean