From: Dan Carpenter <dan.carpenter@oracle.com>
To: Kari Argillander <kari.argillander@gmail.com>
Cc: Konstantin Komarov <almaz.alexandrovich@paragon-software.com>,
ntfs3@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fs/ntfs3: Use kernel ALIGN macros over driver specific
Date: Wed, 25 Aug 2021 07:37:15 +0300 [thread overview]
Message-ID: <20210825043715.GP7722@kadam> (raw)
In-Reply-To: <20210824182059.1007387-1-kari.argillander@gmail.com>
On Tue, Aug 24, 2021 at 09:20:59PM +0300, Kari Argillander wrote:
> Prefer built in ALIGN macros over special made ones. This can be
> helpful for some static analyzing tools.
>
The patch is fine but the commit message is not clear that this fixes
a runtime bug.
The static checkers (Smatch) were complaining because QuadAlign() was
buggy. If you try to align something higher than UINT_MAX it got
truncated to a u32.
regards,
dan carpenter
next prev parent reply other threads:[~2021-08-25 4:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-24 18:20 [PATCH] fs/ntfs3: Use kernel ALIGN macros over driver specific Kari Argillander
2021-08-25 4:37 ` Dan Carpenter [this message]
2021-08-25 18:04 ` Kari Argillander
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210825043715.GP7722@kadam \
--to=dan.carpenter@oracle.com \
--cc=almaz.alexandrovich@paragon-software.com \
--cc=kari.argillander@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ntfs3@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.