From: Jason Gunthorpe <jgg@nvidia.com>
To: "Li, Zhijian" <lizhijian@cn.fujitsu.com>
Cc: Leon Romanovsky <leon@kernel.org>,
"dledford@redhat.com" <dledford@redhat.com>,
"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] RDMA/mlx5: return the EFAULT per ibv_advise_mr(3)
Date: Wed, 25 Aug 2021 14:28:44 -0300 [thread overview]
Message-ID: <20210825172844.GK1721383@nvidia.com> (raw)
In-Reply-To: <7b930773-0071-5b96-2a85-718d0ca07bfa@cn.fujitsu.com>
On Sat, Aug 21, 2021 at 05:44:43PM +0800, Li, Zhijian wrote:
> convert to text and send again
>
>
> Hi Jason & Leon
>
> It reminds me that ibv_advise_mr doesn't mention ENOENT any more which value the API actually returns now.
> the ENOENT cases/situations returned by kernel mlx5 implementation is most likely same with EINVALL as its manpage[1].
>
> So shall we return EINVAL instead of ENOENT in kernel side when get_prefetchable_mr returns NULL?
No, the man page should be fixed
Jason
next prev parent reply other threads:[~2021-08-25 17:28 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-01 9:20 [PATCH] RDMA/mlx5: return the EFAULT per ibv_advise_mr(3) Li Zhijian
2021-08-01 11:27 ` Leon Romanovsky
2021-08-03 16:25 ` Jason Gunthorpe
2021-08-03 17:56 ` Leon Romanovsky
2021-08-03 18:13 ` Jason Gunthorpe
2021-08-04 5:35 ` Leon Romanovsky
2021-08-04 18:50 ` Jason Gunthorpe
2021-08-05 6:43 ` Leon Romanovsky
2021-08-16 2:59 ` lizhijian
2021-08-21 9:44 ` Li, Zhijian
2021-08-25 17:28 ` Jason Gunthorpe [this message]
2021-08-26 1:18 ` lizhijian
2021-08-28 8:42 ` Li, Zhijian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210825172844.GK1721383@nvidia.com \
--to=jgg@nvidia.com \
--cc=dledford@redhat.com \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=lizhijian@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.