From: "Krzysztof Wilczyński" <kw@linux.com>
To: Bjorn Helgaas <bhelgaas@google.com>
Cc: linux-pci@vger.kernel.org
Subject: [PATCH 1/4] PCI/sysfs: Add pci_dev_resource_attr_is_visible() helper
Date: Wed, 25 Aug 2021 21:22:52 +0000 [thread overview]
Message-ID: <20210825212255.878043-2-kw@linux.com> (raw)
In-Reply-To: <20210825212255.878043-1-kw@linux.com>
This helper aims to replace functions pci_create_resource_files() and
pci_create_attr() that are currently involved in the PCI resource sysfs
objects dynamic creation and set up once the.
After the conversion to use static sysfs objects when exposing the PCI
BAR address space this helper is to be called from the .is_bin_visible()
callback for each of the PCI resources attributes.
Signed-off-by: Krzysztof Wilczyński <kw@linux.com>
---
drivers/pci/pci-sysfs.c | 40 ++++++++++++++++++++++++++++++++++++++++
1 file changed, 40 insertions(+)
diff --git a/drivers/pci/pci-sysfs.c b/drivers/pci/pci-sysfs.c
index b70f61fbcd4b..c94ab9830932 100644
--- a/drivers/pci/pci-sysfs.c
+++ b/drivers/pci/pci-sysfs.c
@@ -1237,6 +1237,46 @@ static int pci_create_resource_files(struct pci_dev *pdev)
}
return 0;
}
+
+static umode_t pci_dev_resource_attr_is_visible(struct kobject *kobj,
+ struct bin_attribute *attr,
+ int bar, bool write_combine)
+{
+ struct pci_dev *pdev = to_pci_dev(kobj_to_dev(kobj));
+ resource_size_t resource_size = pci_resource_len(pdev, bar);
+ unsigned long flags = pci_resource_flags(pdev, bar);
+
+ if (!resource_size)
+ return 0;
+
+ if (write_combine) {
+ if (arch_can_pci_mmap_wc() && (flags &
+ (IORESOURCE_MEM | IORESOURCE_PREFETCH)) ==
+ (IORESOURCE_MEM | IORESOURCE_PREFETCH))
+ attr->mmap = pci_mmap_resource_wc;
+ else
+ return 0;
+ } else {
+ if (flags & IORESOURCE_MEM) {
+ attr->mmap = pci_mmap_resource_uc;
+ } else if (flags & IORESOURCE_IO) {
+ attr->read = pci_read_resource_io;
+ attr->write = pci_write_resource_io;
+ if (arch_can_pci_mmap_io())
+ attr->mmap = pci_mmap_resource_uc;
+ } else {
+ return 0;
+ }
+ }
+
+ attr->size = resource_size;
+ if (attr->mmap)
+ attr->f_mapping = iomem_get_mapping;
+
+ attr->private = (void *)(unsigned long)bar;
+
+ return attr->attr.mode;
+}
#else /* !(defined(HAVE_PCI_MMAP) || defined(ARCH_GENERIC_PCI_MMAP_RESOURCE)) */
int __weak pci_create_resource_files(struct pci_dev *dev) { return 0; }
void __weak pci_remove_resource_files(struct pci_dev *dev) { return; }
--
2.32.0
next prev parent reply other threads:[~2021-08-25 21:23 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-25 21:22 [PATCH 0/4] PCI: Convert dynamic PCI resources sysfs objects into static Krzysztof Wilczyński
2021-08-25 21:22 ` Krzysztof Wilczyński [this message]
2021-08-26 23:35 ` [PATCH 1/4] PCI/sysfs: Add pci_dev_resource_attr_is_visible() helper Bjorn Helgaas
2021-08-27 12:11 ` Greg Kroah-Hartman
2021-08-27 22:23 ` Bjorn Helgaas
2021-09-10 14:08 ` Greg Kroah-Hartman
2021-09-10 17:21 ` Krzysztof Wilczyński
2021-09-11 10:13 ` Greg Kroah-Hartman
2021-09-13 19:47 ` Bjorn Helgaas
2021-09-14 5:06 ` Greg Kroah-Hartman
2021-09-10 16:12 ` Krzysztof Wilczyński
2021-08-25 21:22 ` [PATCH 2/4] PCI/sysfs: Add pci_dev_resource_attr() macro Krzysztof Wilczyński
2021-08-26 21:12 ` Bjorn Helgaas
2021-08-25 21:22 ` [PATCH 3/4] PCI/sysfs: Add pci_dev_resource_group() macro Krzysztof Wilczyński
2021-08-25 21:22 ` [PATCH 4/4] PCI/sysfs: Convert PCI resource files to static attributes Krzysztof Wilczyński
2021-08-25 23:02 ` [PATCH 0/4] PCI: Convert dynamic PCI resources sysfs objects into static Krzysztof Wilczyński
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210825212255.878043-2-kw@linux.com \
--to=kw@linux.com \
--cc=bhelgaas@google.com \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.