All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bill Wendling <morbo@google.com>
To: kvm@vger.kernel.org, Paolo Bonzini <pbonzini@redhat.com>,
	Roman Bolshakov <r.bolshakov@yadro.com>,
	David Matlack <dmatlack@google.com>
Cc: Bill Wendling <morbo@google.com>
Subject: [PATCH 4/4] x86: vmx: mark some test_* functions as noinline
Date: Wed, 25 Aug 2021 15:26:04 -0700	[thread overview]
Message-ID: <20210825222604.2659360-5-morbo@google.com> (raw)
In-Reply-To: <20210825222604.2659360-1-morbo@google.com>

Some test_* functions use inline asm that has labels. Clang decides that
it can inline these functions, which causes the assembler to complain
about duplicate symbols. Mark the functions as "noinline" to prevent
this.

Signed-off-by: Bill Wendling <morbo@google.com>
---
 x86/vmx.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/x86/vmx.c b/x86/vmx.c
index f0b853a..a264136 100644
--- a/x86/vmx.c
+++ b/x86/vmx.c
@@ -426,7 +426,7 @@ static void prep_flags_test_env(void **vpage, struct vmcs **vmcs, handler *old)
 	*old = handle_exception(PF_VECTOR, &pf_handler);
 }
 
-static void test_read_sentinel(void)
+static void __attribute__((noinline)) test_read_sentinel(void)
 {
 	void *vpage;
 	struct vmcs *vmcs;
@@ -474,7 +474,7 @@ static void test_vmread_flags_touch(void)
 	test_read_sentinel();
 }
 
-static void test_write_sentinel(void)
+static void __attribute__((noinline)) test_write_sentinel(void)
 {
 	void *vpage;
 	struct vmcs *vmcs;
@@ -1786,7 +1786,7 @@ static int exit_handler(union exit_reason exit_reason)
  * Tries to enter the guest, populates @result with VM-Fail, VM-Exit, entered,
  * etc...
  */
-static void vmx_enter_guest(struct vmentry_result *result)
+static void __attribute__((noinline)) vmx_enter_guest(struct vmentry_result *result)
 {
 	memset(result, 0, sizeof(*result));
 
-- 
2.33.0.rc2.250.ged5fa647cd-goog


  parent reply	other threads:[~2021-08-25 22:26 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-25 22:26 [PATCH 0/4] Prevent inlining for asm blocks with labels Bill Wendling
2021-08-25 22:26 ` [PATCH 1/4] x86: realmode: mark exec_in_big_real_mode as noinline Bill Wendling
2021-08-25 22:26 ` [PATCH 2/4] x86: svm: mark test_run " Bill Wendling
2021-08-25 22:26 ` [PATCH 3/4] x86: umip: mark do_ring3 " Bill Wendling
2021-08-25 22:26 ` Bill Wendling [this message]
2021-08-26 18:21 ` [PATCH 0/4] Prevent inlining for asm blocks with labels Sean Christopherson
2021-08-26 21:05   ` Bill Wendling
2021-09-08 20:45 ` [kvm-unit-tests PATCH v2 0/5] " Bill Wendling
2021-09-08 20:45   ` [kvm-unit-tests PATCH v2 1/5] libcflag: define the "noinline" macro Bill Wendling
2021-09-08 21:44     ` Sean Christopherson
2021-09-08 20:45   ` [kvm-unit-tests PATCH v2 2/5] x86: realmode: mark exec_in_big_real_mode as noinline Bill Wendling
2021-09-08 21:49     ` Sean Christopherson
2021-09-08 22:07       ` Bill Wendling
2021-09-08 22:51         ` Sean Christopherson
2021-09-09 17:19           ` Bill Wendling
2021-09-08 20:45   ` [kvm-unit-tests PATCH v2 3/5] x86: svm: mark test_run " Bill Wendling
2021-09-08 20:45   ` [kvm-unit-tests PATCH v2 4/5] x86: umip: mark do_ring3 " Bill Wendling
2021-09-08 20:45   ` [kvm-unit-tests PATCH v2 5/5] x86: vmx: mark some test_* functions " Bill Wendling

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210825222604.2659360-5-morbo@google.com \
    --to=morbo@google.com \
    --cc=dmatlack@google.com \
    --cc=kvm@vger.kernel.org \
    --cc=pbonzini@redhat.com \
    --cc=r.bolshakov@yadro.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.