From mboxrd@z Thu Jan 1 00:00:00 1970 Received: by 2002:a19:5205:0:0:0:0:0 with SMTP id m5csp1520401lfb; Fri, 27 Aug 2021 05:11:43 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxYE53B4xDgYYYDQ/K02rxe8E5h8jIRylyfkCsCgFHvePILDqktPjz+nLinjmQIpp6fLvh8 X-Received: by 2002:a2e:5c9:: with SMTP id 192mr7393997ljf.337.1630066302969; Fri, 27 Aug 2021 05:11:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1630066302; cv=none; d=google.com; s=arc-20160816; b=tZ51q4wG0zFR2brKhbsq4sBt2Dmg9CgnmbTeab49lP+X8Kx2PC/lRa600La6kQeALh qS+UiO085qEeek4ZTaaeao8w6K62qeeYkGjnb8xygnspti+9FWFPu8MvP9Jq0cvQI5wU SKYjNkaUlx1NJXRCRUl6mlRSH0VsDAI8FaUvwSeRjyZ7OsQrQIEXhUmGHfrygsI9sG8S j4vqH5jXycNEIcOfD0KYZlxHJH4wpiJdzklz3QlhCi4lj+b1X7gRh7ctW4m+p1C6OExd eQ5rFgycLRV6M625N3oemxO5qKPQ1qDgP/cUZpdLKIca/ONBnJuHfsT2iBNLemFztZIJ 05Yw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=RfZfF21nSXQrRkrJHOwZUW8yGVvBIA0k8gN9gMcChCw=; b=euPAarS8RLjLTiatbmIouEvI9YQpPVn3vP0CaRer3z2EMyDxwRKLu5d0d2yjohJA5K sSihRFwxu7jH9E2UWOlZcOZJADaqe6MEZIxTflDn9xcSpUy8tuaeGJ6QVRJeR5buXWl4 DC1x12oxqh8Lz3npGq7QyTgAGb+j1wmtfvRIlxXvdEqPkDw6GzHEPolBz+rogdPw8KOj 7liKj7zJo2te36r60Ri8607WH5h2C+B9RM8R+RoD5SsMsUzUBB7LxmLgKdijB3kKtVGx jgHBAp8CTzsYRRO6P8UYBYYcxAer2qpv6DkTIBR6psJhT40EFYjBJ2tUqW4F8oLjNJFT OO9Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@redhat.com header.s=mimecast20190719 header.b=K3oNLRkf; spf=pass (google.com: domain of qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id q16si6280050ejy.322.2021.08.27.05.11.42 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Fri, 27 Aug 2021 05:11:42 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@redhat.com header.s=mimecast20190719 header.b=K3oNLRkf; spf=pass (google.com: domain of qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from localhost ([::1]:54902 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mJahx-0002jZ-US for alex.bennee@linaro.org; Fri, 27 Aug 2021 08:11:41 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45400) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mJafg-00082r-GV for qemu-devel@nongnu.org; Fri, 27 Aug 2021 08:09:20 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:24900) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mJafe-0004eU-Vo for qemu-devel@nongnu.org; Fri, 27 Aug 2021 08:09:20 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1630066158; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=RfZfF21nSXQrRkrJHOwZUW8yGVvBIA0k8gN9gMcChCw=; b=K3oNLRkf7cRMU+qeQK9ocmtlaifhMKk6WupWR9EcqoOQ7uFDBeUhPrLqAUOf4KS9z1b8MT 9VbA4zVQL1sySSpWntb2fKoNOSXEr36HK83iA3QYz5lZgEOUZFmygS4HHM+DHTJ/7c+ucg VLqi0TBFw+FOCFfLkcSIajKv+6yUrfc= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-46-LlufIBm7MWi1NEmu0YqNWg-1; Fri, 27 Aug 2021 08:09:15 -0400 X-MC-Unique: LlufIBm7MWi1NEmu0YqNWg-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 162481082925; Fri, 27 Aug 2021 12:09:14 +0000 (UTC) Received: from thuth.com (unknown [10.40.192.229]) by smtp.corp.redhat.com (Postfix) with ESMTP id C33B368D97; Fri, 27 Aug 2021 12:09:11 +0000 (UTC) From: Thomas Huth To: David Gibson , qemu-devel@nongnu.org Subject: [PATCH 2/3] meson.build: Don't use internal libfdt if the user requested the system libfdt Date: Fri, 27 Aug 2021 14:09:00 +0200 Message-Id: <20210827120901.150276-3-thuth@redhat.com> In-Reply-To: <20210827120901.150276-1-thuth@redhat.com> References: <20210827120901.150276-1-thuth@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=thuth@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII" Received-SPF: pass client-ip=170.10.133.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -34 X-Spam_score: -3.5 X-Spam_bar: --- X-Spam_report: (-3.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.743, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-arm@nongnu.org, qemu-ppc@nongnu.org, John Paul Adrian Glaubitz Errors-To: qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org Sender: "Qemu-devel" X-TUID: YFJkovm8TGs9 If the users ran configure with --enable-libfdt=system, they likely did that on purpose. We should not silently fall back to the internal libfdt if the system libfdt is not usable, but report the problem with a proper message instead. Signed-off-by: Thomas Huth --- meson.build | 2 ++ 1 file changed, 2 insertions(+) diff --git a/meson.build b/meson.build index ee156ff0a5..bc6a52b909 100644 --- a/meson.build +++ b/meson.build @@ -1912,6 +1912,8 @@ if have_system int main(void) { fdt_check_full(NULL, 0); return 0; }''', dependencies: fdt) fdt_opt = 'system' + elif fdt_opt == 'system' + error('system libfdt requested, but it is too old (1.5.1 or newer required)') elif have_internal fdt_opt = 'internal' else -- 2.27.0