From: Christoph Hellwig <hch@lst.de>
To: Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>
Cc: Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>,
Milan Broz <gmazyland@gmail.com>, Hillf Danton <hdanton@sina.com>,
Pavel Tatashin <pasha.tatashin@soleen.com>,
"Reviewed-by : Tyler Hicks" <tyhicks@linux.microsoft.com>,
linux-block@vger.kernel.org
Subject: Re: [PATCH 5/8] loop: merge the cryptoloop module into the main loop module
Date: Fri, 27 Aug 2021 17:38:11 +0200 [thread overview]
Message-ID: <20210827153811.GA21217@lst.de> (raw)
In-Reply-To: <3a2fcf7b-f5d6-bb12-65c7-c2ebc5975383@i-love.sakura.ne.jp>
On Fri, Aug 27, 2021 at 08:33:10PM +0900, Tetsuo Handa wrote:
> I posted "[PATCH v5] block: genhd: don't call probe function with major_names_lock held"
> ( https://lkml.kernel.org/r/b2af8a5b-3c1b-204e-7f56-bea0b15848d6@i-love.sakura.ne.jp ) for v5.14 (and also stable),
And I've already told you that I think this is going in the wrong direction and
do not thing it is a good idea.
> and "[PATCH] loop: replace loop_ctl_mutex with loop_idr_spinlock"
> ( https://lkml.kernel.org/r/2642808b-a7d0-28ff-f288-0f4eabc562f7@i-love.sakura.ne.jp ) for v5.15 (but not stable).
I will review this.
> Don't try to merge the cryptoloop module into the loop module now; it makes
> backporting the fix difficult.
Which is on the one true, on the other hand simply does not matter.
next prev parent reply other threads:[~2021-08-27 15:38 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-26 13:38 sort out the lock order in the loop driver v2 Christoph Hellwig
2021-08-26 13:38 ` [PATCH 1/8] cryptoloop: fix a sparse annotation Christoph Hellwig
2021-08-26 13:38 ` [PATCH 2/8] loop: remove the unused idx argument to loop_control_get_free Christoph Hellwig
2021-08-26 13:38 ` [PATCH 3/8] loop: remove the ->ioctl method in loop_func_table Christoph Hellwig
2021-08-26 13:38 ` [PATCH 4/8] loop: return void from the ->release " Christoph Hellwig
2021-08-26 13:38 ` [PATCH 5/8] loop: merge the cryptoloop module into the main loop module Christoph Hellwig
2021-08-26 16:31 ` Milan Broz
2021-08-26 16:34 ` Christoph Hellwig
2021-08-26 16:44 ` Milan Broz
2021-08-27 6:45 ` Christoph Hellwig
2021-08-27 11:33 ` Tetsuo Handa
2021-08-27 15:38 ` Christoph Hellwig [this message]
2021-08-26 13:38 ` [PATCH 6/8] loop: devirtualize transfer transformations Christoph Hellwig
2021-08-26 13:38 ` [PATCH 7/8] loop: move loop device deletion out of loop_ctl_mutex Christoph Hellwig
2021-08-26 13:38 ` [PATCH 8/8] loop: avoid holding loop_ctl_mutex over add_disk Christoph Hellwig
2021-08-27 0:30 ` sort out the lock order in the loop driver v2 Tetsuo Handa
2021-08-27 6:40 ` Christoph Hellwig
2021-08-27 7:46 ` Tetsuo Handa
2021-08-27 15:34 ` Christoph Hellwig
[not found] ` <20210827130259.2622-1-hdanton@sina.com>
2021-08-27 14:10 ` Tetsuo Handa
[not found] ` <20210828035114.2762-1-hdanton@sina.com>
2021-08-28 5:17 ` Tetsuo Handa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210827153811.GA21217@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=gmazyland@gmail.com \
--cc=hdanton@sina.com \
--cc=linux-block@vger.kernel.org \
--cc=pasha.tatashin@soleen.com \
--cc=penguin-kernel@i-love.sakura.ne.jp \
--cc=tyhicks@linux.microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.