From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 27342C432BE for ; Fri, 27 Aug 2021 17:12:57 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E2CC760F4C for ; Fri, 27 Aug 2021 17:12:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org E2CC760F4C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=i2XqTrIK9Gl7JZZs/1Srtby9K2xjDmfiVMJEVr2yzf4=; b=3crixfiulwOcXK DpcBdbkQBg3D7I41PzFJfVkATMMdcvsp4HgEmGLTsymuK3ow3AVDkOMTttVYmUz8DoMQN0nYnsTq/ S8JhLY8jEeKSxA6QObdPUs5pMpfmFdk7wyb19D/R5JBPFC+NOAPpS1XTQV29JP9MQ2IhQIhbFCUxu e8PEm/U3jCYEXXd/tvek8oLEVdIz03DapCdbnyk5tuC5XMdaEVV1zX4BLO1lgJu7J+bLGgd4Iik1f GsPlYE9mJFcgbhUVljr40Bd3vTlVvCSnau50tLb4h/z8P11DEk1OZQxBPo6q7CHWJbiXWsKlnF6Am IF4I9iCd5eoHqq/awbtw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mJfNR-00CpLq-77; Fri, 27 Aug 2021 17:10:49 +0000 Received: from verein.lst.de ([213.95.11.211]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mJfNN-00CpKx-F6 for linux-arm-kernel@lists.infradead.org; Fri, 27 Aug 2021 17:10:46 +0000 Received: by verein.lst.de (Postfix, from userid 2407) id 0EE4967373; Fri, 27 Aug 2021 19:10:42 +0200 (CEST) Date: Fri, 27 Aug 2021 19:10:41 +0200 From: Christoph Hellwig To: Linus Torvalds Cc: Christoph Hellwig , Will Deacon , Catalin Marinas , Linux ARM , Linux Kernel Mailing List , Android Kernel Team Subject: Re: [GIT PULL] arm64 fix for 5.14 Message-ID: <20210827171041.GA28149@lst.de> References: <20210826131747.GE26318@willie-the-truck> <20210827074041.GA24309@lst.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210827_101045_696525_7735A656 X-CRM114-Status: GOOD ( 16.62 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Aug 27, 2021 at 10:03:29AM -0700, Linus Torvalds wrote: > The ARM code actually uses that complex pfn_to_section_nr() and > memblock_is_memory() etc. That seems a bit of an overkill, since the > memblock code should have translated all that into being reserved. > > But again, I don't actually know exactly what triggered the issue on > ARM, so the above is just my "this seems to be a more proper check" > suggestion. They CCed me on their earlier discussion, but I did not catch up on it until you responded to the pull request If I understood it correct it was about a platform device mapping a MMIO region (like a PCI bar), but something about section alignment cause pfn_valid to mistrigger. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B058AC432BE for ; Fri, 27 Aug 2021 17:10:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9805060E93 for ; Fri, 27 Aug 2021 17:10:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236514AbhH0RLe (ORCPT ); Fri, 27 Aug 2021 13:11:34 -0400 Received: from verein.lst.de ([213.95.11.211]:34663 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234297AbhH0RLd (ORCPT ); Fri, 27 Aug 2021 13:11:33 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id 0EE4967373; Fri, 27 Aug 2021 19:10:42 +0200 (CEST) Date: Fri, 27 Aug 2021 19:10:41 +0200 From: Christoph Hellwig To: Linus Torvalds Cc: Christoph Hellwig , Will Deacon , Catalin Marinas , Linux ARM , Linux Kernel Mailing List , Android Kernel Team Subject: Re: [GIT PULL] arm64 fix for 5.14 Message-ID: <20210827171041.GA28149@lst.de> References: <20210826131747.GE26318@willie-the-truck> <20210827074041.GA24309@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Aug 27, 2021 at 10:03:29AM -0700, Linus Torvalds wrote: > The ARM code actually uses that complex pfn_to_section_nr() and > memblock_is_memory() etc. That seems a bit of an overkill, since the > memblock code should have translated all that into being reserved. > > But again, I don't actually know exactly what triggered the issue on > ARM, so the above is just my "this seems to be a more proper check" > suggestion. They CCed me on their earlier discussion, but I did not catch up on it until you responded to the pull request If I understood it correct it was about a platform device mapping a MMIO region (like a PCI bar), but something about section alignment cause pfn_valid to mistrigger.