From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C0780C43214 for ; Sun, 29 Aug 2021 07:30:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9302D60E76 for ; Sun, 29 Aug 2021 07:30:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234838AbhH2Hbi (ORCPT ); Sun, 29 Aug 2021 03:31:38 -0400 Received: from m43-7.mailgun.net ([69.72.43.7]:27868 "EHLO m43-7.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232155AbhH2Hbf (ORCPT ); Sun, 29 Aug 2021 03:31:35 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1630222243; h=Date: Message-Id: Cc: To: References: In-Reply-To: From: Subject: Content-Transfer-Encoding: MIME-Version: Content-Type: Sender; bh=DHvXwT1LctpTZp4W8bTzih3oWrD/e7ln1sSyPPM0QXc=; b=ZqybbWZqjJsy5IKDWuLmsBNOx4za1RNHPeUm+WN808BukhCbToiREyLaQWPbZBV8V1YBulOm OQveiNDsyISia84Xe9UnyJxa0mLU6/8dBhHvwt5gNq9dsVy7YUdCHLGg59hi3VUzN0MbevXC 81zlVWcjSbDglizdgYkLjREedjk= X-Mailgun-Sending-Ip: 69.72.43.7 X-Mailgun-Sid: WyIyNzljNCIsICJsaW51eC1oYXJkZW5pbmdAdmdlci5rZXJuZWwub3JnIiwgImJlOWU0YSJd Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n02.prod.us-west-2.postgun.com with SMTP id 612b37944cd90150371dde65 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Sun, 29 Aug 2021 07:30:28 GMT Sender: kvalo=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 69AECC43460; Sun, 29 Aug 2021 07:30:28 +0000 (UTC) Received: from tykki.adurom.net (tynnyri.adurom.net [51.15.11.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo) by smtp.codeaurora.org (Postfix) with ESMTPSA id 45C3FC4338F; Sun, 29 Aug 2021 07:30:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 smtp.codeaurora.org 45C3FC4338F Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=fail smtp.mailfrom=codeaurora.org Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH v2] rtlwifi: rtl8192de: Style clean-ups From: Kalle Valo In-Reply-To: <20210826023230.1148924-1-keescook@chromium.org> References: <20210826023230.1148924-1-keescook@chromium.org> To: Kees Cook Cc: Ping-Ke Shih , Kees Cook , "David S. Miller" , Jakub Kicinski , Larry Finger , Colin Ian King , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, Joe Perches , Kaixu Xia , linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org User-Agent: pwcli/0.1.0-git (https://github.com/kvalo/pwcli/) Python/3.7.3 Message-Id: <20210829073028.69AECC43460@smtp.codeaurora.org> Date: Sun, 29 Aug 2021 07:30:28 +0000 (UTC) Precedence: bulk List-ID: X-Mailing-List: linux-hardening@vger.kernel.org Kees Cook wrote: > Clean up some style issues: > - Use ARRAY_SIZE() for arrays (even when u8 sized) > - Remove redundant CHANNEL_MAX_NUMBER_2G define. > Additionally fix some dead code WARNs. > > Cc: Ping-Ke Shih > Cc: Kalle Valo > Cc: "David S. Miller" > Cc: Jakub Kicinski > Cc: Larry Finger > Cc: Colin Ian King > Cc: linux-wireless@vger.kernel.org > Cc: netdev@vger.kernel.org > Signed-off-by: Kees Cook > Acked-by: Ping-Ke Shih Failed to apply, please rebase over wireless-drivers-next. error: sha1 information is lacking or useless (drivers/net/wireless/realtek/rtlwifi/rtl8192de/phy.c). error: could not build fake ancestor hint: Use 'git am --show-current-patch' to see the failed patch Applying: rtlwifi: rtl8192de: Style clean-ups Patch failed at 0001 rtlwifi: rtl8192de: Style clean-ups Patch set to Changes Requested. -- https://patchwork.kernel.org/project/linux-wireless/patch/20210826023230.1148924-1-keescook@chromium.org/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches