From: kernel test robot <lkp@intel.com>
To: kbuild@lists.01.org
Subject: [linux-next:master 1511/10945] drivers/clk/renesas/rzg2l-cpg.c:303 rzg2l_cpg_register_core_clk() warn: passing zero to 'PTR_ERR'
Date: Sun, 29 Aug 2021 17:05:09 +0800 [thread overview]
Message-ID: <202108291703.pbwwa8Kq-lkp@intel.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 8057 bytes --]
CC: kbuild-all(a)lists.01.org
CC: Linux Memory Management List <linux-mm@kvack.org>
TO: Geert Uytterhoeven <geert+renesas@glider.be>
CC: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Hi Geert,
First bad commit (maybe != root cause):
tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head: 5e63226c72287bc6c6724d4fc7e157af0e3d7908
commit: 0aae437ac5c264e8e2cb6c3fead20b44d2fa31d1 [1511/10945] clk: renesas: Rename renesas-rzg2l-cpg.[ch] to rzg2l-cpg.[ch]
:::::: branch date: 2 days ago
:::::: commit date: 6 weeks ago
config: nds32-randconfig-m031-20210829 (attached as .config)
compiler: nds32le-linux-gcc (GCC) 11.2.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
smatch warnings:
drivers/clk/renesas/rzg2l-cpg.c:303 rzg2l_cpg_register_core_clk() warn: passing zero to 'PTR_ERR'
vim +/PTR_ERR +303 drivers/clk/renesas/rzg2l-cpg.c
ef3c613ccd68a7 drivers/clk/renesas/renesas-rzg2l-cpg.c Lad Prabhakar 2021-06-09 247
ef3c613ccd68a7 drivers/clk/renesas/renesas-rzg2l-cpg.c Lad Prabhakar 2021-06-09 248 static void __init
ef3c613ccd68a7 drivers/clk/renesas/renesas-rzg2l-cpg.c Lad Prabhakar 2021-06-09 249 rzg2l_cpg_register_core_clk(const struct cpg_core_clk *core,
ef3c613ccd68a7 drivers/clk/renesas/renesas-rzg2l-cpg.c Lad Prabhakar 2021-06-09 250 const struct rzg2l_cpg_info *info,
ef3c613ccd68a7 drivers/clk/renesas/renesas-rzg2l-cpg.c Lad Prabhakar 2021-06-09 251 struct rzg2l_cpg_priv *priv)
ef3c613ccd68a7 drivers/clk/renesas/renesas-rzg2l-cpg.c Lad Prabhakar 2021-06-09 252 {
ef3c613ccd68a7 drivers/clk/renesas/renesas-rzg2l-cpg.c Lad Prabhakar 2021-06-09 253 struct clk *clk = ERR_PTR(-EOPNOTSUPP), *parent;
ef3c613ccd68a7 drivers/clk/renesas/renesas-rzg2l-cpg.c Lad Prabhakar 2021-06-09 254 struct device *dev = priv->dev;
ef3c613ccd68a7 drivers/clk/renesas/renesas-rzg2l-cpg.c Lad Prabhakar 2021-06-09 255 unsigned int id = core->id, div = core->div;
ef3c613ccd68a7 drivers/clk/renesas/renesas-rzg2l-cpg.c Lad Prabhakar 2021-06-09 256 const char *parent_name;
ef3c613ccd68a7 drivers/clk/renesas/renesas-rzg2l-cpg.c Lad Prabhakar 2021-06-09 257
ef3c613ccd68a7 drivers/clk/renesas/renesas-rzg2l-cpg.c Lad Prabhakar 2021-06-09 258 WARN_DEBUG(id >= priv->num_core_clks);
ef3c613ccd68a7 drivers/clk/renesas/renesas-rzg2l-cpg.c Lad Prabhakar 2021-06-09 259 WARN_DEBUG(PTR_ERR(priv->clks[id]) != -ENOENT);
ef3c613ccd68a7 drivers/clk/renesas/renesas-rzg2l-cpg.c Lad Prabhakar 2021-06-09 260
ef3c613ccd68a7 drivers/clk/renesas/renesas-rzg2l-cpg.c Lad Prabhakar 2021-06-09 261 if (!core->name) {
ef3c613ccd68a7 drivers/clk/renesas/renesas-rzg2l-cpg.c Lad Prabhakar 2021-06-09 262 /* Skip NULLified clock */
ef3c613ccd68a7 drivers/clk/renesas/renesas-rzg2l-cpg.c Lad Prabhakar 2021-06-09 263 return;
ef3c613ccd68a7 drivers/clk/renesas/renesas-rzg2l-cpg.c Lad Prabhakar 2021-06-09 264 }
ef3c613ccd68a7 drivers/clk/renesas/renesas-rzg2l-cpg.c Lad Prabhakar 2021-06-09 265
ef3c613ccd68a7 drivers/clk/renesas/renesas-rzg2l-cpg.c Lad Prabhakar 2021-06-09 266 switch (core->type) {
ef3c613ccd68a7 drivers/clk/renesas/renesas-rzg2l-cpg.c Lad Prabhakar 2021-06-09 267 case CLK_TYPE_IN:
ef3c613ccd68a7 drivers/clk/renesas/renesas-rzg2l-cpg.c Lad Prabhakar 2021-06-09 268 clk = of_clk_get_by_name(priv->dev->of_node, core->name);
ef3c613ccd68a7 drivers/clk/renesas/renesas-rzg2l-cpg.c Lad Prabhakar 2021-06-09 269 break;
ef3c613ccd68a7 drivers/clk/renesas/renesas-rzg2l-cpg.c Lad Prabhakar 2021-06-09 270 case CLK_TYPE_FF:
ef3c613ccd68a7 drivers/clk/renesas/renesas-rzg2l-cpg.c Lad Prabhakar 2021-06-09 271 WARN_DEBUG(core->parent >= priv->num_core_clks);
ef3c613ccd68a7 drivers/clk/renesas/renesas-rzg2l-cpg.c Lad Prabhakar 2021-06-09 272 parent = priv->clks[core->parent];
ef3c613ccd68a7 drivers/clk/renesas/renesas-rzg2l-cpg.c Lad Prabhakar 2021-06-09 273 if (IS_ERR(parent)) {
ef3c613ccd68a7 drivers/clk/renesas/renesas-rzg2l-cpg.c Lad Prabhakar 2021-06-09 274 clk = parent;
ef3c613ccd68a7 drivers/clk/renesas/renesas-rzg2l-cpg.c Lad Prabhakar 2021-06-09 275 goto fail;
ef3c613ccd68a7 drivers/clk/renesas/renesas-rzg2l-cpg.c Lad Prabhakar 2021-06-09 276 }
ef3c613ccd68a7 drivers/clk/renesas/renesas-rzg2l-cpg.c Lad Prabhakar 2021-06-09 277
ef3c613ccd68a7 drivers/clk/renesas/renesas-rzg2l-cpg.c Lad Prabhakar 2021-06-09 278 parent_name = __clk_get_name(parent);
ef3c613ccd68a7 drivers/clk/renesas/renesas-rzg2l-cpg.c Lad Prabhakar 2021-06-09 279 clk = clk_register_fixed_factor(NULL, core->name,
ef3c613ccd68a7 drivers/clk/renesas/renesas-rzg2l-cpg.c Lad Prabhakar 2021-06-09 280 parent_name, CLK_SET_RATE_PARENT,
ef3c613ccd68a7 drivers/clk/renesas/renesas-rzg2l-cpg.c Lad Prabhakar 2021-06-09 281 core->mult, div);
ef3c613ccd68a7 drivers/clk/renesas/renesas-rzg2l-cpg.c Lad Prabhakar 2021-06-09 282 break;
ef3c613ccd68a7 drivers/clk/renesas/renesas-rzg2l-cpg.c Lad Prabhakar 2021-06-09 283 case CLK_TYPE_SAM_PLL:
ef3c613ccd68a7 drivers/clk/renesas/renesas-rzg2l-cpg.c Lad Prabhakar 2021-06-09 284 clk = rzg2l_cpg_pll_clk_register(core, priv->clks,
ef3c613ccd68a7 drivers/clk/renesas/renesas-rzg2l-cpg.c Lad Prabhakar 2021-06-09 285 priv->base, priv);
ef3c613ccd68a7 drivers/clk/renesas/renesas-rzg2l-cpg.c Lad Prabhakar 2021-06-09 286 break;
ef3c613ccd68a7 drivers/clk/renesas/renesas-rzg2l-cpg.c Lad Prabhakar 2021-06-09 287 case CLK_TYPE_DIV:
ef3c613ccd68a7 drivers/clk/renesas/renesas-rzg2l-cpg.c Lad Prabhakar 2021-06-09 288 clk = rzg2l_cpg_div_clk_register(core, priv->clks,
ef3c613ccd68a7 drivers/clk/renesas/renesas-rzg2l-cpg.c Lad Prabhakar 2021-06-09 289 priv->base, priv);
ef3c613ccd68a7 drivers/clk/renesas/renesas-rzg2l-cpg.c Lad Prabhakar 2021-06-09 290 break;
ef3c613ccd68a7 drivers/clk/renesas/renesas-rzg2l-cpg.c Lad Prabhakar 2021-06-09 291 default:
ef3c613ccd68a7 drivers/clk/renesas/renesas-rzg2l-cpg.c Lad Prabhakar 2021-06-09 292 goto fail;
d42d57fe86e98c drivers/clk/renesas/renesas-rzg2l-cpg.c Yang Li 2021-06-15 293 }
ef3c613ccd68a7 drivers/clk/renesas/renesas-rzg2l-cpg.c Lad Prabhakar 2021-06-09 294
ef3c613ccd68a7 drivers/clk/renesas/renesas-rzg2l-cpg.c Lad Prabhakar 2021-06-09 295 if (IS_ERR_OR_NULL(clk))
ef3c613ccd68a7 drivers/clk/renesas/renesas-rzg2l-cpg.c Lad Prabhakar 2021-06-09 296 goto fail;
ef3c613ccd68a7 drivers/clk/renesas/renesas-rzg2l-cpg.c Lad Prabhakar 2021-06-09 297
ef3c613ccd68a7 drivers/clk/renesas/renesas-rzg2l-cpg.c Lad Prabhakar 2021-06-09 298 dev_dbg(dev, "Core clock %pC at %lu Hz\n", clk, clk_get_rate(clk));
ef3c613ccd68a7 drivers/clk/renesas/renesas-rzg2l-cpg.c Lad Prabhakar 2021-06-09 299 priv->clks[id] = clk;
ef3c613ccd68a7 drivers/clk/renesas/renesas-rzg2l-cpg.c Lad Prabhakar 2021-06-09 300 return;
ef3c613ccd68a7 drivers/clk/renesas/renesas-rzg2l-cpg.c Lad Prabhakar 2021-06-09 301
ef3c613ccd68a7 drivers/clk/renesas/renesas-rzg2l-cpg.c Lad Prabhakar 2021-06-09 302 fail:
ef3c613ccd68a7 drivers/clk/renesas/renesas-rzg2l-cpg.c Lad Prabhakar 2021-06-09 @303 dev_err(dev, "Failed to register %s clock %s: %ld\n", "core",
ef3c613ccd68a7 drivers/clk/renesas/renesas-rzg2l-cpg.c Lad Prabhakar 2021-06-09 304 core->name, PTR_ERR(clk));
ef3c613ccd68a7 drivers/clk/renesas/renesas-rzg2l-cpg.c Lad Prabhakar 2021-06-09 305 }
ef3c613ccd68a7 drivers/clk/renesas/renesas-rzg2l-cpg.c Lad Prabhakar 2021-06-09 306
:::::: The code at line 303 was first introduced by commit
:::::: ef3c613ccd68a78727b817c3dacf4a68d1ffc67f clk: renesas: Add CPG core wrapper for RZ/G2L SoC
:::::: TO: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
:::::: CC: Geert Uytterhoeven <geert+renesas@glider.be>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 32525 bytes --]
reply other threads:[~2021-08-29 9:05 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202108291703.pbwwa8Kq-lkp@intel.com \
--to=lkp@intel.com \
--cc=kbuild@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.