From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7D869C432BE for ; Sun, 29 Aug 2021 18:02:26 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DCF4F60E97 for ; Sun, 29 Aug 2021 18:02:25 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org DCF4F60E97 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 47D0E8332D; Sun, 29 Aug 2021 20:02:24 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="B49AYe+e"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 06D2883322; Sun, 29 Aug 2021 20:02:15 +0200 (CEST) Received: from mail-qv1-xf2e.google.com (mail-qv1-xf2e.google.com [IPv6:2607:f8b0:4864:20::f2e]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 785D383320 for ; Sun, 29 Aug 2021 20:02:06 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qv1-xf2e.google.com with SMTP id l4so7073499qvl.12 for ; Sun, 29 Aug 2021 11:02:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=68OGgkB4f028tGsmCqra7rWYklnR8P0Py4FoePLziSw=; b=B49AYe+eDZNR1pCgR6UCY8gw4LQZ018PBUBpwoKDaztI9JnuGKqdQRM8O3s5mFafcr GOZ/4RAmRJ9e/m7Q+CjdbFHDfuQ0POyPNHMwmxiUF9K5yBHKT/AXdQS+m1j3jmt7lnbn eI2m2Rio1Pu9ktEz0+x5Gz7WGRPRM7qhxMPeE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=68OGgkB4f028tGsmCqra7rWYklnR8P0Py4FoePLziSw=; b=LREEs3pjQo8oay2KjV8yAKjrGt9MxClreOMjFNoRvIoicXKi30GXeCSpR8keTdmcb2 R0OGx4nDbCCZGWS60k5ZlVItXPdNv+eHUCRFRTKugx0BJI34O6v0YRTwbB1QH/u7IcdK a1w69LxcjyPMeo9wtw4ZhAy7R2w2leQlq4ULEy69mWj5f+Jt+4fvQXxBv4290B6U7/GC XjzswdQCdp2XoZMYqvtsnLLC4PffWFjz0MlvlvfgArdRLY8vvwLIOxvAIaRT5Bt2EDsJ +xp2bVUSUP/yDUF6L0JiRaYQizPiWNg0sMKd/Jy+o9EJZxCmAZFA8ObRLw6B0Bc+NL6w ZHRw== X-Gm-Message-State: AOAM533TGIchqaqfZeR2TFrl2y27l6YVDCqZYNF34ufqI5zxGktcR1cu zRwyP6AJ28FWTfoPCb/6byNKrg== X-Google-Smtp-Source: ABdhPJzg54qDSQcUXjY/7X4gwQ0C6DPaM5OVliBM1vvHEE0HbpTpTe1XSi1jDaFWXMMj/cAb/Q9vAA== X-Received: by 2002:a05:6214:28b:: with SMTP id l11mr20139154qvv.18.1630260125256; Sun, 29 Aug 2021 11:02:05 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b01-cbda-8054-417e-d97b-7576.res6.spectrum.com. [2603:6081:7b01:cbda:8054:417e:d97b:7576]) by smtp.gmail.com with ESMTPSA id c67sm9737806qke.113.2021.08.29.11.02.04 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Sun, 29 Aug 2021 11:02:04 -0700 (PDT) Date: Sun, 29 Aug 2021 14:02:02 -0400 From: Tom Rini To: Marek Vasut Cc: u-boot@lists.denx.de, Simon Glass , Simon Goldschmidt Subject: Re: [PATCH 02/14] lmb: Use CONFIG_LMB_*_REGIONS only if they are defined Message-ID: <20210829180202.GG858@bill-the-cat> References: <20210815181314.132330-1-marek.vasut+renesas@gmail.com> <20210815181314.132330-2-marek.vasut+renesas@gmail.com> <20210815194721.GN858@bill-the-cat> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="dI05wiOPtfTR8jth" Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.9.4 (2018-02-28) X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean --dI05wiOPtfTR8jth Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Aug 29, 2021 at 06:26:23PM +0200, Marek Vasut wrote: > On 8/15/21 9:47 PM, Tom Rini wrote: > > On Sun, Aug 15, 2021 at 08:13:02PM +0200, Marek Vasut wrote: > >=20 > > > The CONFIG_LMB_*_REGIONS are defined only if CONFIG_LMB is enabled, > > > protect access to those two config options to avoid undefined macro > > > errors. > > >=20 > > > Signed-off-by: Marek Vasut > > > Cc: Simon Glass > > > Cc: Simon Goldschmidt > > > Cc: Tom Rini > > > --- > > > include/lmb.h | 4 ++-- > > > 1 file changed, 2 insertions(+), 2 deletions(-) > > >=20 > > > diff --git a/include/lmb.h b/include/lmb.h > > > index 3c4afdf9f0..fa1474a360 100644 > > > --- a/include/lmb.h > > > +++ b/include/lmb.h > > > @@ -44,7 +44,7 @@ struct lmb_property { > > > struct lmb_region { > > > unsigned long cnt; > > > unsigned long max; > > > -#if IS_ENABLED(CONFIG_LMB_USE_MAX_REGIONS) > > > +#if IS_ENABLED(CONFIG_LMB) && IS_ENABLED(CONFIG_LMB_USE_MAX_REGIONS) This doesn't make sense to me, still. You cannot enable CONFIG_LMB_USE_MAX_REGIONS without CONFIG_LMB as the former depends on the latter in Kconfig. > > > struct lmb_property region[CONFIG_LMB_MAX_REGIONS]; > > > #else > > > struct lmb_property *region; > > > @@ -67,7 +67,7 @@ struct lmb_region { > > > struct lmb { > > > struct lmb_region memory; > > > struct lmb_region reserved; > > > -#if !IS_ENABLED(CONFIG_LMB_USE_MAX_REGIONS) > > > +#if IS_ENABLED(CONFIG_LMB) && !IS_ENABLED(CONFIG_LMB_USE_MAX_REGIONS) > > > struct lmb_property memory_regions[CONFIG_LMB_MEMORY_REGIONS]; > > > struct lmb_property reserved_regions[CONFIG_LMB_RESERVED_REGIONS]; > > > #endif > >=20 > > We shouldn't need this at all. LMB and LMB_USE_MAX_REGIONS are both in > > Kconfig and have the dependencies expressed that way. >=20 > However, CONFIG_LMB_MEMORY_REGIONS and CONFIG_LMB_RESERVED_REGIONS may be > undefined if CONFIG_LMB and !CONFIG_LMB_USE_MAX_REGIONS . They are four > different symbols. I'm still not seeing it, sorry. Is there some case where we're trying to access a struct lmb without CONFIG_LMB enabled? --=20 Tom --dI05wiOPtfTR8jth Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmEry5oACgkQFHw5/5Y0 tywa4Qv/X3lhAYWT22XDSAr8c0iHagFBkB/a+GUuS3356oM7yQXgbc9nze9gHQ9/ SlvEZA5FEP2rAl9YH5jxpn2Z4TlPvovBiyju54t3bCVO6kxSuIl/t8zUb2+6+U5h kxHzlZs4VRt5U8IuCtgAGOPsyT+I+WLtljUxEcm1Y28Ast1B7+TchMPu0oT4NnON cSIzkGsmwlWqbgrbiQfOwaYxmZxN/sCxD7rtgS+pWCWAVEbDaaHgvLhcf3VWrP28 iun73FXjgbs1MespxpgzHP0KkTwUTUYcqFrogxIdmnsKpcS6IVXaun6/3W7W2M3j gDnfZOa41mFhn48OdcN8kbv2f5OXDLDa6dp6n9j084fE5SBW3UlLXl+Jv5P/QZPA WJqusTg45G9s3PiiLf+m5b04s/fHPWXj7LpbnWQrrWj0l27Yd8qz1rXoB2TUdPaP r+K2CnJt25ZLcNrMpxvWbqbzlTotjD1RsPqWJ2/zI8HvB7Ret+S+LSzHc18ILa/D QMwXt/4m =j0YK -----END PGP SIGNATURE----- --dI05wiOPtfTR8jth--