From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2E5F2C432BE for ; Sun, 29 Aug 2021 22:24:10 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6153D60243 for ; Sun, 29 Aug 2021 22:24:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 6153D60243 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id AB73282D92; Mon, 30 Aug 2021 00:24:06 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="Piubuux9"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id AAA7583332; Mon, 30 Aug 2021 00:24:04 +0200 (CEST) Received: from mail-qt1-x82a.google.com (mail-qt1-x82a.google.com [IPv6:2607:f8b0:4864:20::82a]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id D7DE082D88 for ; Mon, 30 Aug 2021 00:23:59 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qt1-x82a.google.com with SMTP id d2so10229866qto.6 for ; Sun, 29 Aug 2021 15:23:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=Mcc9KBXZq4DtLWL1IO7oibyO6oeYbN60/U6KWZajL3o=; b=Piubuux9pbsWp3erT9zKEs8AtIbf0BLdaNQH0eC561StFxg0NsuhafGLBK/dN7WH6h lx9L9V+xSAO5OTHXZE8yqnxv/aCdfbVgJ7zIL6rN54GKG8KE9mMm74xxwadVrk9jPYJh XeIlj1t25er2/56BwQo2HkNm7O4LEDtJZXA4U= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=Mcc9KBXZq4DtLWL1IO7oibyO6oeYbN60/U6KWZajL3o=; b=JiGexRnyfPRwwWAJBH3ED1dtY2WKNhTPpQWHA4LZRvPKtWbVVHm2ouX7F06awcVhuz AuVhBcMjXel24Wt4L1MT/pKGGOWmUXvZxTUwjjOrFuqT08b/5EJJevulic2obnFtu9qn a/E38PWIAqpq/PVDrtcxhR+voh/xghT3+6mmmUl6RCYvbPQu3dA1G2g0DvLUrDS+mm3Q ObilmLaXzQucNCaFnkxPOroBmm2Kjp1/Oc1Frep5cXuOkns+3LepZ8LmUwaETQMl2Z3e ZP8GaJtrf9A1/T9GMxORJdprCD5I3alXaPbwxibEd7wNpZCs9MRn4LYIsTwLUrirPKa4 YU4Q== X-Gm-Message-State: AOAM530ooPQY58S4wfpXIcJE+k1JBoatHovHL8DL6TzB9eYSOFNypzuu pmFddQrBpN44KdIzHLdf/5xATg== X-Google-Smtp-Source: ABdhPJwXlrdzDmaV9y/ZHlD1KCHeaVEhvvbaYjjHGqApjcubsj4/ohHoEriPzjME5pE1lilfKmXIzA== X-Received: by 2002:a05:622a:38f:: with SMTP id j15mr17751661qtx.163.1630275838692; Sun, 29 Aug 2021 15:23:58 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b01-cbda-8054-417e-d97b-7576.res6.spectrum.com. [2603:6081:7b01:cbda:8054:417e:d97b:7576]) by smtp.gmail.com with ESMTPSA id v128sm10042685qkh.27.2021.08.29.15.23.57 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Sun, 29 Aug 2021 15:23:58 -0700 (PDT) Date: Sun, 29 Aug 2021 18:23:56 -0400 From: Tom Rini To: Marek Vasut Cc: u-boot@lists.denx.de, Simon Glass , Simon Goldschmidt Subject: Re: [PATCH 02/14] lmb: Use CONFIG_LMB_*_REGIONS only if they are defined Message-ID: <20210829222356.GL858@bill-the-cat> References: <20210815181314.132330-1-marek.vasut+renesas@gmail.com> <20210815181314.132330-2-marek.vasut+renesas@gmail.com> <20210815194721.GN858@bill-the-cat> <20210829180202.GG858@bill-the-cat> <20210829193239.GH858@bill-the-cat> <20210829221008.GK858@bill-the-cat> <0f735fc1-c331-ee13-4bbf-5be71d45fecd@denx.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="f9PRtQIM2AECiohz" Content-Disposition: inline In-Reply-To: <0f735fc1-c331-ee13-4bbf-5be71d45fecd@denx.de> X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.9.4 (2018-02-28) X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean --f9PRtQIM2AECiohz Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Aug 30, 2021 at 12:19:59AM +0200, Marek Vasut wrote: > On 8/30/21 12:10 AM, Tom Rini wrote: > > On Sun, Aug 29, 2021 at 11:47:58PM +0200, Marek Vasut wrote: > > > On 8/29/21 9:32 PM, Tom Rini wrote: > > > > On Sun, Aug 29, 2021 at 09:24:46PM +0200, Marek Vasut wrote: > > > > > On 8/29/21 8:02 PM, Tom Rini wrote: > > > > > > On Sun, Aug 29, 2021 at 06:26:23PM +0200, Marek Vasut wrote: > > > > > > > On 8/15/21 9:47 PM, Tom Rini wrote: > > > > > > > > On Sun, Aug 15, 2021 at 08:13:02PM +0200, Marek Vasut wrote: > > > > > > > >=20 > > > > > > > > > The CONFIG_LMB_*_REGIONS are defined only if CONFIG_LMB i= s enabled, > > > > > > > > > protect access to those two config options to avoid undef= ined macro > > > > > > > > > errors. > > > > > > > > >=20 > > > > > > > > > Signed-off-by: Marek Vasut > > > > > > > > > Cc: Simon Glass > > > > > > > > > Cc: Simon Goldschmidt > > > > > > > > > Cc: Tom Rini > > > > > > > > > --- > > > > > > > > > include/lmb.h | 4 ++-- > > > > > > > > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > > > > > >=20 > > > > > > > > > diff --git a/include/lmb.h b/include/lmb.h > > > > > > > > > index 3c4afdf9f0..fa1474a360 100644 > > > > > > > > > --- a/include/lmb.h > > > > > > > > > +++ b/include/lmb.h > > > > > > > > > @@ -44,7 +44,7 @@ struct lmb_property { > > > > > > > > > struct lmb_region { > > > > > > > > > unsigned long cnt; > > > > > > > > > unsigned long max; > > > > > > > > > -#if IS_ENABLED(CONFIG_LMB_USE_MAX_REGIONS) > > > > > > > > > +#if IS_ENABLED(CONFIG_LMB) && IS_ENABLED(CONFIG_LMB_USE_= MAX_REGIONS) > > > > > >=20 > > > > > > This doesn't make sense to me, still. You cannot enable > > > > > > CONFIG_LMB_USE_MAX_REGIONS without CONFIG_LMB as the former dep= ends on > > > > > > the latter in Kconfig. > > > > > >=20 > > > > > > > > > struct lmb_property region[CONFIG_LMB_MAX_REGIONS]; > > > > > > > > > #else > > > > > > > > > struct lmb_property *region; > > > > > > > > > @@ -67,7 +67,7 @@ struct lmb_region { > > > > > > > > > struct lmb { > > > > > > > > > struct lmb_region memory; > > > > > > > > > struct lmb_region reserved; > > > > > > > > > -#if !IS_ENABLED(CONFIG_LMB_USE_MAX_REGIONS) > > > > > > > > > +#if IS_ENABLED(CONFIG_LMB) && !IS_ENABLED(CONFIG_LMB_USE= _MAX_REGIONS) > > > > > > > > > struct lmb_property memory_regions[CONFIG_LMB_MEMOR= Y_REGIONS]; > > > > > > > > > struct lmb_property reserved_regions[CONFIG_LMB_RES= ERVED_REGIONS]; > > > > > > > > > #endif > > > > > > > >=20 > > > > > > > > We shouldn't need this at all. LMB and LMB_USE_MAX_REGIONS= are both in > > > > > > > > Kconfig and have the dependencies expressed that way. > > > > > > >=20 > > > > > > > However, CONFIG_LMB_MEMORY_REGIONS and CONFIG_LMB_RESERVED_RE= GIONS may be > > > > > > > undefined if CONFIG_LMB and !CONFIG_LMB_USE_MAX_REGIONS . The= y are four > > > > > > > different symbols. > > > > > >=20 > > > > > > I'm still not seeing it, sorry. Is there some case where we're= trying > > > > > > to access a struct lmb without CONFIG_LMB enabled? > > > > > >=20 > > > > >=20 > > > > > See build failure > > > > > https://source.denx.de/u-boot/custodians/u-boot-sh/-/jobs/315331 > > > >=20 > > > > Ah, progress. Drop from since we already have a > > > > forward declaration of struct lmb? But it's not failing without th= is > > > > series too, so what's changing? > > >=20 > > > See 01/14 in this series. > >=20 > > Ah, so drop 1/14 then. >=20 > Why ? That patch is correct. It's not quite right, 1/14 and then 2/14 are papering over the fact that lmb.h, and it's including headers / files, need to be cleaned up so that we don't need to have redundant tests in the header. --=20 Tom --f9PRtQIM2AECiohz Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmEsCPgACgkQFHw5/5Y0 tyxDLAv/Yjbr9usA9oKr7qHRJC/eQCv8mrSD3+s0NlR7Z0fcCBNPXmJXv6aQNnZX +X4TCXns4isQPGBlqHIs6vwpAkt+DOF/WHCfcKgCmKE6BtAKORATKhVKgS+PgTgn HYGwV/fiamhaeHSI4bG1IIr7zXEXWRgWXqj4Y94eGHQUoTM1An9DepB0RmndW37F dx6twcmp5MoHdF5BmJVpm3YLN0eJTSfB6saLjLgfUaTDmcNohvuS/92wkuDuTLUJ MaNH8lSH7tdFCSbP1iCGZq9eSnxKlieaR8Eb6lnEYzbMdEOX4CtuOg645xjLU2Q9 7VmWDJp1V3AXdxcYBYuS55O6+vOpvZh2qIfd5O3kdDBDopapJtv40xb+rBDQYahd rX8PnefMHnkH5KhtzaPNwFHGDYPLgz5f8MNg6A0L7U8Gghw9AzcqWGMALFAXSgm7 soxz3pkyq6LjRqJ3X6fM+SstzAwp21SYOh29I8dqGcgO77RtZzp7vfJQZT1v4Jri yWJgdnzR =KPKc -----END PGP SIGNATURE----- --f9PRtQIM2AECiohz--