From: Mel Gorman <mgorman@suse.com>
To: NeilBrown <neilb@suse.de>
Cc: Chuck Lever III <chuck.lever@oracle.com>,
Mike Javorski <mike.javorski@gmail.com>,
Linux NFS Mailing List <linux-nfs@vger.kernel.org>
Subject: Re: [PATCH] SUNRPC: don't pause on incomplete allocation
Date: Mon, 30 Aug 2021 10:12:08 +0100 [thread overview]
Message-ID: <20210830091208.GB3997@suse.com> (raw)
In-Reply-To: <163027659478.7591.8897815399981483759@noble.neil.brown.name>
On Mon, Aug 30, 2021 at 08:36:34AM +1000, NeilBrown wrote:
>
> alloc_pages_bulk_array() attempts to allocate at least one page based on
> the provided pages, and then opportunistically allocates more if that
> can be done without dropping the spinlock.
>
> So if it returns fewer than requested, that could just mean that it
> needed to drop the lock. In that case, try again immediately.
>
> Only pause for a time if no progress could be made.
>
> Reported-and-tested-by: Mike Javorski <mike.javorski@gmail.com>
> Reported-and-tested-by: Lothar Paltins <lopa@mailbox.org>
> Fixes: f6e70aab9dfe ("SUNRPC: refresh rq_pages using a bulk page allocator")
> Signed-off-by: NeilBrown <neilb@suse.de>
Acked-by: Mel Gorman <mgorman@suse.com>
--
Mel Gorman
SUSE Labs
next prev parent reply other threads:[~2021-08-30 9:12 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-08 22:37 NFS server regression in kernel 5.13 (tested w/ 5.13.9) Mike Javorski
2021-08-08 22:47 ` Chuck Lever III
2021-08-08 23:23 ` Mike Javorski
2021-08-09 0:01 ` NeilBrown
2021-08-09 0:28 ` Mike Javorski
2021-08-10 0:50 ` Mike Javorski
2021-08-10 1:28 ` NeilBrown
2021-08-10 11:54 ` Daire Byrne
2021-08-13 1:51 ` Mike Javorski
2021-08-13 2:39 ` NeilBrown
2021-08-13 2:53 ` Mike Javorski
2021-08-15 1:23 ` Mike Javorski
2021-08-16 1:20 ` NeilBrown
2021-08-16 13:21 ` Chuck Lever III
2021-08-16 16:25 ` Mike Javorski
2021-08-16 23:01 ` NeilBrown
2021-08-20 0:31 ` NeilBrown
2021-08-20 0:52 ` Mike Javorski
2021-08-22 0:17 ` Mike Javorski
2021-08-22 3:41 ` NeilBrown
2021-08-22 4:05 ` Mike Javorski
2021-08-22 22:00 ` NeilBrown
2021-08-26 19:34 ` Mike Javorski
2021-08-26 21:44 ` NeilBrown
2021-08-27 0:07 ` Mike Javorski
2021-08-27 5:27 ` NeilBrown
2021-08-27 6:11 ` Mike Javorski
2021-08-27 7:14 ` NeilBrown
2021-08-27 14:13 ` Chuck Lever III
2021-08-27 17:07 ` Mike Javorski
2021-08-27 22:00 ` Mike Javorski
2021-08-27 23:49 ` Chuck Lever III
2021-08-28 3:22 ` Mike Javorski
2021-08-28 18:23 ` Chuck Lever III
2021-08-29 22:28 ` [PATCH] MM: clarify effort used in alloc_pages_bulk_*() NeilBrown
2021-08-30 9:11 ` Mel Gorman
2021-08-29 22:36 ` [PATCH] SUNRPC: don't pause on incomplete allocation NeilBrown
2021-08-30 9:12 ` Mel Gorman [this message]
2021-08-30 20:46 ` J. Bruce Fields
2021-09-04 17:41 ` NFS server regression in kernel 5.13 (tested w/ 5.13.9) Mike Javorski
2021-09-05 2:02 ` Chuck Lever III
2021-09-16 2:45 ` Mike Javorski
2021-09-16 18:58 ` Chuck Lever III
2021-09-16 19:21 ` Mike Javorski
2021-09-17 14:41 ` J. Bruce Fields
2021-08-16 16:09 ` Mike Javorski
2021-08-16 23:04 ` NeilBrown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210830091208.GB3997@suse.com \
--to=mgorman@suse.com \
--cc=chuck.lever@oracle.com \
--cc=linux-nfs@vger.kernel.org \
--cc=mike.javorski@gmail.com \
--cc=neilb@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.