All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Sterba <dsterba@suse.cz>
To: li zhang <zhanglikernel@gmail.com>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] btrfs-progs: Fix the issues btrfs-convert don't recognition ext4  i_{a,c,a}time_extra
Date: Mon, 30 Aug 2021 11:34:51 +0200	[thread overview]
Message-ID: <20210830093451.GZ3379@suse.cz> (raw)
In-Reply-To: <20210828044117.GA29273@localhost.localdomain>

On Sat, Aug 28, 2021 at 12:41:19PM +0800, li zhang wrote:
> Is there any possibility that the version of the GNU build system caused
> the ./configure error
> to be generated? On my machine, I produced a valid ./configure, and my
> compilation
> environment is as follows:
> aclocal:    aclocal (GNU automake) 1.13.4
> autoconf:   autoconf (GNU Autoconf) 2.69
> autoheader: autoheader (GNU Autoconf) 2.69
> automake:   automake (GNU automake) 1.13.4
> OS: centos 7.6

You'd have to run the ./configure script or inspect it manually though
it could be hard to locate the lines in the generated script.

I get the following diff, the commas are interprted as shell commands.

--- configure-bad       2021-08-30 11:35:22.034446343 +0200
+++ configure-good      2021-08-30 11:34:19.130281370 +0200
@@ -6469,6 +6469,8 @@ else
   have_ext4_epoch_mask_define=no
 fi
 
+have_ext4_epoch_mask_define=no
+
 if test "x$have_ext4_epoch_mask_define" = xno; then :
 
     ac_fn_c_check_member "$LINENO" "struct ext2_inode_large" "i_atime_extra" "ac_cv_member_struct_ext2_inode_large_i_atime_extra" "#include <ext2fs/ext2_fs.h>
@@ -6482,16 +6484,16 @@ _ACEOF
 
 
 $as_echo "#define HAVE_EXT4_EPOCH_MASK_DEFINE 1" >>confdefs.h
-,
+
 
 $as_echo "#define EXT4_EPOCH_BITS 2" >>confdefs.h
-,
+
 
 $as_echo "#define EXT4_EPOCH_MASK ((1 << EXT4_EPOCH_BITS) - 1)" >>confdefs.h
-,
+
 
 $as_echo "#define EXT4_NSEC_MASK (~0UL << EXT4_EPOCH_BITS)" >>confdefs.h
-,
+
 
 $as_echo "#define inode_includes(size, field) (size >= (sizeof(((struct ext2_inode_large *)0)->field) + offsetof(struct ext2_inode_large, field)))" >>confdefs.h
--- 

  reply	other threads:[~2021-08-30  9:37 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-24 17:04 [PATCH] btrfs-progs: Fix the issues btrfs-convert don't recognition ext4 i_{a,c,a}time_extra Li Zhang
2021-08-26 18:34 ` David Sterba
2021-08-28  4:41   ` li zhang
2021-08-30  9:34     ` David Sterba [this message]
2021-08-28 15:16   ` li zhang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210830093451.GZ3379@suse.cz \
    --to=dsterba@suse.cz \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=zhanglikernel@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.