From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 10D44C432BE for ; Mon, 30 Aug 2021 08:42:21 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 96DF960FF2 for ; Mon, 30 Aug 2021 08:42:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 96DF960FF2 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=O1xqzeDHvXgtBeNd8DrJyeFh8Glgv4AQQAkA5B9YH84=; b=WseU1Ue1F1Z9qa ox/lwaYO2l5aBlMMHj4LqqySNcoABGDpA66ZqC79OeCIJimkAwQS9vaARnUc5mIejNMhuWkpc7I94 9+a1k3lnFIPG9gNDKNNBmPGyeBqi0rC9yHoun5B5ebwqTBPPitcCfC6lOQnwvEcU5U6X3MYYTVorG q0QTuf5Ap0EawP+7qgVcHgeBhF7QVaNfEf1Wss35YhkAzKjxBnH6chQC4alVvLOKs+ihkJTOMUSP/ DYEV9q49zZVYMqGj71+kqNbl7V2q+Ka3vYnlCWwfhJPCtH3Pw7FIhMaw6bIE0fBzViicib1tUjpmz XCIdY+aPiIlYGR+K+YuA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mKcrG-00GmGb-Cb; Mon, 30 Aug 2021 08:41:34 +0000 Received: from relay10.mail.gandi.net ([217.70.178.230]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mKcrD-00GmEm-1R for linux-mtd@lists.infradead.org; Mon, 30 Aug 2021 08:41:32 +0000 Received: (Authenticated sender: miquel.raynal@bootlin.com) by relay10.mail.gandi.net (Postfix) with ESMTPSA id A8274240012; Mon, 30 Aug 2021 08:41:23 +0000 (UTC) Date: Mon, 30 Aug 2021 10:41:22 +0200 From: Miquel Raynal To: Frieder Schrempf Cc: Frieder Schrempf , stable@vger.kernel.org, voice INTER connect GmbH , Alexander Lobakin , Felix Fietkau , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org, Richard Weinberger , YouChing Lin Subject: Re: [RESEND PATCH 5.10.x] mtd: spinand: Fix incorrect parameters for on-die ECC Message-ID: <20210830104122.58f9cdaf@xps13> In-Reply-To: <20210830072108.13770-1-frieder@fris.de> References: <20210830072108.13770-1-frieder@fris.de> Organization: Bootlin X-Mailer: Claws Mail 3.17.7 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210830_014131_395524_871645D1 X-CRM114-Status: GOOD ( 23.77 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org SGkgRnJpZWRlciwKCkZyaWVkZXIgU2NocmVtcGYgPGZyaWVkZXJAZnJpcy5kZT4gd3JvdGUgb24g TW9uLCAzMCBBdWcgMjAyMSAwOToyMTowNworMDIwMDoKCj4gRnJvbTogRnJpZWRlciBTY2hyZW1w ZiA8ZnJpZWRlci5zY2hyZW1wZkBrb250cm9uLmRlPgo+IAo+IFRoZSBuZXcgZ2VuZXJpYyBOQU5E IEVDQyBmcmFtZXdvcmsgc3RvcmVzIHRoZSBjb25maWd1cmF0aW9uIGFuZCByZXF1aXJlbWVudHMK PiBpbiBzZXBhcmF0ZSBwbGFjZXMgc2luY2UgY29tbWl0IDkzZWY5MmY2ZjQyMiAoIiBtdGQ6IG5h bmQ6IFVzZSB0aGUgbmV3IGdlbmVyaWMgRUNDIG9iamVjdCAiKS4KPiBJbiA1LjEwLnggVGhlIFNQ SSBOQU5EIGxheWVyIHN0aWxsIHVzZXMgb25seSB0aGUgcmVxdWlyZW1lbnRzIHRvIHRyYWNrIHRo ZSBFQ0MKPiBwcm9wZXJ0aWVzLiBUaGlzIG1pc21hdGNoIGxlYWRzIHRvIHZhbHVlcyBvZiB6ZXJv IGJlaW5nIHVzZWQgZm9yIEVDQyBzdHJlbmd0aAo+IGFuZCBzdGVwX3NpemUgaW4gdGhlIFNQSSBO QU5EIGxheWVyIHdoZXJldmVyIG5hbmRkZXZfZ2V0X2VjY19jb25mKCkgaXMgdXNlZCBhbmQKPiB0 aGVyZWZvcmUgYnJlYWtzIHRoZSBTUEkgTkFORCBvbi1kaWUgRUNDIHN1cHBvcnQgaW4gNS4xMC54 Lgo+IAo+IEJ5IHVzaW5nIG5hbmRkZXZfZ2V0X2VjY19yZXF1aXJlbWVudHMoKSBpbnN0ZWFkIG9m IG5hbmRkZXZfZ2V0X2VjY19jb25mKCkgZm9yCj4gU1BJIE5BTkQsIHdlIG1ha2Ugc3VyZSB0aGF0 IHRoZSBjb3JyZWN0IHBhcmFtZXRlcnMgZm9yIHRoZSBkZXRlY3RlZCBjaGlwIGFyZQo+IHVzZWQu IEluIGxhdGVyIHZlcnNpb25zICg1LjExLngpIHRoaXMgaXMgZml4ZWQgYW55d2F5IHdpdGggdGhl IGltcGxlbWVudGF0aW9uCj4gb2YgdGhlIFNQSSBOQU5EIG9uLWRpZSBFQ0MgZW5naW5lLgo+IAo+ IENjOiBzdGFibGVAdmdlci5rZXJuZWwub3JnICMgNS4xMC54Cj4gUmVwb3J0ZWQtYnk6IHZvaWNl IElOVEVSIGNvbm5lY3QgR21iSCA8ZGV2ZWxvcGVyQHZvaWNlaW50ZXJjb25uZWN0LmRlPgo+IFNp Z25lZC1vZmYtYnk6IEZyaWVkZXIgU2NocmVtcGYgPGZyaWVkZXIuc2NocmVtcGZAa29udHJvbi5k ZT4KCldoeSBub3QganVzdCByZXZlcnRpbmcgOWEzMzNhNzJjMWQwICgibXRkOiBzcGluYW5kOiBV c2UKbmFuZGRldl9nZXRfZWNjX2NvbmYoKSB3aGVuIHJlbGV2YW50Iik/IEkgdGhpbmsgdXNpbmcg dGhpcyAibmV3IgpuYW5kZGV2X2dldF9lY2NfcmVxdWlyZW1lbnRzKCkgaGVscGVyIGJlY2F1c2Ug aXQgZml0cyB0aGUgcHVycG9zZSBldmVuCmlmIGl0IGlzIHdyb25nIFsxXSBkb2Vzbid0IGJyaW5n IHRoZSByaWdodCBpbmZvcm1hdGlvbi4gSSBrbm93IGl0IGlzCnN0cmljdGx5IGVxdWl2YWxlbnQg YnV0IEkgd291bGQgcGVyc29uYWxseSBwcmVmZXIga2VlcGluZyB0aGUgb2xkCndyaXRpbmcgIm5h bmQtPmVjY3JlcS54eHh4Ii4KClsxXSBXZSBkb24ndCB3YW50IHRoZSByZXF1aXJlbWVudHMgYnV0 IHRoZSBhY3R1YWwgY3VycmVudCBjb25maWd1cmF0aW9uCmhlcmUsIHdoaWNoIHdhcyB0aGUgcHJp bWFyeSBwdXJwb3NlIG9mIHRoZSBpbml0aWFsIHBhdGNoIHdoaWNoIGVuZGVkCmJlaW5nIGEgbWlz dGFrZSBhdCB0aGF0IHBvaW50IGluIHRpbWUgYmVjYXVzZSB0aGUgU1BJLU5BTkQgY29yZSB3YXMg bm90CnJlYWR5IHlldC4KClRoYW5rcywKTWlxdcOobAoKPiAtLS0KPiBSZXNlbmRpbmcgdGhpcyB3 aXRoIGFuIGltcHJvdmVkIHN1YmplY3QgcHJlZml4IGFuZCBiZWNhdXNlIHRoZQo+IHByZXZpb3Vz IG1haWwgd2Fzbid0IGRlbGl2ZXJlZCB0byBzb21lIG9mIHRoZSBsaXN0cy4KPiAtLS0KPiAgZHJp dmVycy9tdGQvbmFuZC9zcGkvY29yZS5jICAgICB8IDYgKysrLS0tCj4gIGRyaXZlcnMvbXRkL25h bmQvc3BpL21hY3Jvbml4LmMgfCA2ICsrKy0tLQo+ICBkcml2ZXJzL210ZC9uYW5kL3NwaS90b3No aWJhLmMgIHwgNiArKystLS0KPiAgMyBmaWxlcyBjaGFuZ2VkLCA5IGluc2VydGlvbnMoKyksIDkg ZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvbXRkL25hbmQvc3BpL2NvcmUu YyBiL2RyaXZlcnMvbXRkL25hbmQvc3BpL2NvcmUuYwo+IGluZGV4IDU1OGQ4YTE0ODEwYi4uODc5 NGExZjZlYWNkIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvbXRkL25hbmQvc3BpL2NvcmUuYwo+ICsr KyBiL2RyaXZlcnMvbXRkL25hbmQvc3BpL2NvcmUuYwo+IEBAIC00MTksNyArNDE5LDcgQEAgc3Rh dGljIGludCBzcGluYW5kX2NoZWNrX2VjY19zdGF0dXMoc3RydWN0Cj4gc3BpbmFuZF9kZXZpY2Ug KnNwaW5hbmQsIHU4IHN0YXR1cykKPiAgCQkgKiBmaXhlZCwgc28gbGV0J3MgcmV0dXJuIHRoZSBt YXhpbXVtIHBvc3NpYmxlIHZhbHVlCj4gc28gdGhhdAo+ICAJCSAqIHdlYXItbGV2ZWxpbmcgbGF5 ZXJzIG1vdmUgdGhlIGRhdGEgaW1tZWRpYXRlbHkuCj4gIAkJICovCj4gLQkJcmV0dXJuIG5hbmRk ZXZfZ2V0X2VjY19jb25mKG5hbmQpLT5zdHJlbmd0aDsKPiArCQlyZXR1cm4gbmFuZGRldl9nZXRf ZWNjX3JlcXVpcmVtZW50cyhuYW5kKS0+c3RyZW5ndGg7Cj4gIAo+ICAJY2FzZSBTVEFUVVNfRUND X1VOQ09SX0VSUk9SOgo+ICAJCXJldHVybiAtRUJBRE1TRzsKPiBAQCAtMTA5MCw4ICsxMDkwLDgg QEAgc3RhdGljIGludCBzcGluYW5kX2luaXQoc3RydWN0IHNwaW5hbmRfZGV2aWNlCj4gKnNwaW5h bmQpIG10ZC0+b29iYXZhaWwgPSByZXQ7Cj4gIAo+ICAJLyogUHJvcGFnYXRlIEVDQyBpbmZvcm1h dGlvbiB0byBtdGRfaW5mbyAqLwo+IC0JbXRkLT5lY2Nfc3RyZW5ndGggPSBuYW5kZGV2X2dldF9l Y2NfY29uZihuYW5kKS0+c3RyZW5ndGg7Cj4gLQltdGQtPmVjY19zdGVwX3NpemUgPSBuYW5kZGV2 X2dldF9lY2NfY29uZihuYW5kKS0+c3RlcF9zaXplOwo+ICsJbXRkLT5lY2Nfc3RyZW5ndGggPQo+ IG5hbmRkZXZfZ2V0X2VjY19yZXF1aXJlbWVudHMobmFuZCktPnN0cmVuZ3RoOwo+ICsJbXRkLT5l Y2Nfc3RlcF9zaXplID0KPiBuYW5kZGV2X2dldF9lY2NfcmVxdWlyZW1lbnRzKG5hbmQpLT5zdGVw X3NpemU7IAo+ICAJcmV0dXJuIDA7Cj4gIAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL210ZC9uYW5k L3NwaS9tYWNyb25peC5jCj4gYi9kcml2ZXJzL210ZC9uYW5kL3NwaS9tYWNyb25peC5jIGluZGV4 IDhlODAxZTRjM2EwMC4uY2Q3YTljYWNjM2ZiCj4gMTAwNjQ0IC0tLSBhL2RyaXZlcnMvbXRkL25h bmQvc3BpL21hY3Jvbml4LmMKPiArKysgYi9kcml2ZXJzL210ZC9uYW5kL3NwaS9tYWNyb25peC5j Cj4gQEAgLTg0LDExICs4NCwxMSBAQCBzdGF0aWMgaW50IG14MzVsZjFnZTRhYl9lY2NfZ2V0X3N0 YXR1cyhzdHJ1Y3QKPiBzcGluYW5kX2RldmljZSAqc3BpbmFuZCwKPiAgCQkgKiBkYXRhIGFyb3Vu ZCBpZiBpdCdzIG5vdCBuZWNlc3NhcnkuCj4gIAkJICovCj4gIAkJaWYgKG14MzVsZjFnZTRhYl9n ZXRfZWNjc3Ioc3BpbmFuZCwgJmVjY3NyKSkKPiAtCQkJcmV0dXJuIG5hbmRkZXZfZ2V0X2VjY19j b25mKG5hbmQpLT5zdHJlbmd0aDsKPiArCQkJcmV0dXJuCj4gbmFuZGRldl9nZXRfZWNjX3JlcXVp cmVtZW50cyhuYW5kKS0+c3RyZW5ndGg7IAo+IC0JCWlmIChXQVJOX09OKGVjY3NyID4KPiBuYW5k ZGV2X2dldF9lY2NfY29uZihuYW5kKS0+c3RyZW5ndGggfHwKPiArCQlpZiAoV0FSTl9PTihlY2Nz ciA+Cj4gbmFuZGRldl9nZXRfZWNjX3JlcXVpcmVtZW50cyhuYW5kKS0+c3RyZW5ndGggfHwgIWVj Y3NyKSkKPiAtCQkJcmV0dXJuIG5hbmRkZXZfZ2V0X2VjY19jb25mKG5hbmQpLT5zdHJlbmd0aDsK PiArCQkJcmV0dXJuCj4gbmFuZGRldl9nZXRfZWNjX3JlcXVpcmVtZW50cyhuYW5kKS0+c3RyZW5n dGg7IAo+ICAJCXJldHVybiBlY2NzcjsKPiAgCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvbXRkL25h bmQvc3BpL3Rvc2hpYmEuYwo+IGIvZHJpdmVycy9tdGQvbmFuZC9zcGkvdG9zaGliYS5jIGluZGV4 IDIxZmRlMjg3NTY3NC4uNmZlN2JkMmE5NGQyCj4gMTAwNjQ0IC0tLSBhL2RyaXZlcnMvbXRkL25h bmQvc3BpL3Rvc2hpYmEuYwo+ICsrKyBiL2RyaXZlcnMvbXRkL25hbmQvc3BpL3Rvc2hpYmEuYwo+ IEBAIC05MCwxMiArOTAsMTIgQEAgc3RhdGljIGludCB0eDU4Y3hneHN4cmFpeF9lY2NfZ2V0X3N0 YXR1cyhzdHJ1Y3QKPiBzcGluYW5kX2RldmljZSAqc3BpbmFuZCwKPiAgCQkgKiBkYXRhIGFyb3Vu ZCBpZiBpdCdzIG5vdCBuZWNlc3NhcnkuCj4gIAkJICovCj4gIAkJaWYgKHNwaV9tZW1fZXhlY19v cChzcGluYW5kLT5zcGltZW0sICZvcCkpCj4gLQkJCXJldHVybiBuYW5kZGV2X2dldF9lY2NfY29u ZihuYW5kKS0+c3RyZW5ndGg7Cj4gKwkJCXJldHVybgo+IG5hbmRkZXZfZ2V0X2VjY19yZXF1aXJl bWVudHMobmFuZCktPnN0cmVuZ3RoOyAKPiAgCQltYmYgPj49IDQ7Cj4gIAo+IC0JCWlmIChXQVJO X09OKG1iZiA+Cj4gbmFuZGRldl9nZXRfZWNjX2NvbmYobmFuZCktPnN0cmVuZ3RoIHx8ICFtYmYp KQo+IC0JCQlyZXR1cm4gbmFuZGRldl9nZXRfZWNjX2NvbmYobmFuZCktPnN0cmVuZ3RoOwo+ICsJ CWlmIChXQVJOX09OKG1iZiA+Cj4gbmFuZGRldl9nZXRfZWNjX3JlcXVpcmVtZW50cyhuYW5kKS0+ c3RyZW5ndGggfHwgIW1iZikpCj4gKwkJCXJldHVybgo+IG5hbmRkZXZfZ2V0X2VjY19yZXF1aXJl bWVudHMobmFuZCktPnN0cmVuZ3RoOyAKPiAgCQlyZXR1cm4gbWJmOwo+ICAKCl9fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpMaW51eCBNVEQgZGlz Y3Vzc2lvbiBtYWlsaW5nIGxpc3QKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9s aXN0aW5mby9saW51eC1tdGQvCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EEE8FC4320A for ; Mon, 30 Aug 2021 08:41:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D090960FF2 for ; Mon, 30 Aug 2021 08:41:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234995AbhH3ImV convert rfc822-to-8bit (ORCPT ); Mon, 30 Aug 2021 04:42:21 -0400 Received: from relay10.mail.gandi.net ([217.70.178.230]:43889 "EHLO relay10.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233162AbhH3ImU (ORCPT ); Mon, 30 Aug 2021 04:42:20 -0400 Received: (Authenticated sender: miquel.raynal@bootlin.com) by relay10.mail.gandi.net (Postfix) with ESMTPSA id A8274240012; Mon, 30 Aug 2021 08:41:23 +0000 (UTC) Date: Mon, 30 Aug 2021 10:41:22 +0200 From: Miquel Raynal To: Frieder Schrempf Cc: Frieder Schrempf , stable@vger.kernel.org, voice INTER connect GmbH , Alexander Lobakin , Felix Fietkau , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org, Richard Weinberger , YouChing Lin Subject: Re: [RESEND PATCH 5.10.x] mtd: spinand: Fix incorrect parameters for on-die ECC Message-ID: <20210830104122.58f9cdaf@xps13> In-Reply-To: <20210830072108.13770-1-frieder@fris.de> References: <20210830072108.13770-1-frieder@fris.de> Organization: Bootlin X-Mailer: Claws Mail 3.17.7 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Frieder, Frieder Schrempf wrote on Mon, 30 Aug 2021 09:21:07 +0200: > From: Frieder Schrempf > > The new generic NAND ECC framework stores the configuration and requirements > in separate places since commit 93ef92f6f422 (" mtd: nand: Use the new generic ECC object "). > In 5.10.x The SPI NAND layer still uses only the requirements to track the ECC > properties. This mismatch leads to values of zero being used for ECC strength > and step_size in the SPI NAND layer wherever nanddev_get_ecc_conf() is used and > therefore breaks the SPI NAND on-die ECC support in 5.10.x. > > By using nanddev_get_ecc_requirements() instead of nanddev_get_ecc_conf() for > SPI NAND, we make sure that the correct parameters for the detected chip are > used. In later versions (5.11.x) this is fixed anyway with the implementation > of the SPI NAND on-die ECC engine. > > Cc: stable@vger.kernel.org # 5.10.x > Reported-by: voice INTER connect GmbH > Signed-off-by: Frieder Schrempf Why not just reverting 9a333a72c1d0 ("mtd: spinand: Use nanddev_get_ecc_conf() when relevant")? I think using this "new" nanddev_get_ecc_requirements() helper because it fits the purpose even if it is wrong [1] doesn't bring the right information. I know it is strictly equivalent but I would personally prefer keeping the old writing "nand->eccreq.xxxx". [1] We don't want the requirements but the actual current configuration here, which was the primary purpose of the initial patch which ended being a mistake at that point in time because the SPI-NAND core was not ready yet. Thanks, Miquèl > --- > Resending this with an improved subject prefix and because the > previous mail wasn't delivered to some of the lists. > --- > drivers/mtd/nand/spi/core.c | 6 +++--- > drivers/mtd/nand/spi/macronix.c | 6 +++--- > drivers/mtd/nand/spi/toshiba.c | 6 +++--- > 3 files changed, 9 insertions(+), 9 deletions(-) > > diff --git a/drivers/mtd/nand/spi/core.c b/drivers/mtd/nand/spi/core.c > index 558d8a14810b..8794a1f6eacd 100644 > --- a/drivers/mtd/nand/spi/core.c > +++ b/drivers/mtd/nand/spi/core.c > @@ -419,7 +419,7 @@ static int spinand_check_ecc_status(struct > spinand_device *spinand, u8 status) > * fixed, so let's return the maximum possible value > so that > * wear-leveling layers move the data immediately. > */ > - return nanddev_get_ecc_conf(nand)->strength; > + return nanddev_get_ecc_requirements(nand)->strength; > > case STATUS_ECC_UNCOR_ERROR: > return -EBADMSG; > @@ -1090,8 +1090,8 @@ static int spinand_init(struct spinand_device > *spinand) mtd->oobavail = ret; > > /* Propagate ECC information to mtd_info */ > - mtd->ecc_strength = nanddev_get_ecc_conf(nand)->strength; > - mtd->ecc_step_size = nanddev_get_ecc_conf(nand)->step_size; > + mtd->ecc_strength = > nanddev_get_ecc_requirements(nand)->strength; > + mtd->ecc_step_size = > nanddev_get_ecc_requirements(nand)->step_size; > return 0; > > diff --git a/drivers/mtd/nand/spi/macronix.c > b/drivers/mtd/nand/spi/macronix.c index 8e801e4c3a00..cd7a9cacc3fb > 100644 --- a/drivers/mtd/nand/spi/macronix.c > +++ b/drivers/mtd/nand/spi/macronix.c > @@ -84,11 +84,11 @@ static int mx35lf1ge4ab_ecc_get_status(struct > spinand_device *spinand, > * data around if it's not necessary. > */ > if (mx35lf1ge4ab_get_eccsr(spinand, &eccsr)) > - return nanddev_get_ecc_conf(nand)->strength; > + return > nanddev_get_ecc_requirements(nand)->strength; > - if (WARN_ON(eccsr > > nanddev_get_ecc_conf(nand)->strength || > + if (WARN_ON(eccsr > > nanddev_get_ecc_requirements(nand)->strength || !eccsr)) > - return nanddev_get_ecc_conf(nand)->strength; > + return > nanddev_get_ecc_requirements(nand)->strength; > return eccsr; > > diff --git a/drivers/mtd/nand/spi/toshiba.c > b/drivers/mtd/nand/spi/toshiba.c index 21fde2875674..6fe7bd2a94d2 > 100644 --- a/drivers/mtd/nand/spi/toshiba.c > +++ b/drivers/mtd/nand/spi/toshiba.c > @@ -90,12 +90,12 @@ static int tx58cxgxsxraix_ecc_get_status(struct > spinand_device *spinand, > * data around if it's not necessary. > */ > if (spi_mem_exec_op(spinand->spimem, &op)) > - return nanddev_get_ecc_conf(nand)->strength; > + return > nanddev_get_ecc_requirements(nand)->strength; > mbf >>= 4; > > - if (WARN_ON(mbf > > nanddev_get_ecc_conf(nand)->strength || !mbf)) > - return nanddev_get_ecc_conf(nand)->strength; > + if (WARN_ON(mbf > > nanddev_get_ecc_requirements(nand)->strength || !mbf)) > + return > nanddev_get_ecc_requirements(nand)->strength; > return mbf; >