From: Dan Carpenter <dan.carpenter@oracle.com>
To: Kari Argillander <kari.argillander@gmail.com>
Cc: Saurav Girepunje <saurav.girepunje@gmail.com>,
Larry.Finger@lwfinger.net, phil@philpotter.co.uk,
gregkh@linuxfoundation.org, fabioaiuto83@gmail.com,
straube.linux@gmail.com, ross.schm.dev@gmail.com,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
saurav.girepunje@hotmail.com
Subject: Re: [PATCH v4] staging: r8188eu: core: remove null check before vfree
Date: Mon, 30 Aug 2021 14:23:42 +0300 [thread overview]
Message-ID: <20210830112342.GF12231@kadam> (raw)
In-Reply-To: <20210829171351.u63zoaqa3x5qfodt@kari-VirtualBox>
On Sun, Aug 29, 2021 at 08:13:51PM +0300, Kari Argillander wrote:
> On Sun, Aug 29, 2021 at 10:30:09PM +0530, Saurav Girepunje wrote:
> > Remove NULL check. NULL check before freeing function is not needed.
> > Correct the indentation.
> >
> > Signed-off-by: Saurav Girepunje <saurav.girepunje@gmail.com>
> > ---
> >
> > ChangeLog V4:
> > - Add Change log below --- line
> >
> > ChangeLog V3:
> > - Add change log.
> >
> > ChangeLog V2:
> > - Correct the indentation.
>
> You need "---" here also.
>
No. It works fine. I applied it myself with `git am` just to be 100%
sure in case I was missing something.
regards,
dan carpenter
next prev parent reply other threads:[~2021-08-30 11:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-29 17:00 [PATCH v4] staging: r8188eu: core: remove null check before vfree Saurav Girepunje
2021-08-29 17:13 ` Kari Argillander
2021-08-30 11:23 ` Dan Carpenter [this message]
2021-08-30 11:25 ` Dan Carpenter
2021-09-04 6:00 ` SAURAV GIREPUNJE
2021-08-30 12:09 ` Michael Straube
2021-09-04 5:58 ` SAURAV GIREPUNJE
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210830112342.GF12231@kadam \
--to=dan.carpenter@oracle.com \
--cc=Larry.Finger@lwfinger.net \
--cc=fabioaiuto83@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=kari.argillander@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=phil@philpotter.co.uk \
--cc=ross.schm.dev@gmail.com \
--cc=saurav.girepunje@gmail.com \
--cc=saurav.girepunje@hotmail.com \
--cc=straube.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.