From: John Arbuckle <programmingkidx@gmail.com>
To: groug@kaod.org, david@gibson.dropbear.id.au, qemu-ppc@nongnu.org,
qemu-devel@nongnu.org, hsp.cat7@gmail.com,
mark.cave-ayland@ilande.co.uk, peter.maydell@linaro.org
Cc: John Arbuckle <programmingkidx@gmail.com>
Subject: [PATCH v2] Report any problems with loading the VGA driver for Macintosh targets
Date: Mon, 30 Aug 2021 09:39:45 -0400 [thread overview]
Message-ID: <20210830133945.11264-1-programmingkidx@gmail.com> (raw)
I was having a problem with missing video resolutions in my Mac OS 9 VM. When I
ran QEMU it gave no indication as to why these resolutions were missing. I found
out that the OpenFirmware VGA driver was not being loaded. To prevent anyone from
going thru the same trouble I went thru I added messages that the user can see
when a problem takes place with loading this driver in the future.
Signed-off-by: John Arbuckle <programmingkidx@gmail.com>
---
v2 changes:
- Replaced printf() with warn_report().
- Removed newline characters from messages.
hw/ppc/mac_newworld.c | 6 ++++++
hw/ppc/mac_oldworld.c | 6 ++++++
2 files changed, 12 insertions(+)
diff --git a/hw/ppc/mac_newworld.c b/hw/ppc/mac_newworld.c
index 7bb7ac3997..19a142cfe5 100644
--- a/hw/ppc/mac_newworld.c
+++ b/hw/ppc/mac_newworld.c
@@ -526,8 +526,14 @@ static void ppc_core99_init(MachineState *machine)
if (g_file_get_contents(filename, &ndrv_file, &ndrv_size, NULL)) {
fw_cfg_add_file(fw_cfg, "ndrv/qemu_vga.ndrv", ndrv_file, ndrv_size);
+ } else {
+ warn_report("failed to load driver %s. This may cause video"
+ " problems.", NDRV_VGA_FILENAME);
}
g_free(filename);
+ } else {
+ warn_report("driver %s not found. This may cause video problems.",
+ NDRV_VGA_FILENAME);
}
qemu_register_boot_set(fw_cfg_boot_set, fw_cfg);
diff --git a/hw/ppc/mac_oldworld.c b/hw/ppc/mac_oldworld.c
index de2be960e6..041ccebe25 100644
--- a/hw/ppc/mac_oldworld.c
+++ b/hw/ppc/mac_oldworld.c
@@ -367,8 +367,14 @@ static void ppc_heathrow_init(MachineState *machine)
if (g_file_get_contents(filename, &ndrv_file, &ndrv_size, NULL)) {
fw_cfg_add_file(fw_cfg, "ndrv/qemu_vga.ndrv", ndrv_file, ndrv_size);
+ } else {
+ warn_report("failed to load driver %s. This may cause video "
+ "problems.", NDRV_VGA_FILENAME);
}
g_free(filename);
+ } else {
+ warn_report("driver %s not found. This may cause video problems.",
+ NDRV_VGA_FILENAME);
}
qemu_register_boot_set(fw_cfg_boot_set, fw_cfg);
--
2.24.3 (Apple Git-128)
reply other threads:[~2021-08-30 13:41 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210830133945.11264-1-programmingkidx@gmail.com \
--to=programmingkidx@gmail.com \
--cc=david@gibson.dropbear.id.au \
--cc=groug@kaod.org \
--cc=hsp.cat7@gmail.com \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.