Re: [PATCH 1/2] storage-daemon: add opt to print when initialized

["Michael S. Tsirkin" <mst@redhat.com>]

On Mon, Aug 30, 2021 at 11:05:35AM -0500, eblake@redhat.com wrote:
> On Mon, Aug 30, 2021 at 03:56:16PM +0000, Raphael Norwitz wrote:
> > On Fri, Aug 27, 2021 at 01:51:48PM -0500, eblake@redhat.com wrote:
> > > On Fri, Aug 27, 2021 at 04:50:35PM +0000, Raphael Norwitz wrote:
> > > > This change adds a command line option to print a line to standard out
> > > > when the storage daemon has completed initialization and is ready to
> > > > serve client connections.
> > > > 
> > > > This option will be used to resolve a hang in the vhost-user-blk-test.
> > >  
> > > Doesn't the existing --pidfile already serve the same job?  That is,
> > > why not fix vhost-user-blk-test to take advantage of the pid-file
> > > creation rather than output to stdout as evidence of when the storage
> > > daemon is up and running?
> > > 
> > > Therefore, I don't think we need this patch.
> > >
> > 
> > Sure - that make sense. I didn't use the pid-file because I didn't want to
> > risk leaving junk on the filesystem if the storage-daemon crashed.
> 
> Ideally, storage-daemon doesn't crash during the test.  But even if it
> does, we should still be able to register which files will be cleaned
> up while exiting the test (if they exist), regardless of whether the
> test succeeded or failed, because we have control over the pidfile
> name before starting storage-daemon.  Put another way, the task of
> cleaning up a pidfile during a test should not be a show-stopper.
> 
> [Side note: A long time ago, there were patches submitted to make the
> iotests ./check engine run EVERY test in its own subdirectory, so that
> cleaning up all files created by the test was trivial: nuke the
> directory.  It also has the benefit that for debugging a failing test,
> you merely pass an option to ./check that says to not nuke the
> directory.  But it did not get applied at the time, and we have had
> enough changes in the meantime that reinstating such a useful patch
> would basically be work from scratch at this point]


Yea I had that thought too. Pity it got lost.

> > 
> > I'll send a V2 using pid-file without this change.
> 
> Thanks, looking forward to it.
> 
> -- 
> Eric Blake, Principal Software Engineer
> Red Hat, Inc.           +1-919-301-3266
> Virtualization:  qemu.org | libvirt.org