All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: Damien Le Moal <Damien.LeMoal@wdc.com>
Cc: Alistair Francis <alistair@alistair23.me>,
	"Yann E . MORIN" <yann.morin.1998@free.fr>,
	buildroot <buildroot@buildroot.org>
Subject: Re: [Buildroot] [PATCH v4 0/9] Add RV64 NOMMU and Canaan K210 SoC support
Date: Mon, 30 Aug 2021 23:55:59 +0200	[thread overview]
Message-ID: <20210830235559.795cf97f@windsurf> (raw)
In-Reply-To: <DM6PR04MB70813B0A7EC96D8CE9D4B79FE7CB9@DM6PR04MB7081.namprd04.prod.outlook.com>

Hello Damien,

On Mon, 30 Aug 2021 21:42:02 +0000
Damien Le Moal <Damien.LeMoal@wdc.com> wrote:

> On 2021/08/31 6:32, Thomas Petazzoni wrote:
> > Hello Damien,
> > 
> > On Mon, 30 Aug 2021 13:40:51 +0900
> > Damien Le Moal <damien.lemoal@wdc.com> wrote:
> >   
> >> Christoph Hellwig (2):
> >>   package/elf2flt: add RISC-V 64-bits support
> >>   package/Makefile.in: Fix NOMMU RISC-V 64-bits toolchain base name
> >>
> >> Damien Le Moal (7):
> >>   arch/config: Make RISC-V 64-bits MMU optional  
> > 
> > Just tested with the first 3 patches applied the following defconfig:
> > 
> > BR2_riscv=y
> > # BR2_USE_MMU is not set
> > 
> > It fails to build with:
> > 
> > /home/thomas/buildroot/buildroot/output/host/riscv64-buildroot-linux-uclibc/bin/elf2flt: Loading to RAM ('-r' option) 
> > is required  
> 
> Yes, this option is mandatory for rv64. The elf2flt patch checks for it, but
> only for rv64. Other architectures should not be affected.
> The following patch that adds the Sipeed MAIX bit board support adds that option
> to busybox build. So I guess that build option should be moved to this patch ?

I see:

+CONFIG_EXTRA_LDFLAGS="-Os -static -Wl,-elf2flt=-r"

in your Busybox configuration file indeed. But what about other
packages ?

If this is needed for all packages built for RISC-V 64-bit noMMU, then
we need to have it set as part of the toolchain wrapper. Actually, the
toolchain wrapper already passes -Wl,-elf2flt, so it would only have to
be tweaked to pass -Wl,-elf2flt=-r instead.

See:

#ifdef BR_BINFMT_FLAT
        "-Wl,-elf2flt",
#endif

in toolchain/toolchain-wrapper.c

Best regards,

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

  reply	other threads:[~2021-08-30 21:56 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-30  4:40 [Buildroot] [PATCH v4 0/9] Add RV64 NOMMU and Canaan K210 SoC support Damien Le Moal
2021-08-30  4:40 ` [Buildroot] [PATCH v4 1/9] package/elf2flt: add RISC-V 64-bits support Damien Le Moal
2021-08-30  4:40 ` [Buildroot] [PATCH v4 2/9] package/Makefile.in: Fix NOMMU RISC-V 64-bits toolchain base name Damien Le Moal
2021-08-30  4:40 ` [Buildroot] [PATCH v4 3/9] arch/config: Make RISC-V 64-bits MMU optional Damien Le Moal
2021-08-30  4:40 ` [Buildroot] [PATCH v4 4/9] board: Add Sipeed MAIX-bit support Damien Le Moal
2021-08-30  4:40 ` [Buildroot] [PATCH v4 5/9] board: Add Sipeed MAIX-Go support Damien Le Moal
2021-08-30  4:40 ` [Buildroot] [PATCH v4 6/9] board: Add Sipeed MAIXDUINO support Damien Le Moal
2021-08-30  4:40 ` [Buildroot] [PATCH v4 7/9] board: Add Sipeed MAIX-Dock support Damien Le Moal
2021-08-30  4:40 ` [Buildroot] [PATCH v4 8/9] board: Add Canaan KD233 support Damien Le Moal
2021-08-30  4:41 ` [Buildroot] [PATCH v4 9/9] board: Document Canaan K210 based boards support Damien Le Moal
2021-08-30 21:32 ` [Buildroot] [PATCH v4 0/9] Add RV64 NOMMU and Canaan K210 SoC support Thomas Petazzoni
2021-08-30 21:42   ` Damien Le Moal
2021-08-30 21:55     ` Thomas Petazzoni [this message]
2021-08-30 21:59       ` Damien Le Moal
2021-08-30 21:52   ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210830235559.795cf97f@windsurf \
    --to=thomas.petazzoni@bootlin.com \
    --cc=Damien.LeMoal@wdc.com \
    --cc=alistair@alistair23.me \
    --cc=buildroot@buildroot.org \
    --cc=yann.morin.1998@free.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.