Re: [PATCH v12 05/13] vdpa: Add reset callback in vdpa_config_ops

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 4427 bytes --]

Hi Xie,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on vhost/linux-next]
[cannot apply to iommu/next lwn/docs-next linus/master v5.14 next-20210830]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Xie-Yongji/Introduce-VDUSE-vDPA-Device-in-Userspace/20210830-222539
base:   https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git linux-next
config: arc-allyesconfig (attached as .config)
compiler: arceb-elf-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/6e5e4d1644120efbf84d53cdf478d49e59643259
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Xie-Yongji/Introduce-VDUSE-vDPA-Device-in-Userspace/20210830-222539
        git checkout 6e5e4d1644120efbf84d53cdf478d49e59643259
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross ARCH=arc 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

   drivers/vdpa/ifcvf/ifcvf_main.c: In function 'ifcvf_vdpa_reset':
>> drivers/vdpa/ifcvf/ifcvf_main.c:257:9: warning: this 'if' clause does not guard... [-Wmisleading-indentation]
     257 |         if (status_old & VIRTIO_CONFIG_S_DRIVER_OK)
         |         ^~
   drivers/vdpa/ifcvf/ifcvf_main.c:259:17: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'if'
     259 |                 ifcvf_free_irq(adapter, vf->nr_vring);
         |                 ^~~~~~~~~~~~~~
   drivers/vdpa/ifcvf/ifcvf_main.c: At top level:
>> drivers/vdpa/ifcvf/ifcvf_main.c:262:9: warning: data definition has no type or storage class
     262 |         ifcvf_reset_vring(adapter);
         |         ^~~~~~~~~~~~~~~~~
   drivers/vdpa/ifcvf/ifcvf_main.c:262:9: error: type defaults to 'int' in declaration of 'ifcvf_reset_vring' [-Werror=implicit-int]
>> drivers/vdpa/ifcvf/ifcvf_main.c:262:9: warning: parameter names (without types) in function declaration
   drivers/vdpa/ifcvf/ifcvf_main.c:262:9: error: conflicting types for 'ifcvf_reset_vring'; have 'int()'
   drivers/vdpa/ifcvf/ifcvf_main.c:142:13: note: previous definition of 'ifcvf_reset_vring' with type 'void(struct ifcvf_adapter *)'
     142 | static void ifcvf_reset_vring(struct ifcvf_adapter *adapter)
         |             ^~~~~~~~~~~~~~~~~
   drivers/vdpa/ifcvf/ifcvf_main.c:264:9: error: expected identifier or '(' before 'return'
     264 |         return 0;
         |         ^~~~~~
   drivers/vdpa/ifcvf/ifcvf_main.c:265:1: error: expected identifier or '(' before '}' token
     265 | }
         | ^
   drivers/vdpa/ifcvf/ifcvf_main.c: In function 'ifcvf_vdpa_reset':
   drivers/vdpa/ifcvf/ifcvf_main.c:260:9: error: control reaches end of non-void function [-Werror=return-type]
     260 |         }
         |         ^
   At top level:
   drivers/vdpa/ifcvf/ifcvf_main.c:142:13: warning: 'ifcvf_reset_vring' defined but not used [-Wunused-function]
     142 | static void ifcvf_reset_vring(struct ifcvf_adapter *adapter)
         |             ^~~~~~~~~~~~~~~~~
   cc1: some warnings being treated as errors


vim +/if +257 drivers/vdpa/ifcvf/ifcvf_main.c

   243	
   244	static int ifcvf_vdpa_reset(struct vdpa_device *vdpa_dev)
   245	{
   246		struct ifcvf_adapter *adapter;
   247		struct ifcvf_hw *vf;
   248		u8 status_old;
   249	
   250		vf  = vdpa_to_vf(vdpa_dev);
   251		adapter = vdpa_to_adapter(vdpa_dev);
   252		status_old = ifcvf_get_status(vf);
   253	
   254		if (status_old == 0)
   255			return 0;
   256	
 > 257		if (status_old & VIRTIO_CONFIG_S_DRIVER_OK)
   258			ifcvf_stop_datapath(adapter);
   259			ifcvf_free_irq(adapter, vf->nr_vring);
   260		}
   261	
 > 262		ifcvf_reset_vring(adapter);
   263	
   264		return 0;
   265	}
   266	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 68444 bytes --]