From: Tom Rini <trini@konsulko.com>
To: "Pali Rohár" <pali@kernel.org>
Cc: "Stefan Roese" <sr@denx.de>,
"Frank Wunderlich" <frank-w@public-files.de>,
"Masami Hiramatsu" <masami.hiramatsu@linaro.org>,
"Simon Glass" <sjg@chromium.org>,
"Marek Behún" <marek.behun@nic.cz>,
u-boot@lists.denx.de
Subject: Re: [PATCH 2/2] ata: ahci-pci: Add new option CONFIG_SPL_AHCI_PCI
Date: Thu, 2 Sep 2021 09:29:40 -0400 [thread overview]
Message-ID: <20210902132940.GI858@bill-the-cat> (raw)
In-Reply-To: <20210815142737.16992-2-pali@kernel.org>
[-- Attachment #1: Type: text/plain, Size: 1407 bytes --]
On Sun, Aug 15, 2021 at 04:27:37PM +0200, Pali Rohár wrote:
> This new option allows to disable ahci-pci driver in SPL. Disabling it is
> needed when SPL_PCI is not enabled as ahci-pci depends on PCI.
>
> This change fixes following compile error when CONFIG_SPL_SATA_SUPPORT is
> enabled and SPL_PCI is disabled.
>
> LD spl/u-boot-spl
> arm-linux-gnueabihf-ld.bfd: drivers/ata/ahci.o: in function `ahci_probe_scsi_pci':
> drivers/ata/ahci.c:1205: undefined reference to `dm_pci_map_bar'
> arm-linux-gnueabihf-ld.bfd: drivers/ata/ahci.c:1215: undefined reference to `dm_pci_read_config16'
> arm-linux-gnueabihf-ld.bfd: drivers/ata/ahci.c:1216: undefined reference to `dm_pci_read_config16'
> arm-linux-gnueabihf-ld.bfd: drivers/ata/ahci.c:1220: undefined reference to `dm_pci_map_bar'
> make[1]: *** [scripts/Makefile.spl:512: spl/u-boot-spl] Error 1
> make: *** [Makefile:1977: spl/u-boot-spl] Error 2
>
> LD spl/u-boot-spl
> arm-linux-gnueabihf-ld.bfd: drivers/ata/ahci-pci.o: in function `ahci_pci_probe':
> drivers/ata/ahci-pci.c:21: undefined reference to `ahci_probe_scsi_pci'
> make[1]: *** [scripts/Makefile.spl:512: spl/u-boot-spl] Error 1
> make: *** [Makefile:1977: spl/u-boot-spl] Error 2
>
> Signed-off-by: Pali Rohár <pali@kernel.org>
> Reviewed-by: Stefan Roese <sr@denx.de>
Applied to u-boot/next, thanks!
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
next prev parent reply other threads:[~2021-09-02 13:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-15 14:27 [PATCH 1/2] ata: ahci-pci: Fix dependency on DM_PCI Pali Rohár
2021-08-15 14:27 ` [PATCH 2/2] ata: ahci-pci: Add new option CONFIG_SPL_AHCI_PCI Pali Rohár
2021-08-16 7:57 ` Stefan Roese
2021-09-02 13:29 ` Tom Rini [this message]
2021-08-16 7:57 ` [PATCH 1/2] ata: ahci-pci: Fix dependency on DM_PCI Stefan Roese
2021-09-02 13:29 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210902132940.GI858@bill-the-cat \
--to=trini@konsulko.com \
--cc=frank-w@public-files.de \
--cc=marek.behun@nic.cz \
--cc=masami.hiramatsu@linaro.org \
--cc=pali@kernel.org \
--cc=sjg@chromium.org \
--cc=sr@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.