All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Huth <thuth@redhat.com>
To: qemu-devel@nongnu.org, Paolo Bonzini <pbonzini@redhat.com>
Cc: "Marc-André Lureau" <marcandre.lureau@redhat.com>,
	"Eric Blake" <eblake@redhat.com>
Subject: [PATCH v2 0/5] Use meson_options.txt in the configure script
Date: Fri,  3 Sep 2021 10:13:53 +0200	[thread overview]
Message-ID: <20210903081358.956267-1-thuth@redhat.com> (raw)

It's cumbersome to maintain the build options twice, one time in the
configure script and one time in meson_options.txt. Thus let's add some
logic to the configure script to look at the meson_options.txt file
instead of handling every option twice.

Note: Unlike Paolo's earlier version (which can bee found on
https://patchew.org/QEMU/20210107140039.467969-1-pbonzini@redhat.com/ ),
this version only uses some lines of shell code to parse meson_options.txt
instead of adding an additional Python or Perl script. It's likely not
as robust as Paolo's version, but it's way smaller and has a way nicer
diffstat.

v2:
 - Improved shell code according to the suggestions of Eric
 - Split the vnc change into a separate patch
 - Add a comment to meson_options.txt in the new final patch

Thomas Huth (5):
  configure: Add the possibility to read options from meson_options.txt
  meson_options.txt: Switch the default value for the vnc option to
    'auto'
  configure: Remove options that can be handled via meson_options.txt
    instead
  configure: Get help text from meson_options.txt
  meson_options.txt: Document that "configure" reads this file, too

 configure         | 435 +++++++---------------------------------------
 meson_options.txt |   8 +-
 2 files changed, 65 insertions(+), 378 deletions(-)

-- 
2.27.0



             reply	other threads:[~2021-09-03  8:16 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-03  8:13 Thomas Huth [this message]
2021-09-03  8:13 ` [PATCH v2 1/5] configure: Add the possibility to read options from meson_options.txt Thomas Huth
2021-09-03 17:09   ` Eric Blake
2021-09-03  8:13 ` [PATCH v2 2/5] meson_options.txt: Switch the default value for the vnc option to 'auto' Thomas Huth
2021-09-03 17:18   ` Eric Blake
2021-09-28  9:32   ` Paolo Bonzini
2021-09-03  8:13 ` [PATCH v2 3/5] configure: Remove options that can be handled via meson_options.txt instead Thomas Huth
2021-09-03  8:13 ` [PATCH v2 4/5] configure: Get help text from meson_options.txt Thomas Huth
2021-09-03 17:20   ` Eric Blake
2021-09-03  8:13 ` [PATCH v2 5/5] meson_options.txt: Document that "configure" reads this file, too Thomas Huth
2021-09-03 17:25   ` Eric Blake

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210903081358.956267-1-thuth@redhat.com \
    --to=thuth@redhat.com \
    --cc=eblake@redhat.com \
    --cc=marcandre.lureau@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.