From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============4773310968396245468==" MIME-Version: 1.0 From: kernel test robot Subject: [PATCH] coccinelle: misc: fix swap.cocci warnings Date: Fri, 03 Sep 2021 22:17:14 +0800 Message-ID: <20210903141714.GA25234@05eaed123dd8> In-Reply-To: <202109032239.GxQeFP15-lkp@intel.com> List-Id: To: kbuild@lists.01.org --===============4773310968396245468== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable CC: kbuild-all(a)lists.01.org CC: linux-kernel(a)vger.kernel.org TO: Denis Efremov CC: Julia Lawall CC: linux-ia64(a)vger.kernel.org CC: linux-kernel(a)vger.kernel.org From: kernel test robot arch/ia64/kernel/setup.c:213:39-40: WARNING opportunity for swap() Check for opencoded swap() implementation. Generated by: scripts/coccinelle/misc/swap.cocci CC: Denis Efremov Reported-by: kernel test robot Signed-off-by: kernel test robot --- tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git = master head: a9c9a6f741cdaa2fa9ba24a790db8d07295761e3 commit: 7845daa8bd72efa8bbc1de122edfce6e058bbe41 coccinelle: misc: add swap= script :::::: branch date: 16 hours ago :::::: commit date: 4 months ago Please take the patch only if it's a positive warning. Thanks! setup.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) --- a/arch/ia64/kernel/setup.c +++ b/arch/ia64/kernel/setup.c @@ -209,9 +209,7 @@ sort_regions (struct rsvd_region *rsvd_r for (j =3D 0; j < max; ++j) { if (rsvd_region[j].start > rsvd_region[j+1].start) { struct rsvd_region tmp; - tmp =3D rsvd_region[j]; - rsvd_region[j] =3D rsvd_region[j + 1]; - rsvd_region[j + 1] =3D tmp; + swap(rsvd_region[j], rsvd_region[j + 1]); } } } --===============4773310968396245468==--