Re: [GIT PULL FOR v5.16] uvcvideo v4l2-compliance fixes

[Mauro Carvalho Chehab <mchehab+huawei@kernel.org>]

Em Fri, 3 Sep 2021 15:41:22 +0300
Laurent Pinchart <laurent.pinchart@ideasonboard.com> escreveu:

> Hi Mauro, 
> 
> On Fri, Sep 03, 2021 at 02:04:27PM +0200, Mauro Carvalho Chehab wrote:
> > Em Mon, 23 Aug 2021 12:37:35 +0300
> > Laurent Pinchart <laurent.pinchart@ideasonboard.com> escreveu:
> >   
> > > Hi Mauro,
> > > 
> > > The following changes since commit d62cd4d277cc711f781a7bdec4109c6148529b25:
> > > 
> > >   media: uvcvideo: Remove unused including <linux/version.h> (2021-08-21 09:11:04 +0200)
> > > 
> > > are available in the Git repository at:
> > > 
> > >   git://linuxtv.org/pinchartl/media.git tags/uvc-next-20210823
> > > 
> > > for you to fetch changes up to 2bc2b78476b4bc5690186c2b9a4dd565be6a9913:
> > > 
> > >   media: uvcvideo: Don't spam the log in uvc_ctrl_restore_values() (2021-08-23 12:31:04 +0300)
> > > 
> > > This contains a subset of "[PATCH v10 00/21] Fix v4l2-compliance errors"
> > > as 17 out of the 21 patches are ready to go and don't need to be
> > > delayed.
> > > 
> > > ----------------------------------------------------------------
> > > - uvcvideo v4l2-compliance fixes
> > > 
> > > ----------------------------------------------------------------
> > > Hans Verkuil (1):
> > >       media: uvcvideo: Don't spam the log in uvc_ctrl_restore_values()
> > > 
> > > Ricardo Ribalda (16):
> > >       media: v4l2-ioctl: Fix check_ext_ctrls
> > >       media: pvrusb2: Do not check for V4L2_CTRL_WHICH_DEF_VAL
> > >       media: uvcvideo: Do not check for V4L2_CTRL_WHICH_DEF_VAL
> > >       media: v4l2-ioctl: S_CTRL output the right value
> > >       media: uvcvideo: Remove s_ctrl and g_ctrl
> > >       media: uvcvideo: Set capability in s_param
> > >       media: uvcvideo: Return -EIO for control errors
> > >       media: uvcvideo: refactor __uvc_ctrl_add_mapping
> > >       media: uvcvideo: Add support for V4L2_CTRL_TYPE_CTRL_CLASS
> > >       media: uvcvideo: Use dev->name for querycap()
> > >       media: uvcvideo: Set unique vdev name based in type
> > >       media: uvcvideo: Increase the size of UVC_METADATA_BUF_SIZE  
> > 
> > Patches applied.
> >   
> > >       media: uvcvideo: Use control names from framework
> > >       media: uvcvideo: Check controls flags before accessing them
> > >       media: uvcvideo: Set error_idx during ctrl_commit errors  
> > 
> > I didn't apply those three. The first one seems to be causing
> > memory leaks, and the other two are dependent on the first one.  
> 
> Ricardo has replied to your review.

OK. Patches applied.


Thanks,
Mauro