From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A510DC433EF for ; Sat, 4 Sep 2021 17:01:33 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CF51160F42 for ; Sat, 4 Sep 2021 17:01:32 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org CF51160F42 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 5151D83167; Sat, 4 Sep 2021 19:01:30 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="ofbEi/N/"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 7C15B8318E; Sat, 4 Sep 2021 19:01:28 +0200 (CEST) Received: from mail-qv1-xf32.google.com (mail-qv1-xf32.google.com [IPv6:2607:f8b0:4864:20::f32]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 9286583131 for ; Sat, 4 Sep 2021 19:01:24 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qv1-xf32.google.com with SMTP id ew6so1585062qvb.5 for ; Sat, 04 Sep 2021 10:01:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=/30A51F9mArHGdh1xnYibAi3wP+2xNvQgjdIyk7SL84=; b=ofbEi/N/44BO8duPEdz3YE3JI8pl6SPNPg9Pp93sbnb5KX8nGGevnrJuxCwDeezQeQ CkY7RtBKZcg8uo/cggGbONJbK39IlRcLxU+ghUt1BrS0DffXe/44hNNDQuBZ2rW2yXnV iHtjCArdYoMMcfqVdyMV72Em2Pr7oWOl9weFo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=/30A51F9mArHGdh1xnYibAi3wP+2xNvQgjdIyk7SL84=; b=dAgC37sR3P6vDOqZE6O1+Bb5dLn/wi6nbRnCiQKlYcaslRhvP/zkue0/hzvvFX7qzu 5BIyfYuU1jrmtgR3krNmjdNeMfb1vbT4npaI+PhVzodXY/3lPxN9l6AJlh3GMxiQtYNK GN4DVr9UUwfI1JuC/EtfwboIfafHgRSdZp72jvYuh2E9OSeCQalElzZl4YZXGkqV2Jtu G94srECjb3NBy8m5fCdbKKuSEmG7CcoGgJezaRlB8CrLoR00/mpYYA9vA7KoZtU1ofml EYdCwHXYtRFGbkhcB4tetRNTikLq1GXfLWCOxa4itWS3+wxCTvBEUrcw7V3LHTK/fQUm QTcA== X-Gm-Message-State: AOAM533svPvBwbpxXamcohRqN7yDszQrWDMesi9fkvD8aIxItus245rb RXE3S3+bQX7B2zBdEwb9QuvXSg== X-Google-Smtp-Source: ABdhPJzA1vNuUIDECY8kOS7iBUyh36DecfpdN1mlRSjoRd8Pd4kDvi2r5B7G8MpA4pNZ3oTKbQOWcw== X-Received: by 2002:a0c:eccb:: with SMTP id o11mr4754173qvq.48.1630774883285; Sat, 04 Sep 2021 10:01:23 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b01-cbda-eda5-0c2a-e600-b83e.res6.spectrum.com. [2603:6081:7b01:cbda:eda5:c2a:e600:b83e]) by smtp.gmail.com with ESMTPSA id a22sm1850478qtw.59.2021.09.04.10.01.22 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Sat, 04 Sep 2021 10:01:22 -0700 (PDT) Date: Sat, 4 Sep 2021 13:01:20 -0400 From: Tom Rini To: Marek Vasut Cc: u-boot@lists.denx.de Subject: Re: [PATCH 02/14] lmb: Use CONFIG_LMB_*_REGIONS only if they are defined Message-ID: <20210904170120.GH12964@bill-the-cat> References: <20210829231145.GN858@bill-the-cat> <95c965a3-2da8-1212-fb54-0d5628d7743b@denx.de> <20210830120102.GO858@bill-the-cat> <678a77d9-356a-e924-da8e-102fba938ee3@denx.de> <20210904141019.GC12964@bill-the-cat> <72c92d4d-f064-f7f3-dd4b-57cf994009db@denx.de> <20210904151714.GE12964@bill-the-cat> <20210904160901.GF12964@bill-the-cat> <2de2fee5-dcba-fc40-471e-3f4e1f1147bb@denx.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="cfJ13FhsvNR/yOpm" Content-Disposition: inline In-Reply-To: <2de2fee5-dcba-fc40-471e-3f4e1f1147bb@denx.de> X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.9.4 (2018-02-28) X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean --cfJ13FhsvNR/yOpm Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable [trimming the CC list] On Sat, Sep 04, 2021 at 06:49:03PM +0200, Marek Vasut wrote: > On 9/4/21 6:09 PM, Tom Rini wrote: > > On Sat, Sep 04, 2021 at 06:05:50PM +0200, Marek Vasut wrote: > > > On 9/4/21 5:17 PM, Tom Rini wrote: > > > > On Sat, Sep 04, 2021 at 05:15:45PM +0200, Marek Vasut wrote: > > > > > On 9/4/21 4:10 PM, Tom Rini wrote: > > > > > [...] > > > > >=20 > > > > > > > > > > At this point, I think you should rework things to stop= making > > > > > > > > > > CONFIG_LMB be optional, it should be a def_bool y. > > > > > > > > >=20 > > > > > > > > > I disagree, see above. > > > > > > > >=20 > > > > > > > > The only reason "tools-only_defconfig" builds a useless u-b= oot binary > > > > > > > > today is in CI where it would be more work than it's worth = to make CI > > > > > > > > exclude that from the build list. But if you want to just = do that > > > > > > > > instead, I'll also accept adding -x tools-only to the azure= /gitlab jobs > > > > > > > > that build all other architectures, as tools-only is tested= in its own > > > > > > > > build job, for it's only valid build target. > > > > > > >=20 > > > > > > > The tools-only build is also used elsewhere, to build just th= at, tools. > > > > > >=20 > > > > > > I've repeatedly explained myself and what I'm looking for in v2= of this > > > > > > series. I will summarize one last time. The "tools-only_defco= nfig" is > > > > > > for tools, only. Building anything other than the "tools-only"= target > > > > > > isn't useful. In U-Boot itself, LMB is required as that is how= we > > > > > > prevent a number of CVEs from being trivial to exploit. v2 of = this > > > > > > series needs to drop patches 1 and 2 of v1 of this series. It = can > > > > > > further do any of: > > > > > > 1. Nothing else. > > > > > > 2. Add tools-only to the exclude list in the "build everything = else" CI > > > > > > job. > > > > > > 3. Make CONFIG_LMB be def_bool y. > > > > >=20 > > > > > If tools-only is for tools, only, then why should it enable LMB ? > > > > > The tools are userspace tools, they do not need LMB, and so LMB c= an be > > > > > disabled. > > > > >=20 > > > > > This is the part which is unclear to me. > > > >=20 > > > > I don't know why it's unclear to you at this point, sorry. > > >=20 > > > Well why exactly does a userspace program require LMB enabled ? > > > What does LMB protect in there ? obviously not U-Boot. > >=20 > > I feel like you've lost the thread. >=20 > Can you please answer my questions above ? I have. --=20 Tom --cfJ13FhsvNR/yOpm Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmEzpmAACgkQFHw5/5Y0 tyyXmQv/Z8+BAr3vSTwoya/ofLBcihp7S+Jpl0+fqUS6lGCT+QY9WIYE6dIPWIg8 HOJtDlyJGIZ8Z4TdWfnwneC7fMBpbQvjgt3ZhCCu8FhWLvXB0QhT5bTeu3IRBCI9 HWx9Ara/N6LVhw4fxyt/piR//T+zTfEeoIwnHLa0ommWP+3/U8j/Qn7VSr7P4VHY Gp0K5FqXsk278E6jcDg14MSxvEUHA6WOpCygQmvOP7kOQ+R02+rOUTqA7Om8FsCH QETdiLRTmLb4i+6J2R06Ix7lsgw1+PIVJZddBcbZnp0orEliKI9UwPp2cyQdnkZl YqwjM4DvSviXJegrcHn87w49Vstan93+X8DSuBpWsugcaZsKgZKYkyrRlbm+mwIf ACzIG/aO3xKD+m98YauSBslzknCLggzaFy/9hE0PX3CB1ZmSg2m+PXCPK/luSolX 2zZH053NAfxp/28s0LfQkYeelD2irjH2IyGcTt/P7ac8BBMCvcFkiMf14kU1wXeP 9RGs47i1 =80nC -----END PGP SIGNATURE----- --cfJ13FhsvNR/yOpm--