From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PULL_REQUEST, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 813CCC433EF for ; Sat, 4 Sep 2021 18:08:38 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A004760F90 for ; Sat, 4 Sep 2021 18:08:37 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org A004760F90 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id ED2F183265; Sat, 4 Sep 2021 20:08:34 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="JZ9Ty2KB"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 0601383265; Sat, 4 Sep 2021 20:08:33 +0200 (CEST) Received: from mail-qt1-x82c.google.com (mail-qt1-x82c.google.com [IPv6:2607:f8b0:4864:20::82c]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 172558318E for ; Sat, 4 Sep 2021 20:08:29 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qt1-x82c.google.com with SMTP id t35so2061590qtc.6 for ; Sat, 04 Sep 2021 11:08:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=ErNqUWblEBP5Y5VHZebACHPkrJqtCaIB1z1QyHLkpbU=; b=JZ9Ty2KBJh3NhZkNgKuA259S5rHGb32v1rhivtDNr1uO3+Tyht0mOQyQBPGYI3byEO snL3FD13fqKFn7/jZ+XcOmm4WWqsqDLcfDgFVoMuQPZWFwKddD182WBZCQQZXYZuco4u km6s2d+3UFwMnIpuDYUsDZi1pTp+dNcaGiUMg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=ErNqUWblEBP5Y5VHZebACHPkrJqtCaIB1z1QyHLkpbU=; b=b23unN/kepCT02ZGL+eEtnNrHLwEL3oLD9+YLF0t/u0DbdYGy6CdXWqfmPn0iO39bY rPNm70UTgtvJvOPHfB59KbjirCIHnktjgNd8a4nNm50UdXZtUGxcBxgKd7B9lzOS7E1a htGXEJ7np73ht6fejAZqT6fjX6H1ZP0OF95UnzI+412P72rSE/Bq3ZoAjAtHSG0hw5K+ 2GMH/exEJCMlCkqQWo1wWD9KyW5yO8SkKdnc4qaDCMJdeVo1BTWbFpUgYzCcdmqjmc9t 2O84Bk6MgN+heKoYoaIpzvCq8uTlCZzVXczZbb4mG5NHDDJ/l5dXeNgkkzFdbr5mEdBG V4/w== X-Gm-Message-State: AOAM531kjE3wzVWb89bv9HFfiF1I/lwLF8EQRk9bavwRu3v5QqEED2AN XEhFrH7c5xPsJY7h2faB1Gor0X+J7lwqx3QJ X-Google-Smtp-Source: ABdhPJxxQFgze3+GqW4zDacGp+s5oGfwapYUFLOIPA+23ez1drDnFotgA1SY0Q7O5WXll24syGQMiQ== X-Received: by 2002:a05:622a:5d4:: with SMTP id d20mr4464813qtb.376.1630778907822; Sat, 04 Sep 2021 11:08:27 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b01-cbda-eda5-0c2a-e600-b83e.res6.spectrum.com. [2603:6081:7b01:cbda:eda5:c2a:e600:b83e]) by smtp.gmail.com with ESMTPSA id v145sm2158835qkb.132.2021.09.04.11.08.26 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Sat, 04 Sep 2021 11:08:27 -0700 (PDT) Date: Sat, 4 Sep 2021 14:08:25 -0400 From: Tom Rini To: Heinrich Schuchardt Cc: U-Boot Mailing List , Alexander Graf , Masahisa Kojima , Ilias Apalodimas , AKASHI Takahiro , Simon Glass Subject: Re: Pull request for efi-2021-10-rc4 Message-ID: <20210904180825.GJ12964@bill-the-cat> References: <61e2e1cc-b474-84dd-eceb-bb86a59972be@gmx.de> <20210904130111.GA12964@bill-the-cat> <20210904143722.GD12964@bill-the-cat> <46CAD3CD-41FA-43B9-9099-225711B754E1@gmx.de> <20210904173949.GI12964@bill-the-cat> <8FD4F99B-E1A5-4842-8BB8-EA2749E4761B@gmx.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="huG+SbfbdD6eblZQ" Content-Disposition: inline In-Reply-To: <8FD4F99B-E1A5-4842-8BB8-EA2749E4761B@gmx.de> X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.9.4 (2018-02-28) X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean --huG+SbfbdD6eblZQ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Sep 04, 2021 at 08:02:49PM +0200, Heinrich Schuchardt wrote: >=20 >=20 > Am 4. September 2021 19:39:49 MESZ schrieb Tom Rini : > >On Sat, Sep 04, 2021 at 07:03:48PM +0200, Heinrich Schuchardt wrote: > >>=20 > >>=20 > >> Am 4. September 2021 16:37:22 MESZ schrieb Tom Rini : > >> >On Sat, Sep 04, 2021 at 03:08:38PM +0200, Heinrich Schuchardt wrote: > >> >>=20 > >> >>=20 > >> >> Am 4. September 2021 15:01:11 MESZ schrieb Tom Rini : > >> >> >On Sat, Sep 04, 2021 at 11:56:47AM +0200, Heinrich Schuchardt wrot= e: > >> >> > > >> >> >> Dear Tom, > >> >> >>=20 > >> >> >> The following changes since commit 94509b79b13e69c209199af0757af= bde8d2ebd6d: > >> >> >>=20 > >> >> >> btrfs: Use default subvolume as filesystem root (2021-09-01 10= :11:24 > >> >> >> -0400) > >> >> >>=20 > >> >> >> are available in the Git repository at: > >> >> >>=20 > >> >> >> https://source.denx.de/u-boot/custodians/u-boot-efi.git > >> >> >> tags/efi-2021-10-rc4 > >> >> >>=20 > >> >> >> for you to fetch changes up to 1dfa494610c5469cc28cf1f8538abf4be= 6c00324: > >> >> >>=20 > >> >> >> efi_loader: fix efi_tcg2_hash_log_extend_event() parameter che= ck > >> >> >> (2021-09-04 09:15:09 +0200) > >> >> >>=20 > >> >> >> ---------------------------------------------------------------- > >> >> >> Pull request for efi-2021-10-rc4 > >> >> >>=20 > >> >> >> Documentation: > >> >> >>=20 > >> >> >> Remove invalid reference to configuration variable in UEFI d= oc > >> >> >>=20 > >> >> >> UEFI: > >> >> >>=20 > >> >> >> Parameter checks for the EFI_TCG2_PROTOCOL > >> >> >> Improve support of preseeding UEFI variables. > >> >> >> Correct the calculation of the size of loaded images. > >> >> >> Allow for UEFI images with zero VirtualSize > >> >> >>=20 > >> >> >> ---------------------------------------------------------------- > >> >> >> Heinrich Schuchardt (5): > >> >> >> efi_loader: sections with zero VirtualSize > >> >> >> efi_loader: rounding of image size > >> >> >> efi_loader: don't load signature database from file > >> >> >> efi_loader: efi_auth_var_type for AuditMode, DeployedMode > >> >> >> efi_loader: correct determination of secure boot state > >> >> >>=20 > >> >> >> Masahisa Kojima (3): > >> >> >> efi_loader: add missing parameter check for EFI_TCG2_PROTO= COL api > >> >> >> efi_loader: fix boot_service_capability_min calculation > >> >> >> efi_loader: fix efi_tcg2_hash_log_extend_event() parameter= check > >> >> > > >> >> >And I don't see Simon's revert in here either. And he asked you a= bout > >> >> >that yesterday: > >> >> >https://lore.kernel.org/r/CAPnjgZ3eRdjF0jb9S-cJK6y+feuyRyWf0hNkf2t= riB4DR4UFBQ@mail.gmail.com/ > >> >> > > >> >> >So at this point, are you asserting there is nothing to revert? > >> >>=20 > >> >> Never. Simons "revert" is breaking functionality. The concept for s= uporting blobs in devicetrees supplied by a prior bootstage has not been de= fined yet. > >> > > >> >And to be clearer, reverting something that was introduced in one rc = in > >> >a later rc isn't breaking functionality. U-Boot releases (well, the > >> >non-rc ones for sure) are on a very regular schedule. External proje= cts > >> >may not depend on some feature introduced at -rcN unless they're will= ing > >> >to accept that some changes could happen before release. > >> > > >>=20 > >> There is no value delivered by Simon's series. Neither does the image = get smaller nor does it fix anything. If he wants to enforce a design, it m= ust work for all use cases. But this requires some conceptual work. > > > >Yes, and what's the rush to not do the conceptual work? If I recall > >part of the thread correctly, yes, Simon didn't get his objections in > >before the patches were merged, but it was early enough in the release > >cycle that taking a step back and reverting was a reasonable request. > >What he had said wouldn't have changed if he had gotten the email out a > >few days earlier. > > > >So yes, please merge Simon's revert, or post and merge new more minimal > >revert that brings things to the same functional end. There are > >objections to this implementation, and thus far Simon has been > >responding all of the requests to better clarify all of the related code > >and concepts that have been asked of him, so that in the end an > >implementation that fulfills all of the technical requirements can be > >created, that hopefully leaves all parties satisfied. >=20 > There is nothing wrong with the current code. >=20 > It is Simon's concept of blobs in devicetrees that is borked in that > it ignores QEMU and any board that gets the DT from a prior boot > stage. Then it should be pretty easy to get Simon to withdraw his objections, if there's such a fundamental "this is the only possible way, no changes" path forward. > Simon's patches have no functional end. So what do you mean by "same func= tional end"? I mean the state of the EFI subsystem, prior to the code in question being merged, without breaking the other assorted EFI changes that have come in since then. --=20 Tom --huG+SbfbdD6eblZQ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmEztg8ACgkQFHw5/5Y0 tyxyTAv8CPu9c7L+2Gwrfy/t6aXbJkxMNaJRZT19ZwyFUR8eGenu+DMyfaH3d9D5 EOnW7qPACbvDmmhQpNYmclEpgdLL4jfn5v7mEQbCALOyId0/IoqxZvXyldHykTJ4 7QuVMdGKTiTGD99J/1LUPAuUGhk3Hl9hzQuYsoD9BoMKxTIQxiYV/ZZF/c/g7zEK KILn9hydiF6VhkzThjSxMrOE2Vd0E2TufBAHS7mhyF1bd27iitP5Swboj6CXtkRt FR56Xz0xNHjaV2jMnIC1hTuaBJ4ikNtyKAPxlrAkGhDGPtbsa0OLbEobO9cPr+/N aKNrD2wkxesHr/4NoG/+qa5tnvsd6t/shn32cEK9xS/aYLBolvTXtEY3KcSG+/wO ndVbJv01+n8dy6fLnbMkQ4PD+z1g41L3AnuSsjgMGFGmJRlkD0jntpMErt4SrHtQ gmjX3DMeAJsBGyeebrCIJjpkBceZSNiNMqKoM19ZBr516h3ttYbGJgo6+xrDb/on 0rpFMyM8 =zQZe -----END PGP SIGNATURE----- --huG+SbfbdD6eblZQ--