From: Phillip Potter <phil@philpotter.co.uk>
To: gregkh@linuxfoundation.org
Cc: Larry.Finger@lwfinger.net, straube.linux@gmail.com,
linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev
Subject: [PATCH 00/14] staging: r8188eu: cleanup unset pointers in
Date: Mon, 6 Sep 2021 02:00:52 +0100 [thread overview]
Message-ID: <20210906010106.898-1-phil@philpotter.co.uk> (raw)
This series removes all remaining pointers from struct hal_ops that are
never set anywhere else in the driver. As a part of this, it also takes
out the wrapper functions and their callers, given that they mostly never
end up calling/returning the function pointer value as they check for
NULL.
There are two exceptions to this however, and therefore this series also
fixes two potentially triggerable NULL pointer dereference bugs.
Phillip Potter (14):
staging: r8188eu: remove rtw_hal_reset_security_engine function
staging: r8188eu: remove hal_reset_security_engine from struct hal_ops
staging: r8188eu: remove rtw_hal_enable_interrupt function
staging: r8188eu: remove enable_interrupt from struct hal_ops
staging: r8188eu: remove rtw_hal_disable_interrupt function
staging: r8188eu: remove disable_interrupt from struct hal_ops
staging: r8188eu: remove rtw_hal_interrupt_handler function
staging: r8188eu: remove interrupt_handler from struct hal_ops
staging: r8188eu: remove rtw_hal_xmitframe_enqueue function
staging: r8188eu: remove hal_xmitframe_enqueue from struct hal_ops
staging: r8188eu: remove Efuse_PgPacketWrite_BT function
staging: r8188eu: remove Efuse_PgPacketWrite_BT from struct hal_ops
staging: r8188eu: remove rtw_hal_c2h_id_filter_ccx function
staging: r8188eu: remove c2h_id_filter_ccx from struct hal_ops
drivers/staging/r8188eu/core/rtw_cmd.c | 9 +----
drivers/staging/r8188eu/core/rtw_efuse.c | 13 +------
drivers/staging/r8188eu/core/rtw_recv.c | 2 -
drivers/staging/r8188eu/hal/hal_intf.c | 44 ----------------------
drivers/staging/r8188eu/include/hal_intf.h | 19 ----------
5 files changed, 3 insertions(+), 84 deletions(-)
--
2.31.1
next reply other threads:[~2021-09-06 1:01 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-06 1:00 Phillip Potter [this message]
2021-09-06 1:00 ` [PATCH 01/14] staging: r8188eu: remove rtw_hal_reset_security_engine function Phillip Potter
2021-09-06 1:00 ` [PATCH 02/14] staging: r8188eu: remove hal_reset_security_engine from struct hal_ops Phillip Potter
2021-09-06 8:25 ` Dan Carpenter
2021-09-06 23:05 ` Phillip Potter
2021-09-06 1:00 ` [PATCH 03/14] staging: r8188eu: remove rtw_hal_enable_interrupt function Phillip Potter
2021-09-06 1:00 ` [PATCH 04/14] staging: r8188eu: remove enable_interrupt from struct hal_ops Phillip Potter
2021-09-06 1:00 ` [PATCH 05/14] staging: r8188eu: remove rtw_hal_disable_interrupt function Phillip Potter
2021-09-06 1:00 ` [PATCH 06/14] staging: r8188eu: remove disable_interrupt from struct hal_ops Phillip Potter
2021-09-06 1:00 ` [PATCH 07/14] staging: r8188eu: remove rtw_hal_interrupt_handler function Phillip Potter
2021-09-06 1:01 ` [PATCH 08/14] staging: r8188eu: remove interrupt_handler from struct hal_ops Phillip Potter
2021-09-06 1:01 ` [PATCH 09/14] staging: r8188eu: remove rtw_hal_xmitframe_enqueue function Phillip Potter
2021-09-06 1:01 ` [PATCH 10/14] staging: r8188eu: remove hal_xmitframe_enqueue from struct hal_ops Phillip Potter
2021-09-06 1:01 ` [PATCH 11/14] staging: r8188eu: remove Efuse_PgPacketWrite_BT function Phillip Potter
2021-09-06 1:01 ` [PATCH 12/14] staging: r8188eu: remove Efuse_PgPacketWrite_BT from struct hal_ops Phillip Potter
2021-09-06 1:01 ` [PATCH 13/14] staging: r8188eu: remove rtw_hal_c2h_id_filter_ccx function Phillip Potter
2021-09-06 1:01 ` [PATCH 14/14] staging: r8188eu: remove c2h_id_filter_ccx from struct hal_ops Phillip Potter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210906010106.898-1-phil@philpotter.co.uk \
--to=phil@philpotter.co.uk \
--cc=Larry.Finger@lwfinger.net \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=straube.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.