From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1mNmKa-0003wx-52 for mharc-grub-devel@gnu.org; Tue, 07 Sep 2021 21:24:52 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35168) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mNmKZ-0003wo-4M for grub-devel@gnu.org; Tue, 07 Sep 2021 21:24:51 -0400 Received: from mail-io1-xd2d.google.com ([2607:f8b0:4864:20::d2d]:39643) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mNmKW-0007Bq-5e for grub-devel@gnu.org; Tue, 07 Sep 2021 21:24:50 -0400 Received: by mail-io1-xd2d.google.com with SMTP id m11so1026451ioo.6 for ; Tue, 07 Sep 2021 18:24:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=efficientek-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references:reply-to :mime-version:content-transfer-encoding; bh=E5gCSKtczIW9WxMkfpKB/cHO0Is99KWTpSsLe2Ww60k=; b=maJgGyOWCDUpyWlT7B7ZAV+fXF/XfitUkU0wMM6D7H/ym9V1SjAL26vKGFm4Eeyw1Q ImoyAOp2cuYuqFgzhUUK0JmHHsPNBIXmdvn+9tcdqcy0BbSK6RjmvzYZM6e1XwlTIr+R POgWVokVAcfO0+j2TbVrFDur8RdbnnnvR3MQ9Jb5h/FmFQHvbI91plKG70wO38iYTjYM uH3fFhM4lCvzGSiBMbYqWM0Yx4W4L/uk+Po5T6cboG8tsFzec1bVEhuJUv1yBMz9NwZN A+x4Ylg2TQST9iyICCzIUx/y9WHuhqINceN4PRTjWZFMWv5MqI7YgGvIib+pBrFQzCP+ nsfw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:reply-to:mime-version:content-transfer-encoding; bh=E5gCSKtczIW9WxMkfpKB/cHO0Is99KWTpSsLe2Ww60k=; b=T7tGcZuv73/6mQc6sqHbO1VoWM6qL6mcREwNSQz3jGvC0TluvhzkyBQAjNcX5vqd4/ 1lu8AWp6J2qbcNMjLWgaN45aOpUMI16CpSlMlUamASC5JWDZKJAJanhxIPse/AiuTDy4 jusRf9QmPOKGPQAzv0H60K/NvHUwsRBBBHXF2S4fxUEbaVKV/58yf+fS0fyDhAzoTkiK KdHM8izQOzqK/u0ao7ndegeRb+Z+q3yk0HEACzAxGkd5Mh/XHxYbG6X58Trh74qCSDuj 5EmEYc8gQpsLXdKLFSWauc8KFlCx0AGCgT0n9J7JLrm1ElhrNh4kMK00MVshGMHzxlFB vIqg== X-Gm-Message-State: AOAM531WrlWGWTrMa2bCnJkMKjqCMdsNRCCAM+dGg3iMneAJPbY58Pe2 oaeXLSmJ5zlG/em5VVk4ysJj1g== X-Google-Smtp-Source: ABdhPJxmWQvjLYM3bkFKmk1YsqwfwQDk3mgPSkTQ1gg5PUPPIaKXC4sgjsUbc+nv6lP3y1OGgTPRpg== X-Received: by 2002:a6b:fb07:: with SMTP id h7mr988351iog.201.1631064286333; Tue, 07 Sep 2021 18:24:46 -0700 (PDT) Received: from ubuntu ([185.220.103.12]) by smtp.gmail.com with ESMTPSA id m26sm308007ioj.54.2021.09.07.18.24.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Sep 2021 18:24:46 -0700 (PDT) Date: Wed, 8 Sep 2021 01:22:20 +0000 From: Glenn Washburn To: Carlos Maiolino Cc: The development of GNU GRUB , Daniel Kiper , Erwan Velu , Erwan Velu , javierm@redhat.com Subject: Where is the testing? (was: Re: [PATCH] fs/xfs: Avoid unreadble filesystem if V4 superblock) Message-ID: <20210908012220.60a34a2a@ubuntu> In-Reply-To: <20210902085649.zucibvxhnez2meys@omega.lan> References: <20210825133152.1165682-1-e.velu@criteo.com> <20210826132616.dhhiwdowapcolrdr@omega.lan> <20210830114850.kemzuknbe4nwzkip@omega.lan> <20210901124057.qqmqkjh7k3dkgnsv@tomti.i.net-space.pl> <20210902085649.zucibvxhnez2meys@omega.lan> Reply-To: development@efficientek.com X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2607:f8b0:4864:20::d2d; envelope-from=development@efficientek.com; helo=mail-io1-xd2d.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Sep 2021 01:24:51 -0000 On Thu, 2 Sep 2021 10:56:49 +0200 Carlos Maiolino wrote: > On Wed, Sep 01, 2021 at 02:40:57PM +0200, Daniel Kiper wrote: > > CC-ing Javier... > >=20 > > On Mon, Aug 30, 2021 at 01:48:50PM +0200, Carlos Maiolino wrote: > > > Hi. > > > On Mon, Aug 30, 2021 at 11:18:31AM +0200, Erwan Velu wrote: > > > > Good day list, > > > > Le jeu. 26 ao=C3=BBt 2021 =C3=A0 15:26, Carlos Maiolino > > > > <[1]cmaiolino@redhat.com> a =C3=A9crit : > > > > > > > > [..] > > > > Thanks for spotting this! > > > > > > > > I'm adding the maintainers in CC. Carlos who commit the > > > > patch I'm fixing, agreed on the content. > > > > > > I didn't test the patch itself yet, but I've reproduced the > > > issue. I was quite sure I had tested this patch on a V4 fs, but > > > looks like I miscalculated the sizing. Thanks again. I'll try to > > > test the patch here asap. > >=20 > > Did you test this patch? If yes may I add your Tested-by to it? >=20 > Yup, patch works fine, just finished testing it, I was just trying to > understand where/why I miscalculated the inode size on V4 > filesystems, and the reason was the same why Erwan split the > last/first members of inode v2/v3 in two different unused structs. >=20 > Feel free to add to the patch: >=20 > Tested-by: Carlos Maiolino It looks like the xfs_test test succeeds with tag grub-2.06-rc1a, fails with tag grub-2.06, and succeeds with current master. Yes, as expected. However, what this tells me is that no "make check" tests were done before finalizing the 2.06 release. I was under the impression that that was part of the release procedure. If its not, it would seem that we're not using the tests at a time when they would have the most impact. It is my understanding that we have travis-ci tests that get run (at some point?), however they are only build tests and so would not have caught this. It was precisely this scenario that I hoped to avoid by doing more thorough continuous integration, which runs the extensive array of "make check" tests, when I submitted the Gitlab-CI patch series (which would've caught this automatically if it had been merged). To me this scenario is the poster child for taking action on this front. Can we make this a priority? Glenn